All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Mason <jdmason@kudzu.us>
To: Denys Dmytriyenko <denis@denix.org>
Cc: Sumit Garg <sumit.garg@linaro.org>, Jon Mason <jon.mason@arm.com>,
	meta-arm@lists.yoctoproject.org
Subject: Re: [meta-arm] [PATCH] arm-toolchain: use variables
Date: Tue, 5 Oct 2021 22:14:48 -0400	[thread overview]
Message-ID: <CAPoiz9z_J7w9ifpnYojQj9eQupiRF=pxmiy2X3Yd+_MwbGB0dA@mail.gmail.com> (raw)
In-Reply-To: <20211005235728.GI1528@denix.org>

Denys, I was waiting on you to ack the name Sumit suggested.

Thanks,
Jon

On Tue, Oct 5, 2021 at 7:57 PM Denys Dmytriyenko <denis@denix.org> wrote:
>
> On Tue, Sep 28, 2021 at 10:35:28AM +0530, Sumit Garg wrote:
> > On Tue, 28 Sept 2021 at 04:44, Jon Mason <jdmason@kudzu.us> wrote:
> > >
> > > On Mon, Sep 27, 2021 at 2:15 PM Denys Dmytriyenko <denis@denix.org> wrote:
> > > >
> > > > On Mon, Sep 27, 2021 at 09:18:20AM -0400, Jon Mason wrote:
> > > > > Use variables to make it easier to upgrade when the time comes.
> > > > >
> > > > > Change-Id: I9f2575279fe79bc0d895d47fdaffd2d5edd4aa59
> > > > > Signed-off-by: Jon Mason <jon.mason@arm.com>
> > > > > ---
> > > > >  .../recipes-devtools/gcc/gcc-arm-10.3.inc              | 10 +++++-----
> > > > >  1 file changed, 5 insertions(+), 5 deletions(-)
> > > > >
> > > > > diff --git a/meta-arm-toolchain/recipes-devtools/gcc/gcc-arm-10.3.inc b/meta-arm-toolchain/recipes-devtools/gcc/gcc-arm-10.3.inc
> > > > > index 72a6b46..187f4f4 100644
> > > > > --- a/meta-arm-toolchain/recipes-devtools/gcc/gcc-arm-10.3.inc
> > > > > +++ b/meta-arm-toolchain/recipes-devtools/gcc/gcc-arm-10.3.inc
> > > > > @@ -1,8 +1,8 @@
> > > > >  require recipes-devtools/gcc/gcc-common.inc
> > > > >
> > > > >  # Third digit in PV should be incremented after a minor release
> > > > > -
> > > > > -PV = "arm-10.3"
> > > > > +GCC_VERSION = "10.3"
> > > >
> > > > Isn't it too close to be confused with the global GCCVERSION variable in
> > > > meta/conf/distro/include/tcmode-default.inc that specifies gcc preference.
> > > > I realize this GCC_VERSION has a different use, but maybe the name should
> > > > be a bit clearer?
> > >
> > > I was a little quick on the trigger and pushed it already, but I agree
> > > with your point.  I'll do a follow-on patch to change it to a better
> > > name.  Suggestions?
> >
> > Maybe ARM_GCC_VERSION?
>
> Jon,
>
> Any update on this? Are you still looking for a different variable name?
>
> --
> Denys
>
> > -Sumit
> >
> > >
> > > Thanks,
> > > Jon
> > >
> > > >
> > > >
> > > > > +PV = "arm-${GCC_VERSION}"
> > > > >  CVE_VERSION = "10.3"
> > > > >
> > > > >  # BINV should be incremented to a revision after a minor gcc release
> > > > > @@ -13,7 +13,7 @@ MMYY = "21.07"
> > > > >  RELEASE = "20${MMYY}"
> > > > >  PR = "r${RELEASE}"
> > > > >
> > > > > -FILESEXTRAPATHS =. "${FILE_DIRNAME}/gcc-arm-10.3:${FILE_DIRNAME}/gcc-arm-10.3/backport:"
> > > > > +FILESEXTRAPATHS =. "${FILE_DIRNAME}/gcc-arm-${GCC_VERSION}:${FILE_DIRNAME}/gcc-arm-${GCC_VERSION}/backport:"
> > > > >
> > > > >  DEPENDS =+ "mpfr gmp libmpc zlib flex-native"
> > > > >  NATIVEDEPS = "mpfr-native gmp-native libmpc-native zlib-native flex-native"
> > > > > @@ -28,7 +28,7 @@ LIC_FILES_CHKSUM = "\
> > > > >      file://COPYING.RUNTIME;md5=fe60d87048567d4fe8c8a0ed2448bcc8 \
> > > > >  "
> > > > >
> > > > > -BASEURI ?= "https://developer.arm.com/-/media/Files/downloads/gnu-a/10.3-2021.07/srcrel/gcc-arm-src-snapshot-10.3-2021.07.tar.xz"
> > > > > +BASEURI ?= "https://developer.arm.com/-/media/Files/downloads/gnu-a/${GCC_VERSION}-${RELEASE}/srcrel/gcc-arm-src-snapshot-${GCC_VERSION}-${RELEASE}.tar.xz"
> > > > >  SRC_URI = "\
> > > > >             ${BASEURI} \
> > > > >             file://0001-gcc-4.3.1-ARCH_FLAGS_FOR_TARGET.patch \
> > > > > @@ -72,7 +72,7 @@ SRC_URI = "\
> > > > >  "
> > > > >  SRC_URI[md5sum] = "5f582fd50eee0e40475b93d2d7a18979"
> > > > >
> > > > > -S = "${TMPDIR}/work-shared/gcc-${PV}-${PR}/gcc-arm-src-snapshot-10.3-2021.07"
> > > > > +S = "${TMPDIR}/work-shared/gcc-${PV}-${PR}/gcc-arm-src-snapshot-${GCC_VERSION}-${RELEASE}"
> > > > >
> > > > >  # For dev release snapshotting
> > > > >  #S = "${TMPDIR}/work-shared/gcc-${PV}-${PR}/gcc-${RELEASE}"
> > > > > --
> > > > > 2.17.1
> > > > >


  reply	other threads:[~2021-10-06  2:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 13:18 [PATCH] arm-toolchain: use variables Jon Mason
2021-09-27 18:15 ` [meta-arm] " Denys Dmytriyenko
2021-09-27 23:13   ` Jon Mason
2021-09-28  5:05     ` Sumit Garg
2021-10-05 23:57       ` Denys Dmytriyenko
2021-10-06  2:14         ` Jon Mason [this message]
2021-10-06  2:18           ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPoiz9z_J7w9ifpnYojQj9eQupiRF=pxmiy2X3Yd+_MwbGB0dA@mail.gmail.com' \
    --to=jdmason@kudzu.us \
    --cc=denis@denix.org \
    --cc=jon.mason@arm.com \
    --cc=meta-arm@lists.yoctoproject.org \
    --cc=sumit.garg@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.