From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751261AbaKYPtE (ORCPT ); Tue, 25 Nov 2014 10:49:04 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35049 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbaKYPtB (ORCPT ); Tue, 25 Nov 2014 10:49:01 -0500 MIME-Version: 1.0 In-Reply-To: <54707ADB.30807@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54707ADB.30807@users.sourceforge.net> Date: Tue, 25 Nov 2014 10:48:59 -0500 Message-ID: Subject: Re: [PATCH 1/1] x86: PCI-Calgary: Deletion of an unnecessary check before the function call "free_tce_table" From: Jon Mason To: SF Markus Elfring Cc: "H. Peter Anvin" , Ingo Molnar , Muli Ben-Yehuda , Thomas Gleixner , x86@kernel.org, discuss@x86-64.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 22, 2014 at 7:00 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 22 Nov 2014 12:55:28 +0100 > > The free_tce_table() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Looks good to me Acked-by: Jon Mason > --- > arch/x86/kernel/pci-calgary_64.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c > index 0497f71..d22a386 100644 > --- a/arch/x86/kernel/pci-calgary_64.c > +++ b/arch/x86/kernel/pci-calgary_64.c > @@ -1476,8 +1476,7 @@ cleanup: > for (--bus; bus >= 0; --bus) { > struct calgary_bus_info *info = &bus_info[bus]; > > - if (info->tce_space) > - free_tce_table(info->tce_space); > + free_tce_table(info->tce_space); > } > return -ENOMEM; > } > -- > 2.1.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Mason Date: Tue, 25 Nov 2014 15:48:59 +0000 Subject: Re: [PATCH 1/1] x86: PCI-Calgary: Deletion of an unnecessary check before the function call "free_tc Message-Id: List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54707ADB.30807@users.sourceforge.net> In-Reply-To: <54707ADB.30807@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: "H. Peter Anvin" , Ingo Molnar , Muli Ben-Yehuda , Thomas Gleixner , x86@kernel.org, discuss@x86-64.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Sat, Nov 22, 2014 at 7:00 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 22 Nov 2014 12:55:28 +0100 > > The free_tce_table() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Looks good to me Acked-by: Jon Mason > --- > arch/x86/kernel/pci-calgary_64.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c > index 0497f71..d22a386 100644 > --- a/arch/x86/kernel/pci-calgary_64.c > +++ b/arch/x86/kernel/pci-calgary_64.c > @@ -1476,8 +1476,7 @@ cleanup: > for (--bus; bus >= 0; --bus) { > struct calgary_bus_info *info = &bus_info[bus]; > > - if (info->tce_space) > - free_tce_table(info->tce_space); > + free_tce_table(info->tce_space); > } > return -ENOMEM; > } > -- > 2.1.3 >