From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Date: Sat, 30 Aug 2014 11:42:34 +1000
Subject: [U-Boot] [PATCH 2/3] configs: zynq: Add config support for ZYBO
In-Reply-To: <OFC44BD889.84CD4704-ON86257D43.0024CD41-86257D43.0024CD47@ni.com>
References: <cover.1409223862.git.crosthwaite.peter@gmail.com>
	<b781b4d8405e1214256a8c782b03f8f43e777818.1409223862.git.crosthwaite.peter@gmail.com>
	<OFC44BD889.84CD4704-ON86257D43.0024CD41-86257D43.0024CD47@ni.com>
Message-ID: <CAPokK=rkdteXA7jheV_HGKYFd1D5DioxTLZQ5d4k+3=sMNLcdg@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Aug 29, 2014 at 4:41 PM, Steve Wang <steven.wang@digilentinc.com> wrote:
> Hi, Peter,
>
> In ZYBO, there is an on-board eeprom that contains a unique MAC address for
> each board.
> In FSBL (before u-boot), the MAC address is read out from EEPROM and write
> to the corresponding registers in ETH controller.
> So, in u-boot env, mac-skip should be defined so that it will not over-write
> the unique MAC address.
>

Is this condition auto-detectable? If an earlier boot stage has set
the MAC address that should be visible to the driver. Then the env is
given the concept of a "weak" mac address - one that is set if the
hardware is not initialised already.

This EEPROM MAC pre-init concept is also applicable to other Zynq
boards that contain EEPROM such as 70x so I think its more general
than ZYBO.

> So, I wonder if it should be done in dts file or there is other ways to do
> that.
>

DTS might work, is it a "chosen" perhaps? If the value is absent, then
u-boot will do nothing and assume other boot stages will do MAC addr
init.

Regards,
Peter

> Thanks indeed!
> Regards,
> Steve
>
>
> -----Peter Crosthwaite <crosthwaitepeter@gmail.com> wrote: -----
> To: u-boot at lists.denx.de
> From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
> Date: 08/28/2014 04:16AM
> Cc: michals at xilinx.com, steven.wang at digilentinc.com
> Subject: [PATCH 2/3] configs: zynq: Add config support for ZYBO
>
>
> From: Tinghui Wang <steven.wang@digilentinc.com>
>
> This patch adds config support needed for ZYBO target and has
> been tested on Rev. B ZYBO hardware.
>
> Signed-off-by: Tinghui Wang <steven.wang@digilentinc.com>
> [PC changes:
>  * Dropped boards.cfg change (rebase conflict)
>  * Dropped custom u-boot env
>  * Added DTS
>  * Misc forward-porting changes
> ]
> Signed-off-by: Peter Crosthwiate <crosthwaite.peter@gmail.com>
>
> ---
> I have dropped the custom u-boot env from the original patch,
> as I'm not sure what the purpose was and I didn't need it for ZYBO SPL.
> ---
>  include/configs/zynq_zybo.h | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 include/configs/zynq_zybo.h
>
> diff --git a/include/configs/zynq_zybo.h b/include/configs/zynq_zybo.h
> new file mode 100644
> index 0000000..c167207
> --- /dev/null
> +++ b/include/configs/zynq_zybo.h
> @@ -0,0 +1,31 @@
> +/*
> + * (C) Copyright 2012 Xilinx
> + * (C) Copyright 2014 Digilent Inc.
> + *
> + * Configuration for Zynq Development Board - ZYBO
> + * See zynq_common.h for Zynq common configs
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#ifndef __CONFIG_ZYNQ_ZYBO_H
> +#define __CONFIG_ZYNQ_ZYBO_H
> +
> +#define CONFIG_SYS_SDRAM_SIZE (512 * 1024 * 1024)
> +
> +#define CONFIG_ZYNQ_SERIAL_UART1
> +#define CONFIG_ZYNQ_GEM0
> +#define CONFIG_ZYNQ_GEM_PHY_ADDR0 0
> +
> +#define CONFIG_SYS_NO_FLASH
> +
> +#define CONFIG_ZYNQ_SDHCI0
> +#define CONFIG_ZYNQ_BOOT_FREEBSD
> +#define CONFIG_DEFAULT_DEVICE_TREE zynq-zybo
> +
> +/* Define ZYBO PS Clock Frequency to 50MHz */
> +#define CONFIG_ZYNQ_PS_CLK_FREQ 50000000UL
> +
> +#include <configs/zynq-common.h>
> +
> +#endif /* __CONFIG_ZYNQ_ZYBO_H */
> --
> 1.9.1
>