All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajeshwari Birje <rajeshwari.birje@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] EXYNOS5: FDT: Add compatible strings for Serial
Date: Fri, 1 Mar 2013 11:44:12 +0530	[thread overview]
Message-ID: <CAPs=JDcTfve=XxXM9eWry+VhKNsE7=Hz_2ek_nYVByR+a1vUZQ@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ0a1hVBe2oMWNqL58XDpQxzO4Nv8L35T+9GgdZcjnUUSw@mail.gmail.com>

Hi Simon,

Thank you for comments.

On Thu, Feb 28, 2013 at 6:49 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi
>
> On Tue, Feb 26, 2013 at 10:01 PM, Rajeshwari Shinde
> <rajeshwari.s@samsung.com> wrote:
>> Add required compatible information for s5p serial driver
>>
>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> ---
>>  include/fdtdec.h |    1 +
>>  lib/fdtdec.c     |    1 +
>>  2 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/fdtdec.h b/include/fdtdec.h
>> index 77f244f..cca9be1 100644
>> --- a/include/fdtdec.h
>> +++ b/include/fdtdec.h
>> @@ -81,6 +81,7 @@ enum fdt_compat_id {
>>         COMPAT_SAMSUNG_EXYNOS_EHCI,     /* Exynos EHCI controller */
>>         COMPAT_SAMSUNG_EXYNOS_USB_PHY,  /* Exynos phy controller for usb2.0 */
>>         COMPAT_MAXIM_MAX77686_PMIC,     /* MAX77686 PMIC */
>> +       COMPAT_SAMSUNG_EXYNOS5_SERIAL,  /* Exynos5 UART */
>>
>>         COMPAT_COUNT,
>>  };
>> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
>> index 3ae348d..ec19c4b 100644
>> --- a/lib/fdtdec.c
>> +++ b/lib/fdtdec.c
>> @@ -56,6 +56,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
>>         COMPAT(SAMSUNG_EXYNOS_EHCI, "samsung,exynos-ehci"),
>>         COMPAT(SAMSUNG_EXYNOS_USB_PHY, "samsung,exynos-usb-phy"),
>>         COMPAT(MAXIM_MAX77686_PMIC, "maxim,max77686_pmic"),
>> +       COMPAT(SAMSUNG_EXYNOS5_SERIAL, "samsung,exynos-uart"),
>
> The kernel seems to have this:
>
>         serial at 12C00000 {
>                 compatible = "samsung,exynos4210-uart";
>                 reg = <0x12C00000 0x100>;
>                 interrupts = <0 51 0>;
>         };
>
> Should we use the same compatible string in U-Boot, or are you
> planning the change the kernel?
Okay in that case will keep the compatible string as "samsung,exynos4210-uart".
>
> Regards,
> Simon
>
>>  };
>>
>>  const char *fdtdec_get_compatible(enum fdt_compat_id id)
>> --
>> 1.7.4.4
>>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
-- 
Regards,
Rajeshwari Shinde

  reply	other threads:[~2013-03-01  6:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27  6:01 [U-Boot] [PATCH 0/4] SMDK5250: FDT: Add device tree support for console Rajeshwari Shinde
2013-02-27  6:01 ` [U-Boot] [PATCH 1/4] EXYNOS5: FDT: Add compatible strings for Serial Rajeshwari Shinde
2013-02-28  1:19   ` Simon Glass
2013-03-01  6:14     ` Rajeshwari Birje [this message]
2013-02-27  6:01 ` [U-Boot] [PATCH 2/4] EXYNOS5: FDT: Add serial device node values Rajeshwari Shinde
2013-02-27  6:01 ` [U-Boot] [PATCH 3/4] S5P: Serial: Add fdt support to driver Rajeshwari Shinde
2013-02-28  1:25   ` Simon Glass
2013-02-27  6:01 ` [U-Boot] [PATCH 4/4] CONFIG: EXYNOS5: Enable silent console Rajeshwari Shinde
2013-02-28  1:25   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPs=JDcTfve=XxXM9eWry+VhKNsE7=Hz_2ek_nYVByR+a1vUZQ@mail.gmail.com' \
    --to=rajeshwari.birje@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.