All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajeshwari Birje <rajeshwari.birje@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/8 V2] I2C: Modify the I2C driver for EXYNOS5
Date: Tue, 19 Jun 2012 12:58:09 +0530	[thread overview]
Message-ID: <CAPs=JDdMMCN_Pc9M9XZceVuJZ28vcLn5_HPp8yEjpYD00_Doeg@mail.gmail.com> (raw)
In-Reply-To: <CAPLVkLtnERhZCHRcapvSVnpfXKiejCUCtAcswuS41a=caUywfw@mail.gmail.com>

Hi Joonyoung Shim,

Thank you for comments.

On Tue, Jun 19, 2012 at 12:45 PM, Joonyoung Shim <dofmind@gmail.com> wrote:
>>>> +static void i2c_bus_init(struct s3c24x0_i2c *i2c, unsigned int bus)
>>>> +{
>>>> + ? ? ? int periph_id = i2c_get_periph_id(bus);
>>>> +
>>>> + ? ? ? exynos_pinmux_config(periph_id, 0);
>>>> +
>>>> + ? ? ? i2c_ch_init(i2c, CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
>>>> +}
>>>
>>> This function is used only in EXYNOS5.
>> -- This will be used in Multi bus also which other boards can use.
>
> But, this will cause compile errors at the s3c24xx.
-- Resoved the same and sent patch set.
>
>
> --
> - Joonyoung Shim

Regards,
Rajeshwari Shinde.

  reply	other threads:[~2012-06-19  7:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-07  6:09 [U-Boot] [PATCH 0/8 V2] EXYNOS5: Enable I2C support Rajeshwari Shinde
2012-06-07  6:09 ` [U-Boot] [PATCH 1/8 V2] EXYNOS: CLK: Add i2c clock Rajeshwari Shinde
2012-06-12  5:46   ` Simon Glass
2012-06-07  6:09 ` [U-Boot] [PATCH 2/8 V2] EXYNOS: Add I2C base address Rajeshwari Shinde
2012-06-07  6:09 ` [U-Boot] [PATCH 3/8 V2] EXYNOS: PINMUX: Add pinmux support for I2C Rajeshwari Shinde
2012-06-12  5:47   ` Simon Glass
2012-06-07  6:09 ` [U-Boot] [PATCH 4/8 V2] I2C: Move struct s3c24x0_i2c to a common place Rajeshwari Shinde
2012-06-07  6:09 ` [U-Boot] [PATCH 5/8 V2] I2C: S3C24X0: Add offset to calculate next i2c channel base address Rajeshwari Shinde
2012-06-07  6:09 ` [U-Boot] [PATCH 6/8 V2] I2C: Modify the I2C driver for EXYNOS5 Rajeshwari Shinde
2012-06-12  5:52   ` Simon Glass
2012-06-15  7:10   ` Joonyoung Shim
2012-06-19  5:38     ` Rajeshwari Birje
2012-06-19  7:15       ` Joonyoung Shim
2012-06-19  7:28         ` Rajeshwari Birje [this message]
2012-06-07  6:09 ` [U-Boot] [PATCH 7/8 V2] I2C: Add support for Multi channel Rajeshwari Shinde
2012-06-15  7:15   ` Joonyoung Shim
2012-06-19  5:44     ` Rajeshwari Birje
2012-06-19  7:30       ` Joonyoung Shim
2012-06-07  6:09 ` [U-Boot] [PATCH 8/8 V2] CONFIG: SMDK5250: I2C: Enable I2C Rajeshwari Shinde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPs=JDdMMCN_Pc9M9XZceVuJZ28vcLn5_HPp8yEjpYD00_Doeg@mail.gmail.com' \
    --to=rajeshwari.birje@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.