All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <mwilck@suse.com>
Cc: dm-devel@redhat.com, Guozhonghua <guozh88@chinatelecom.cn>
Subject: Re: [dm-devel] [PATCH v2 11/11] multipathd: remove unhelpful startup / shutdown messages
Date: Tue, 22 Mar 2022 10:38:13 -0500	[thread overview]
Message-ID: <CAPt1nt7-Rws3LnQttR_GZFCb04+G=F9Qcxkk50E7=CVKtfDU1A@mail.gmail.com> (raw)
In-Reply-To: <e86df86dc511e0092e15da399e2e713561fb13c9.camel@suse.com>

On Tue, Mar 22, 2022 at 4:30 AM Martin Wilck <mwilck@suse.com> wrote:
>
> On Mon, 2022-03-21 at 19:43 -0500, Benjamin Marzinski wrote:
> > On Fri, Mar 18, 2022 at 5:33 PM <mwilck@suse.com> wrote:
> > >
> > > From: Martin Wilck <mwilck@suse.com>
> > >
> > > These messages are noisy in the system log without being actually
> > > helpful.
> >
> > I've actually found the "start up" and "shut down" messages useful a
> > number of times, for tracking when multipathd starts up and shuts
> > down.
>
> Makes sense ;-)
>
> Currently we see the following messages for multipathd startup and
> shutdown:
>
> Mar 11 09:30:00 bremer systemd[1]: Starting Device-Mapper Multipath Device Controller.
> Mar 11 09:30:01 bremer multipathd[363]: --------start up--------
> Mar 11 09:30:01 bremer systemd[1]: Started Device-Mapper Multipath Device Controller.
> Mar 11 09:30:01 bremer multipathd[363]: read /etc/multipath.conf
> Mar 11 09:30:01 bremer multipathd[363]: path checkers start up
> ...
> Mar 11 09:30:52 bremer systemd[1]: Stopping Device-Mapper Multipath Device Controller...
> Mar 11 09:30:52 bremer multipathd[363]: exit (signal)
> Mar 11 09:30:52 bremer multipathd[363]: --------shut down-------
> Mar 11 09:30:52 bremer systemd[1]: Stopped Device-Mapper Multipath Device Controller.
>
> To my taste, this is too much. Of course, not everyone is using
> systemd. Without systemd and with the part of my patch you acked, we'd
> be down from 9 to 3 messages. IMO either the "exit" message or the
> "shut down" message could be hidden at -v2. I suppose we could decrease
> the verbosity level of handle_signals() to -v3 instead. Would you agree
> with that?

Sure.

> > Since people generally run multipathd constantly, they rarely
> > appear more than a couple of times per boot. I would prefer if they
> > could stay.  I'm fine with removing the others.
>
> Ok, fine with me. Do you insist on the "--------", too? It's mainly
> that which bothers me. If you look at the typical boot messages of
> contemporary Linux servers, no other daemon uses this strong emphasis
> for an informational message. The informational value would be higher
> if we printed a detailed version number including HEAD commit ID, like
> other daemons do.

I'm fine with changing what the messages look like, I'd just like
something to stay there.

-Ben

> Martin
>

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


      reply	other threads:[~2022-03-22 15:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 22:33 [dm-devel] [PATCH v2 00/11] multipathd: fix __delayed_reconfig logic mwilck
2022-03-18 22:33 ` [dm-devel] [PATCH v2 01/11] multipathd: child(): remove superfluous if condition mwilck
2022-03-22  0:18   ` Benjamin Marzinski
2022-03-18 22:33 ` [dm-devel] [PATCH v2 02/11] multipathd: set reload_type in when calling reconfigure() mwilck
2022-03-18 22:33 ` [dm-devel] [PATCH v2 03/11] multipathd: avoid busy loop in child() for delayed reconfigure mwilck
2022-03-22  0:19   ` Benjamin Marzinski
2022-03-18 22:33 ` [dm-devel] [PATCH v2 04/11] multipathd: reset __delayed_reconfig from ev_add_map() mwilck
2022-03-22  0:21   ` Benjamin Marzinski
2022-03-18 22:33 ` [dm-devel] [PATCH v2 05/11] multipathd: remove volatile qualifier from running_state mwilck
2022-03-22  0:23   ` Benjamin Marzinski
2022-03-18 22:33 ` [dm-devel] [PATCH v2 06/11] libmultipath: add callback for remove_map() mwilck
2022-03-22  0:28   ` Benjamin Marzinski
2022-03-22  8:35     ` Martin Wilck
2022-03-22 14:59       ` Benjamin Marzinski
2022-03-22 16:37         ` Martin Wilck
2022-03-18 22:33 ` [dm-devel] [PATCH v2 07/11] multipathd: use remove_map_callback for delayed reconfigure mwilck
2022-03-22  0:34   ` Benjamin Marzinski
2022-03-22  9:08     ` Martin Wilck
2022-03-22 15:36       ` Benjamin Marzinski
2022-03-18 22:33 ` [dm-devel] [PATCH v2 08/11] libmultipath: warn only once about deprecated options mwilck
2022-03-22  0:34   ` Benjamin Marzinski
2022-03-18 22:33 ` [dm-devel] [PATCH v2 09/11] multipathd: improve logging of reconfigure() mwilck
2022-03-22  0:35   ` Benjamin Marzinski
2022-03-18 22:33 ` [dm-devel] [PATCH v2 10/11] multipathd: log state changes mwilck
2022-03-22  0:37   ` Benjamin Marzinski
2022-03-18 22:33 ` [dm-devel] [PATCH v2 11/11] multipathd: remove unhelpful startup / shutdown messages mwilck
2022-03-22  0:43   ` Benjamin Marzinski
2022-03-22  9:30     ` Martin Wilck
2022-03-22 15:38       ` Benjamin Marzinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPt1nt7-Rws3LnQttR_GZFCb04+G=F9Qcxkk50E7=CVKtfDU1A@mail.gmail.com' \
    --to=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=guozh88@chinatelecom.cn \
    --cc=mwilck@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.