From: Mark Asselstine <mark.asselstine@windriver.com>
To: "Jonatan Pålsson" <jonatan.palsson@pelagicore.com>
Cc: "meta-virtualization@yoctoproject.org"
<meta-virtualization@yoctoproject.org>
Subject: Re: [PATCH] lxc: Add lua to PACKAGECONFIG
Date: Mon, 27 Mar 2017 11:52:06 -0400 [thread overview]
Message-ID: <CAPuovEKh0pouVU0f_3+d08sp6vsoE+iurLpQ5DH5mMODoUqimw@mail.gmail.com> (raw)
In-Reply-To: <20170327064330.20815-1-jonatan.palsson@pelagicore.com>
On Mon, Mar 27, 2017 at 2:43 AM, Jonatan Pålsson
<jonatan.palsson@pelagicore.com> wrote:
> Lua support is automatically enabled when configuring LXC if lua is
> available in the sysroot. The packaging step will fail since the lua
> related files are not in FILES.
>
> This patch explicitly enables/disables lua support using PACKAGECONFIG,
> and also adds lua-related files to FILES.
>
> Signed-off-by: Jonatan Pålsson <jonatan.palsson@pelagicore.com>
> ---
This looks fine. I wasn't sure about the handling of the globbing in
${libdir}/lua/lxc but since -dbg comes first in the PACKAGES list it
is all good. This addresses a bug report we have in meta-overc which I
was just about to look at, thanks for getting this out first and
saving me some time.
Mark
> recipes-containers/lxc/lxc_2.0.0.bb | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/recipes-containers/lxc/lxc_2.0.0.bb b/recipes-containers/lxc/lxc_2.0.0.bb
> index 250ac4d..c98d1a7 100644
> --- a/recipes-containers/lxc/lxc_2.0.0.bb
> +++ b/recipes-containers/lxc/lxc_2.0.0.bb
> @@ -65,6 +65,7 @@ PACKAGECONFIG[templates] = ",,, ${PN}-templates"
> PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux,libselinux,libselinux"
> PACKAGECONFIG[seccomp] ="--enable-seccomp,--disable-seccomp,libseccomp,libseccomp"
> PACKAGECONFIG[python] = "--enable-python,--disable-python,python3,python3-core"
> +PACKAGECONFIG[lua] = "--enable-lua,--disable-lua,lua,lua"
>
> # required by python3 to run setup.py
> export BUILD_SYS
> @@ -86,6 +87,9 @@ FILES_${PN}-doc = "${mandir} ${infodir}"
> # For LXC the docdir only contains example configuration files and should be included in the lxc package
> FILES_${PN} += "${docdir}"
> FILES_${PN} += "${libdir}/python3*"
> +FILES_${PN} += "${datadir}/lua/*"
> +FILES_${PN} += "${libdir}/lua/lxc/*"
> +FILES_${PN}-dbg += "${libdir}/lua/lxc/.debug"
> FILES_${PN}-dbg += "${libexecdir}/lxc/.debug ${libexecdir}/lxc/hooks/.debug"
> PACKAGES =+ "${PN}-templates ${PN}-setup ${PN}-networking"
> FILES_${PN}-templates += "${datadir}/lxc/templates"
> --
> 2.10.2
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
next prev parent reply other threads:[~2017-03-27 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 6:43 [PATCH] lxc: Add lua to PACKAGECONFIG Jonatan Pålsson
2017-03-27 15:52 ` Mark Asselstine [this message]
2017-03-28 13:10 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPuovEKh0pouVU0f_3+d08sp6vsoE+iurLpQ5DH5mMODoUqimw@mail.gmail.com \
--to=mark.asselstine@windriver.com \
--cc=jonatan.palsson@pelagicore.com \
--cc=meta-virtualization@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.