From: Mark Asselstine <mark.asselstine@windriver.com>
To: Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com>
Cc: meta-virtualization <meta-virtualization@yoctoproject.org>
Subject: Re: [PATCH] python-glanceclient: upgrade 2.8.0 -> 2.16.0
Date: Tue, 3 Sep 2019 16:45:30 -0400 [thread overview]
Message-ID: <CAPuovELN1S+uxOTkdaE=-SohXru1fAdcN1hstGhriTHoTNVb6g@mail.gmail.com> (raw)
In-Reply-To: <1567425189-118862-1-git-send-email-zhengrq.fnst@cn.fujitsu.com>
On Mon, Sep 2, 2019 at 7:53 AM Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com> wrote:
>
> Signed-off-by: Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com>
> ---
> .../python/python-glanceclient_git.bb | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb b/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> index 00ea2ab..e828cba 100644
> --- a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> +++ b/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> @@ -3,22 +3,20 @@ HOMEPAGE = "https://github.com/openstack/python-glanceclient"
> SECTION = "devel/python"
> LICENSE = "Apache-2.0"
> LIC_FILES_CHKSUM = "file://LICENSE;md5=34400b68072d710fecd0a2940a0d1658"
> +SRC_URI = "git://github.com/openstack/python-glanceclient.git \
> + file://glance-api-check.sh \
> + "
> +
> +PV = "2.16.0+git${SRCPV}"
> +SRCREV = "44a4dbd6ce2642daeaca9f45ac99e2d1b39e805a"
> +S = "${WORKDIR}/git"
> +
> DEPENDS += " \
> gmp \
> python-pip \
> python-pbr \
> "
>
> -SRCREV = "13b25ff1fed908cfe7b4e719a97efd7121e3be96"
> -PV = "2.8.0+git${SRCPV}"
> -
> -SRC_URI = "\
> - git://github.com/openstack/${BPN}.git;branch=stable/pike \
> - file://glance-api-check.sh \
> - "
> -
> -S = "${WORKDIR}/git"
What's with the extra churn here? Was the moving around of lines
deliberate, if so it needs to be covered in the long log. If not you
should avoid this as it is similar to mixing real changes and non-real
changes, it only serves to make the review more difficult.
MarkA
> -
> inherit setuptools monitor rmargparse
>
> FILES_${PN} += "${datadir}/${SRCNAME}"
> --
> 2.17.1
>
>
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
next prev parent reply other threads:[~2019-09-03 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 11:53 [PATCH] python-glanceclient: upgrade 2.8.0 -> 2.16.0 Zheng Ruoqin
2019-09-03 20:45 ` Mark Asselstine [this message]
2019-09-03 23:52 ` Zheng, Ruoqin
2019-09-05 12:56 ` Mark Asselstine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPuovELN1S+uxOTkdaE=-SohXru1fAdcN1hstGhriTHoTNVb6g@mail.gmail.com' \
--to=mark.asselstine@windriver.com \
--cc=meta-virtualization@yoctoproject.org \
--cc=zhengrq.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.