From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin Wojtas Subject: Re: [EXT] Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes Date: Wed, 23 Aug 2017 23:05:33 +0200 Message-ID: References: <20170724134848.19330-1-antoine.tenart@free-electrons.com> <20170724134848.19330-11-antoine.tenart@free-electrons.com> <20170726162648.GK12049@lunn.ch> <20170823082510.GD5202@kwain> <5ebd192c54984b25adda0a294035b1b9@IL-EXCH01.marvell.com> <20170823160444.GC23960@kwain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Stefan Chulski , Andrew Lunn , "davem@davemloft.net" , "jason@lakedaemon.net" , "gregory.clement@free-electrons.com" , "sebastian.hesselbarth@gmail.com" , "thomas.petazzoni@free-electrons.com" , Nadav Haklai , "linux@armlinux.org.uk" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" To: Antoine Tenart Return-path: Received: from mail-io0-f182.google.com ([209.85.223.182]:33235 "EHLO mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbdHWVFf (ORCPT ); Wed, 23 Aug 2017 17:05:35 -0400 Received: by mail-io0-f182.google.com with SMTP id o196so4744068ioe.0 for ; Wed, 23 Aug 2017 14:05:34 -0700 (PDT) In-Reply-To: <20170823160444.GC23960@kwain> Sender: netdev-owner@vger.kernel.org List-ID: Hi Antoine, 2017-08-23 18:04 GMT+02:00 Antoine Tenart : > On Wed, Aug 23, 2017 at 03:24:55PM +0000, Stefan Chulski wrote: >> > When the cable is connected (there is signal) and the serdes is in sync and AN >> > succeeded. >> > >> > > With SFF/SFP ports, you generally need a gpio line the fibre module >> > > can use to indicate if it has link. Fixed-phy has such support, and >> > > your link_change function will get called when the link changes. >> > >> > So that would work when using SFP modules but I wonder if the GoP irq isn't >> > needed when using passive cable, in which case this patch would still be needed >> > (and of course we should support the new Russell phylib capabilities). >> >> Even if new phylib driver supports passive direct cables connection, >> GoP IRQ required for SOHO/Peridot external switch support. >> SOHO/Peridot external switch could be connected directly to Serdes line. > > So I guess the GoP link irq patches are needed. Should I resend them > then? > > We'll have to discuss how to handle fixed-phy vs GoP IRQ, but I guess we > can do this when adding the fixed-phy support later. > Please check mvneta.c - you can find there coexistence of normal libphy support, fixed phy and link irq for the inband management mode. IMO it's exactly, what you need here. Best regards, Marcin From mboxrd@z Thu Jan 1 00:00:00 1970 From: mw@semihalf.com (Marcin Wojtas) Date: Wed, 23 Aug 2017 23:05:33 +0200 Subject: [EXT] Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes In-Reply-To: <20170823160444.GC23960@kwain> References: <20170724134848.19330-1-antoine.tenart@free-electrons.com> <20170724134848.19330-11-antoine.tenart@free-electrons.com> <20170726162648.GK12049@lunn.ch> <20170823082510.GD5202@kwain> <5ebd192c54984b25adda0a294035b1b9@IL-EXCH01.marvell.com> <20170823160444.GC23960@kwain> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Antoine, 2017-08-23 18:04 GMT+02:00 Antoine Tenart : > On Wed, Aug 23, 2017 at 03:24:55PM +0000, Stefan Chulski wrote: >> > When the cable is connected (there is signal) and the serdes is in sync and AN >> > succeeded. >> > >> > > With SFF/SFP ports, you generally need a gpio line the fibre module >> > > can use to indicate if it has link. Fixed-phy has such support, and >> > > your link_change function will get called when the link changes. >> > >> > So that would work when using SFP modules but I wonder if the GoP irq isn't >> > needed when using passive cable, in which case this patch would still be needed >> > (and of course we should support the new Russell phylib capabilities). >> >> Even if new phylib driver supports passive direct cables connection, >> GoP IRQ required for SOHO/Peridot external switch support. >> SOHO/Peridot external switch could be connected directly to Serdes line. > > So I guess the GoP link irq patches are needed. Should I resend them > then? > > We'll have to discuss how to handle fixed-phy vs GoP IRQ, but I guess we > can do this when adding the fixed-phy support later. > Please check mvneta.c - you can find there coexistence of normal libphy support, fixed phy and link irq for the inband management mode. IMO it's exactly, what you need here. Best regards, Marcin