From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 599E0C433E0 for ; Thu, 11 Feb 2021 19:27:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1751764E42 for ; Thu, 11 Feb 2021 19:27:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230147AbhBKT1U (ORCPT ); Thu, 11 Feb 2021 14:27:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbhBKT1E (ORCPT ); Thu, 11 Feb 2021 14:27:04 -0500 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43A04C0613D6 for ; Thu, 11 Feb 2021 11:26:24 -0800 (PST) Received: by mail-qt1-x831.google.com with SMTP id e11so5002262qtg.6 for ; Thu, 11 Feb 2021 11:26:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=SPfnsSxHjOU0EO90H+0z4pIXdOqXdbqu3ojr4t/JMSA=; b=KJXpTn4FoVCntABO/wHHn91KO2J+Q+z3ozOL0wPxCTOjdE3VwScClNNzKmgw9b1O9K SsKKc4aBwTmqZLu1Z0dtK1uLD2pUi4vpQP7RLAl6yOTn5IzB9u0vlnzySrLNd/9yYHLR RM0PjSKru9EVccJRkScy6P7b0LV2YqV0qZxIGHf31cZ7CkdpU/aq6+VC4Z97kHMkq43s Gs6lvKKqdTofYDWogH66RAcLlQ1JmAsuMcnF49XkAmJd21Gf5Bd6Lmx9sd0Z3ihstj8F X/l8J91WVLv7vNhA/TO+iWkqahCakyNOxhYuGbTYUClGFoAoilFB4pDZ25PdfEld9P3j lvAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=SPfnsSxHjOU0EO90H+0z4pIXdOqXdbqu3ojr4t/JMSA=; b=sei5EvkUeuSYodYb4RZR6fs//jqvaO3B6Dnl5Bf9OsaQx3lkuw4qowWP3qBX5F2Yp5 5QKg435IxNh9ZbpG7v15HF1P/GeVkblv1vv3fu2cmrydjohgjxKBRr/1q3ofLY7QtxZv QtdU/SPzZRXl0i0IkPkMiYOf1kxbyptHxWUc4OWZd7nlOiPdV6gdM7DzLH6q5qJmuSz+ RkSHmdZd1/xoEhuEjDGn+IVLVSDQiauws515ehbFnO/wKuwKIdHuONsIKeHvH7M5wr8U YUcJq9qTLm3DUY74AfrmriP7Nz7vOtXypbw+5yC27I29klqC78aG+GgYIJyC3LrJPthh XZ1g== X-Gm-Message-State: AOAM533DuTF5WxuMNl8ne/SSm37pJ+t7Lux6dSPyYUuQyY+HoVqKy4kW xP7/EJw/9e01fEIXhoq+CdgMKppCblDJTVYQXy5bHA== X-Google-Smtp-Source: ABdhPJzi/HMDdzkfbFoD2hx2WTj4HKVz46WWQqa5il0MFIDdf2QKAcCtgCWR5EItM/AR8RN/HDig5gtCFoxpUlC7q5A= X-Received: by 2002:ac8:a82:: with SMTP id d2mr8771145qti.343.1613071583329; Thu, 11 Feb 2021 11:26:23 -0800 (PST) MIME-Version: 1.0 References: <1613040542-16500-1-git-send-email-stefanc@marvell.com> <1613040542-16500-6-git-send-email-stefanc@marvell.com> <20210211114238.GD1463@shell.armlinux.org.uk> In-Reply-To: From: Marcin Wojtas Date: Thu, 11 Feb 2021 20:26:10 +0100 Message-ID: Subject: Re: [EXT] Re: [PATCH v13 net-next 05/15] net: mvpp2: add PPv23 version definition To: Stefan Chulski Cc: Russell King - ARM Linux admin , "netdev@vger.kernel.org" , "thomas.petazzoni@bootlin.com" , "davem@davemloft.net" , Nadav Haklai , Yan Markman , "linux-kernel@vger.kernel.org" , "kuba@kernel.org" , "andrew@lunn.ch" , "atenart@kernel.org" , "devicetree@vger.kernel.org" , "robh+dt@kernel.org" , "sebastian.hesselbarth@gmail.com" , "gregory.clement@bootlin.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org czw., 11 lut 2021 o 12:49 Stefan Chulski napisa=C5=82= (a): > > > ---------------------------------------------------------------------- > > On Thu, Feb 11, 2021 at 12:48:52PM +0200, stefanc@marvell.com wrote: > > > From: Stefan Chulski > > > > > > This patch add PPv23 version definition. > > > PPv23 is new packet processor in CP115. > > > Everything that supported by PPv22, also supported by PPv23. > > > No functional changes in this stage. > > > > > > Signed-off-by: Stefan Chulski > > > Acked-by: Marcin Wojtas > > > > Reviewed-by: Russell King > > > > > @@ -7049,6 +7049,11 @@ static int mvpp2_probe(struct platform_device > > *pdev) > > > priv->port_map |=3D BIT(i); > > > } > > > > > > + if (priv->hw_version !=3D MVPP21) { > > > + if (mvpp2_read(priv, MVPP2_VER_ID_REG) =3D=3D > > MVPP2_VER_PP23) > > > + priv->hw_version =3D MVPP23; > > > + } > > > + > > > > The only minor comment I have on this is... the formatting of the above= . > > Wouldn't: > > > > if (priv->hw_version >=3D MVPP22 && > > mvpp2_read(priv, MVPP2_VER_ID_REG) =3D=3D MVPP2_VER_PP23) > > priv->hw_version =3D MVPP23; > > > > read better? > > > > Do we need to even check priv->hw_version here? Isn't this register > > implemented in PPv2.1 where it contains the value zero? > > Yes, we can just: > if (mvpp2_read(priv, MVPP2_VER_ID_REG) =3D=3D MVPP2_VER_PP23) > priv->hw_version =3D MVPP23; > > I checked the A375 specs and cannot see this particular register. Can you please double check whether this register is in the old version of the IP and the Functional Spec is incomplete? Thanks, Marcin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00F88C433E0 for ; Thu, 11 Feb 2021 19:27:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A02A164E42 for ; Thu, 11 Feb 2021 19:27:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A02A164E42 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=semihalf.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fjYlQcV3EDSRd+MFY7fhtQnMMb0AdIcC7uTcusUR9YA=; b=cvTkj6b79MT8S161PcNYrNRmj 9CUKSUnoJPKb26OdIwCkOyyajtq4d49YhF539g8n4ewA4WI4AkIRG4pXNzt5k5VazdSHBkTUPI0ac h2eZqbUahAQZ2Bztot0kdVcRQJpXoaotaNp8r5xLWYgiNB+Yy2qsD492HmkQHTcgNDZfgP0FSFsEh y4zVSllS1mn+0CrzF5LiKZVmZlQNy1jPFOYgPkPB/WYxuVurEDshMdAsMc3A9oPGp/Jtt52640vdq DzfziPSk8yDfmDu5fuwGIYTwXrMYxpnFOt1L7T6cdhokmjmGY6IXItgOHmgwa/HimKeygwIUSEsM5 HsqZ+w8tg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAHbf-0000vL-W4; Thu, 11 Feb 2021 19:26:28 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAHbd-0000uU-FH for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 19:26:26 +0000 Received: by mail-qt1-x835.google.com with SMTP id e15so4994227qte.9 for ; Thu, 11 Feb 2021 11:26:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=SPfnsSxHjOU0EO90H+0z4pIXdOqXdbqu3ojr4t/JMSA=; b=KJXpTn4FoVCntABO/wHHn91KO2J+Q+z3ozOL0wPxCTOjdE3VwScClNNzKmgw9b1O9K SsKKc4aBwTmqZLu1Z0dtK1uLD2pUi4vpQP7RLAl6yOTn5IzB9u0vlnzySrLNd/9yYHLR RM0PjSKru9EVccJRkScy6P7b0LV2YqV0qZxIGHf31cZ7CkdpU/aq6+VC4Z97kHMkq43s Gs6lvKKqdTofYDWogH66RAcLlQ1JmAsuMcnF49XkAmJd21Gf5Bd6Lmx9sd0Z3ihstj8F X/l8J91WVLv7vNhA/TO+iWkqahCakyNOxhYuGbTYUClGFoAoilFB4pDZ25PdfEld9P3j lvAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=SPfnsSxHjOU0EO90H+0z4pIXdOqXdbqu3ojr4t/JMSA=; b=VgnrFLESBVkv/3N4Khv4dfjO+SALEz4i/XWNU5IX8Kd6Bbz0H0oiSv5HSDwiEcs8ya 8f00/ZCOciY6B2FXstOb7XUtewB+2CiA7Vd5J5tAoeM7H/LRpZqBS0lTrMXRMOBGD41V ELFA1gGjkCodWTpxVhJMbCLWxfXK8Z70ZA2ncPcny0Rz2Nh5gHj3Htasg/UCa32cnMbh 32vzzi0lIuB1WUtzbFtlcpe+ZCw8Q6SOG+7RkOOoIX2urLPTuvoVkOWSUeLWgrF9UjgF arroSxMViUW9bX4uEu7/8DM0+HUK2hbauQSfISrZ7ksJebC6PD6FNT/V+7Wpid8WJuc9 q1xg== X-Gm-Message-State: AOAM531s24GMYQM4kRHhDG6hf3IJ7GvggjUSEd6uq7FVfuJnuFQQLU+E +67gvbM4DRPBKJgIJDs38E7A2Ik9QtvCRp28zup4yg== X-Google-Smtp-Source: ABdhPJzi/HMDdzkfbFoD2hx2WTj4HKVz46WWQqa5il0MFIDdf2QKAcCtgCWR5EItM/AR8RN/HDig5gtCFoxpUlC7q5A= X-Received: by 2002:ac8:a82:: with SMTP id d2mr8771145qti.343.1613071583329; Thu, 11 Feb 2021 11:26:23 -0800 (PST) MIME-Version: 1.0 References: <1613040542-16500-1-git-send-email-stefanc@marvell.com> <1613040542-16500-6-git-send-email-stefanc@marvell.com> <20210211114238.GD1463@shell.armlinux.org.uk> In-Reply-To: From: Marcin Wojtas Date: Thu, 11 Feb 2021 20:26:10 +0100 Message-ID: Subject: Re: [EXT] Re: [PATCH v13 net-next 05/15] net: mvpp2: add PPv23 version definition To: Stefan Chulski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_142625_540593_2EEF9DD3 X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "andrew@lunn.ch" , Yan Markman , "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , "atenart@kernel.org" , Russell King - ARM Linux admin , "linux-kernel@vger.kernel.org" , Nadav Haklai , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "thomas.petazzoni@bootlin.com" , "kuba@kernel.org" , "davem@davemloft.net" , "gregory.clement@bootlin.com" , "sebastian.hesselbarth@gmail.com" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Y3p3LiwgMTEgbHV0IDIwMjEgbyAxMjo0OSBTdGVmYW4gQ2h1bHNraSA8c3RlZmFuY0BtYXJ2ZWxs LmNvbT4gbmFwaXNhxYIoYSk6Cj4KPiA+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+IE9uIFRodSwgRmViIDEx LCAyMDIxIGF0IDEyOjQ4OjUyUE0gKzAyMDAsIHN0ZWZhbmNAbWFydmVsbC5jb20gd3JvdGU6Cj4g PiA+IEZyb206IFN0ZWZhbiBDaHVsc2tpIDxzdGVmYW5jQG1hcnZlbGwuY29tPgo+ID4gPgo+ID4g PiBUaGlzIHBhdGNoIGFkZCBQUHYyMyB2ZXJzaW9uIGRlZmluaXRpb24uCj4gPiA+IFBQdjIzIGlz IG5ldyBwYWNrZXQgcHJvY2Vzc29yIGluIENQMTE1Lgo+ID4gPiBFdmVyeXRoaW5nIHRoYXQgc3Vw cG9ydGVkIGJ5IFBQdjIyLCBhbHNvIHN1cHBvcnRlZCBieSBQUHYyMy4KPiA+ID4gTm8gZnVuY3Rp b25hbCBjaGFuZ2VzIGluIHRoaXMgc3RhZ2UuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFN0 ZWZhbiBDaHVsc2tpIDxzdGVmYW5jQG1hcnZlbGwuY29tPgo+ID4gPiBBY2tlZC1ieTogTWFyY2lu IFdvanRhcyA8bXdAc2VtaWhhbGYuY29tPgo+ID4KPiA+IFJldmlld2VkLWJ5OiBSdXNzZWxsIEtp bmcgPHJtaytrZXJuZWxAYXJtbGludXgub3JnLnVrPgo+ID4KPiA+ID4gQEAgLTcwNDksNiArNzA0 OSwxMSBAQCBzdGF0aWMgaW50IG12cHAyX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UKPiA+ ICpwZGV2KQo+ID4gPiAgICAgICAgICAgICAgICAgICAgIHByaXYtPnBvcnRfbWFwIHw9IEJJVChp KTsKPiA+ID4gICAgIH0KPiA+ID4KPiA+ID4gKyAgIGlmIChwcml2LT5od192ZXJzaW9uICE9IE1W UFAyMSkgewo+ID4gPiArICAgICAgICAgICBpZiAobXZwcDJfcmVhZChwcml2LCBNVlBQMl9WRVJf SURfUkVHKSA9PQo+ID4gTVZQUDJfVkVSX1BQMjMpCj4gPiA+ICsgICAgICAgICAgICAgICAgICAg cHJpdi0+aHdfdmVyc2lvbiA9IE1WUFAyMzsKPiA+ID4gKyAgIH0KPiA+ID4gKwo+ID4KPiA+IFRo ZSBvbmx5IG1pbm9yIGNvbW1lbnQgSSBoYXZlIG9uIHRoaXMgaXMuLi4gdGhlIGZvcm1hdHRpbmcg b2YgdGhlIGFib3ZlLgo+ID4gV291bGRuJ3Q6Cj4gPgo+ID4gICAgICAgaWYgKHByaXYtPmh3X3Zl cnNpb24gPj0gTVZQUDIyICYmCj4gPiAgICAgICAgICAgbXZwcDJfcmVhZChwcml2LCBNVlBQMl9W RVJfSURfUkVHKSA9PSBNVlBQMl9WRVJfUFAyMykKPiA+ICAgICAgICAgICAgICAgcHJpdi0+aHdf dmVyc2lvbiA9IE1WUFAyMzsKPiA+Cj4gPiByZWFkIGJldHRlcj8KPiA+Cj4gPiBEbyB3ZSBuZWVk IHRvIGV2ZW4gY2hlY2sgcHJpdi0+aHdfdmVyc2lvbiBoZXJlPyBJc24ndCB0aGlzIHJlZ2lzdGVy Cj4gPiBpbXBsZW1lbnRlZCBpbiBQUHYyLjEgd2hlcmUgaXQgY29udGFpbnMgdGhlIHZhbHVlIHpl cm8/Cj4KPiBZZXMsIHdlIGNhbiBqdXN0Ogo+ICAgICAgICAgaWYgKG12cHAyX3JlYWQocHJpdiwg TVZQUDJfVkVSX0lEX1JFRykgPT0gTVZQUDJfVkVSX1BQMjMpCj4gICAgICAgICAgICAgICAgIHBy aXYtPmh3X3ZlcnNpb24gPSBNVlBQMjM7Cj4KPgoKSSBjaGVja2VkIHRoZSBBMzc1IHNwZWNzIGFu ZCBjYW5ub3Qgc2VlIHRoaXMgcGFydGljdWxhciByZWdpc3Rlci4gQ2FuCnlvdSBwbGVhc2UgZG91 YmxlIGNoZWNrIHdoZXRoZXIgdGhpcyByZWdpc3RlciBpcyBpbiB0aGUgb2xkIHZlcnNpb24gb2YK dGhlIElQIGFuZCB0aGUgRnVuY3Rpb25hbCBTcGVjIGlzIGluY29tcGxldGU/CgpUaGFua3MsCk1h cmNpbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=