From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0265C433E0 for ; Fri, 5 Feb 2021 09:54:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6559864E49 for ; Fri, 5 Feb 2021 09:54:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbhBEJx5 (ORCPT ); Fri, 5 Feb 2021 04:53:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229669AbhBEJqc (ORCPT ); Fri, 5 Feb 2021 04:46:32 -0500 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05930C06178B for ; Fri, 5 Feb 2021 01:45:45 -0800 (PST) Received: by mail-qk1-x72f.google.com with SMTP id k193so6252183qke.6 for ; Fri, 05 Feb 2021 01:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0FlvauPxI82lJp8jNkOhgq79rt6yfGv1K5PxDtLBQRg=; b=SJjIEqN+fAXUPvWNb4TqBr1kFjSDVRi9dpOpTeX8ViKkCaRS4TeNiraJModQFugQwc bD3tizzNKKTCZcLWTuXiQrzdt1SefwVfayL98KiXujC1Q8YEidcbHDMRrZgdw2vTzBKG j0uN4QiPMLMaKUuhvbDZKUNE9ny7GjV5AWsQ1GZR5mmuUDAs/RXQa9Zvg7oR4Go2tL5s mLqQlnJTjkhgtOqhTbUZN6G+FTQTwafcaGcEHFEqXrj3289UXbsmSWkAMAOw1umnCfoW 7k9R2VvnDVb2fvnWBdoAL+RypoPIl+0bbQYU6UVZVv4wH/M63KM3l64GVmOCM0ixlEGf lU5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0FlvauPxI82lJp8jNkOhgq79rt6yfGv1K5PxDtLBQRg=; b=KI73ZwYeOblOVZ01M2aEQcOl8m9LA3wEE21UtevWK+wrZ0iizMUnYcQUPTpzRrnY8k Jlx/ZB2Jtm4ZoJMCHjPhQ4lJWIB2A/7jrwB7mM1q7CaeIS4wLSP+zJXy2/w5LzqMRDdd o/nhA2HJkagDHsiKjOwFG0vWM04NdK9F0RSqZHPZZ/Dc3c1x6OXfnI1rYJETvjN6nbIJ 95tn5irE0lioXYYTmSf3Q6R0EjyvLWJW5gTVl7L3+ZSbWYQh8Re+T5ljT8Lb/B6TAKrt UXEnI96aQ5xKdFH2ECChY8mIaP+hD+YHAS8hAhXdic7stRu4Vk0knH+Nd7fOXqqGnLTQ eYpg== X-Gm-Message-State: AOAM5307ucMfite3cJI/cF7qUYyPR3Ph9ZfeefnhTomKAZkXEkVo62sn t65LBeggMO5YMtqza6DgXhavf9nsAMH0wd4tHHzo9g== X-Google-Smtp-Source: ABdhPJxxmATRZtKOwg48ZhqL0MPxHUwiOYl7cBEJUhrGUaD7tMXIx/qXPPY2uuFsJAamMyhJf8dbADxPcXTfTfRciG8= X-Received: by 2002:a05:620a:f96:: with SMTP id b22mr3257258qkn.295.1612518344222; Fri, 05 Feb 2021 01:45:44 -0800 (PST) MIME-Version: 1.0 References: <20210203133138.10754-1-kostap@marvell.com> <20210203133138.10754-10-kostap@marvell.com> In-Reply-To: <20210203133138.10754-10-kostap@marvell.com> From: Marcin Wojtas Date: Fri, 5 Feb 2021 10:45:32 +0100 Message-ID: Subject: Re: [PATCH 09/11] dts: a3700: enable dma coherence for PCIE interface To: Kostya Porotchkin Cc: Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King - ARM Linux , Rob Herring , Sebastian Hesselbarth , =?UTF-8?Q?Gr=C3=A9gory_Clement?= , Andrew Lunn , Grzegorz Jaszczyk , nadavh@marvell.com, Stefan Chulski , =?UTF-8?B?QmVuIFBlbGVkICjXkdefINek15zXkyk=?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kosta, =C5=9Br., 3 lut 2021 o 14:32 napisa=C5=82(a): > > From: Stefan Chulski > > Enavble PCIe dma coherence for A3700 platform > While at it, can we also add: --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi @@ -71,6 +71,7 @@ soc { compatible =3D "simple-bus"; #address-cells =3D <2>; #size-cells =3D <2>; + dma-coherent; ranges; internal-regs@d0000000 { so that to enable it for all bus-attached interfaces? This safe and will boost IO performance. Thanks, Marcin > Signed-off-by: Stefan Chulski > Signed-off-by: Konstantin Porotchkin > --- > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/bo= ot/dts/marvell/armada-37xx.dtsi > index d5b6c0a1c54a..5c0df06bc707 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -486,6 +486,7 @@ > #interrupt-cells =3D <1>; > msi-parent =3D <&pcie0>; > msi-controller; > + dma-coherent; > ranges =3D <0x82000000 0 0xe8000000 0 0xe800000= 0 0 0x1000000 /* Port 0 MEM */ > 0x81000000 0 0xe9000000 0 0xe9000000 = 0 0x10000>; /* Port 0 IO*/ > interrupt-map-mask =3D <0 0 0 7>; > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA89C433E9 for ; Fri, 5 Feb 2021 09:46:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E019764FB8 for ; Fri, 5 Feb 2021 09:46:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E019764FB8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=semihalf.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L5CxZsAp7yO6M1mXvitOjTpfBj/Ma9G280FIbevgNc4=; b=qMfL/YrKvD/Yt9bLPnM0rrPaH ONY/wTCMyVGvo38Pl44nLT74xO/TPdagzKelL1AXik1U49eqFOMX99AGB/mt7yd7FgC1LNhqXVWRE ZWoHomh79zM5G7PE66DsUjHC/F5N0DiLWx1jJt1TpYEUrgZgRkjIIJPSikP8ts4CHak5p9thCY0e5 TT6iu9leNH0QrNHc90hs/sPiykszxdWF97RdMIpc7tyQN4dMCxyVKxxrj/PBPIKZHX719YUg8Ykux 8xm+MlZoYwbLoQwSX7hYjfHONngzAvFp0S3RA4OWhLRFFt78ecVqqzsoTzOrY2clZ2pC+/NoTh3+7 zUGCut3OQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7xgT-0004PN-95; Fri, 05 Feb 2021 09:45:49 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7xgR-0004Nu-0d for linux-arm-kernel@lists.infradead.org; Fri, 05 Feb 2021 09:45:47 +0000 Received: by mail-qk1-x72f.google.com with SMTP id l27so6233425qki.9 for ; Fri, 05 Feb 2021 01:45:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0FlvauPxI82lJp8jNkOhgq79rt6yfGv1K5PxDtLBQRg=; b=SJjIEqN+fAXUPvWNb4TqBr1kFjSDVRi9dpOpTeX8ViKkCaRS4TeNiraJModQFugQwc bD3tizzNKKTCZcLWTuXiQrzdt1SefwVfayL98KiXujC1Q8YEidcbHDMRrZgdw2vTzBKG j0uN4QiPMLMaKUuhvbDZKUNE9ny7GjV5AWsQ1GZR5mmuUDAs/RXQa9Zvg7oR4Go2tL5s mLqQlnJTjkhgtOqhTbUZN6G+FTQTwafcaGcEHFEqXrj3289UXbsmSWkAMAOw1umnCfoW 7k9R2VvnDVb2fvnWBdoAL+RypoPIl+0bbQYU6UVZVv4wH/M63KM3l64GVmOCM0ixlEGf lU5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0FlvauPxI82lJp8jNkOhgq79rt6yfGv1K5PxDtLBQRg=; b=BYj794Likbfe1NNVmhVZjVZYwrYi76NuvvS5s5bEwifR+VJjYRzoGGSXFzZqIecEb5 0Rha0sgzfuO81nU2zPqV1kOqUKOJVMv6GV2RQwa9kVsQUYXitY2wB1WfAB9B/0ZL64AQ K/LfaBRVGkzXl16OUc7tMKvk3XkTnYDJKrPDSESoxPSyx7E/At6hOutGFYDX2VOGhj16 2TcOAW0opzoUGPlq2sPQlNl5kcEUIS1aN3MJxwsBYp2yezPkFYrrCfZD1YM6yGU5y+Tg QLRAxHS6Xa+xGY/VXnxRbDYztgeVrz2NE96rPw8N7/EQtBqiFqtyq/FOfCwkQ4KVBNlp bDQw== X-Gm-Message-State: AOAM530wleqdQRrkBbDCPpbY8M/OZU3yiDEPr+CWSBSA75iMPw1jzfNM MCbU6CTEEio7UP9aPWh5LkcuRlQGYJiFzpYbwVWfXA== X-Google-Smtp-Source: ABdhPJxxmATRZtKOwg48ZhqL0MPxHUwiOYl7cBEJUhrGUaD7tMXIx/qXPPY2uuFsJAamMyhJf8dbADxPcXTfTfRciG8= X-Received: by 2002:a05:620a:f96:: with SMTP id b22mr3257258qkn.295.1612518344222; Fri, 05 Feb 2021 01:45:44 -0800 (PST) MIME-Version: 1.0 References: <20210203133138.10754-1-kostap@marvell.com> <20210203133138.10754-10-kostap@marvell.com> In-Reply-To: <20210203133138.10754-10-kostap@marvell.com> From: Marcin Wojtas Date: Fri, 5 Feb 2021 10:45:32 +0100 Message-ID: Subject: Re: [PATCH 09/11] dts: a3700: enable dma coherence for PCIE interface To: Kostya Porotchkin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210205_044547_136378_910CAA07 X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Andrew Lunn , Grzegorz Jaszczyk , =?UTF-8?Q?Gr=C3=A9gory_Clement?= , Linux Kernel Mailing List , Russell King - ARM Linux , nadavh@marvell.com, Rob Herring , Stefan Chulski , =?UTF-8?B?QmVuIFBlbGVkICjXkdefINek15zXkyk=?= , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS29zdGEsCgrFm3IuLCAzIGx1dCAyMDIxIG8gMTQ6MzIgPGtvc3RhcEBtYXJ2ZWxsLmNvbT4g bmFwaXNhxYIoYSk6Cj4KPiBGcm9tOiBTdGVmYW4gQ2h1bHNraSA8c3RlZmFuY0BtYXJ2ZWxsLmNv bT4KPgo+IEVuYXZibGUgUENJZSBkbWEgY29oZXJlbmNlIGZvciBBMzcwMCBwbGF0Zm9ybQo+CgpX aGlsZSBhdCBpdCwgY2FuIHdlIGFsc28gYWRkOgoKLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9t YXJ2ZWxsL2FybWFkYS0zN3h4LmR0c2kKKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxs L2FybWFkYS0zN3h4LmR0c2kKQEAgLTcxLDYgKzcxLDcgQEAgc29jIHsKICAgICAgICAgICAgICAg IGNvbXBhdGlibGUgPSAic2ltcGxlLWJ1cyI7CiAgICAgICAgICAgICAgICAjYWRkcmVzcy1jZWxs cyA9IDwyPjsKICAgICAgICAgICAgICAgICNzaXplLWNlbGxzID0gPDI+OworICAgICAgICAgICAg ICAgZG1hLWNvaGVyZW50OwogICAgICAgICAgICAgICAgcmFuZ2VzOwoKICAgICAgICAgICAgICAg IGludGVybmFsLXJlZ3NAZDAwMDAwMDAgewoKc28gdGhhdCB0byBlbmFibGUgaXQgZm9yIGFsbCBi dXMtYXR0YWNoZWQgaW50ZXJmYWNlcz8gVGhpcyBzYWZlIGFuZAp3aWxsIGJvb3N0IElPIHBlcmZv cm1hbmNlLgoKVGhhbmtzLApNYXJjaW4KCj4gU2lnbmVkLW9mZi1ieTogU3RlZmFuIENodWxza2kg PHN0ZWZhbmNAbWFydmVsbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogS29uc3RhbnRpbiBQb3JvdGNo a2luIDxrb3N0YXBAbWFydmVsbC5jb20+Cj4gLS0tCj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvbWFy dmVsbC9hcm1hZGEtMzd4eC5kdHNpIHwgMSArCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKQo+Cj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEt Mzd4eC5kdHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zN3h4LmR0c2kK PiBpbmRleCBkNWI2YzBhMWM1NGEuLjVjMGRmMDZiYzcwNyAxMDA2NDQKPiAtLS0gYS9hcmNoL2Fy bTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3eHguZHRzaQo+ICsrKyBiL2FyY2gvYXJtNjQv Ym9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzd4eC5kdHNpCj4gQEAgLTQ4Niw2ICs0ODYsNyBAQAo+ ICAgICAgICAgICAgICAgICAgICAgICAgICNpbnRlcnJ1cHQtY2VsbHMgPSA8MT47Cj4gICAgICAg ICAgICAgICAgICAgICAgICAgbXNpLXBhcmVudCA9IDwmcGNpZTA+Owo+ICAgICAgICAgICAgICAg ICAgICAgICAgIG1zaS1jb250cm9sbGVyOwo+ICsgICAgICAgICAgICAgICAgICAgICAgIGRtYS1j b2hlcmVudDsKPiAgICAgICAgICAgICAgICAgICAgICAgICByYW5nZXMgPSA8MHg4MjAwMDAwMCAw IDB4ZTgwMDAwMDAgICAwIDB4ZTgwMDAwMDAgMCAweDEwMDAwMDAgLyogUG9ydCAwIE1FTSAqLwo+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAweDgxMDAwMDAwIDAgMHhlOTAwMDAw MCAgIDAgMHhlOTAwMDAwMCAwIDB4MTAwMDA+OyAvKiBQb3J0IDAgSU8qLwo+ICAgICAgICAgICAg ICAgICAgICAgICAgIGludGVycnVwdC1tYXAtbWFzayA9IDwwIDAgMCA3PjsKPiAtLQo+IDIuMTcu MQo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==