From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D38D5C04A68 for ; Thu, 28 Jul 2022 16:57:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231959AbiG1Q5E (ORCPT ); Thu, 28 Jul 2022 12:57:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229747AbiG1Q5D (ORCPT ); Thu, 28 Jul 2022 12:57:03 -0400 Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F6D75721B for ; Thu, 28 Jul 2022 09:56:59 -0700 (PDT) Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-10e634ecfe6so3014290fac.8 for ; Thu, 28 Jul 2022 09:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+neT7drnhUVN6IEwt5cqIrCpyz1zNkYGzrU5Sn+25po=; b=N/sgs+QuFpuUwFiUZBjJm6IQrlOlMhIiDya+kN2jqxag5eodzaya5QHHvG90yHGR6J ilM6y/ORThHfyVxS8edWpoQPrqBRXQiG9Wo7TpM26TPXMMvOZWJFi4ILQ1s/nARzg30c Jz9kIepJRc+HYrdrE5UP2EoKTLpt++h1/3cnDxUP7bFAR+uGKhL2Cb4OQdr2JkMAR1xf yaN/x3fcTzhubwXLDbPNia9IbwL/tUfDyMNVSoYLqEjY9NvkcrtSTP4CJbHyx1luCNbk 5aW0yJzTpZ5Q1duc0tw4HOY+tlAl9w1M1fcmapGLnqz6FyOj+iSeG7NOC/mY1Y9kvowb izaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+neT7drnhUVN6IEwt5cqIrCpyz1zNkYGzrU5Sn+25po=; b=Hm2Wry+burvwjMxz7iEv2NuRt2BOy1T2gFiVe0Id/fJgYyoBbLjd6jciLaR7F3J358 cpZpMU7cqJP3wu3jXe4AI3qMRNoZz37NfEdmrsNk4v+Nl+BihqAWJTiWyNfOykNhhnd1 csFJ5VW28ngkGxy7vic8+CK4nnSbU4KX2G6dLJtACg5NOYh7BC+QHTnoeHJBWadydDvS GOlP0hCrd2ZDIwfvHp7uI+J8kmmUWdyEIdXEDsPcLap4zYpEWsBcqunO2WvkBpY6v4/L B3Y4hzKlHSqZCUy5Md9c3fbsuOAE0HH6V3lXNk8k/jwaSXwYT7zCX0RfVUd4OXgafs4K SYLQ== X-Gm-Message-State: AJIora+IQtWavUmsXPeH6UkAjxGMNmckOx4p0bK8PyGDAKy1gK1BunA/ tYZksRMt/M/PlussMB9tZ0nJOn3ZnvfpiTr297pY7w== X-Google-Smtp-Source: AGRyM1s2wYwcYRLI1t8oGbHlSkYF7nki9R79iqP4GkO+sJM610lF9/jDXBRf6KuYUgt99I2pgHY/3R8xIXBCqcBgUmo= X-Received: by 2002:a05:6870:4186:b0:101:17ef:d966 with SMTP id y6-20020a056870418600b0010117efd966mr173601oac.97.1659027418891; Thu, 28 Jul 2022 09:56:58 -0700 (PDT) MIME-Version: 1.0 References: <20220727064321.2953971-1-mw@semihalf.com> <20220727064321.2953971-7-mw@semihalf.com> <20220727143147.u6yd6wqslilspyhw@skbuf> <20220727163848.f4e2b263zz3vl2hc@skbuf> <20220728091643.m6c5d36pseenrw6l@skbuf> In-Reply-To: <20220728091643.m6c5d36pseenrw6l@skbuf> From: Marcin Wojtas Date: Thu, 28 Jul 2022 18:56:48 +0200 Message-ID: Subject: Re: [net-next: PATCH v3 6/8] net: core: switch to fwnode_find_net_device_by_node() To: Vladimir Oltean Cc: Andy Shevchenko , Linux Kernel Mailing List , ACPI Devel Maling List , netdev , "Rafael J. Wysocki" , Andy Shevchenko , Sean Wang , Landen Chao , Linus Walleij , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King - ARM Linux , Heiner Kallweit , Grzegorz Bernacki , Grzegorz Jaszczyk , Tomasz Nowicki , Samer El-Haj-Mahmoud , "upstream@semihalf.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org czw., 28 lip 2022 o 11:16 Vladimir Oltean napisa=C5=82(= a): > > On Thu, Jul 28, 2022 at 08:52:04AM +0200, Marcin Wojtas wrote: > > Yes, indeed. After recent update, I think we can assume the current > > implementation of fwnode_find_parent_dev_match should work fine with > > all existing cases. > > What you should really be fixing is the commit message of patch 4, > that's what threw me off: > > | As a preparation to switch the DSA subsystem from using > | of_find_net_device_by_node() to its more generic fwnode_ > | equivalent, the port's device structure should be updated > | with its fwnode pointer, similarly to of_node - see analogous > | commit c4053ef32208 ("net: mvpp2: initialize port of_node pointer"). > | > | This patch is required to prevent a regression before updating > | the DSA API on boards that connect the mvpp2 port to switch, > | such as Clearfog GT-8K or CN913x CEx7 Evaluation Board. > > There's no regression to speak of. DSA didn't work with ACPI before, and > fwnode_find_net_device_by_node() still works with the plain dev->of_node > assignment. There was a regression even for OF in v1, but after switching to device_match_fwnode() it works indeed. Anyway patch v4 is imo useful, I'll only reword the commit message. Thanks, Marcin