From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED42EC19F2B for ; Thu, 28 Jul 2022 19:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232029AbiG1TuM (ORCPT ); Thu, 28 Jul 2022 15:50:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231590AbiG1TuL (ORCPT ); Thu, 28 Jul 2022 15:50:11 -0400 Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0910E1147 for ; Thu, 28 Jul 2022 12:50:09 -0700 (PDT) Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-10dc1b16c12so3585066fac.6 for ; Thu, 28 Jul 2022 12:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=spQC5DgL3oN87S+iC1PglEQ45W/HemORZipZMoLzdbo=; b=Z3pjI6O9fsHjdX0fd0JMIbiPAuKOZ/jbEfl+8fap+JTqPS44WCC2h0P3V5kbBPb8+x arHLTqP0WBbd1ANzqmqVf3CJdfq4Eu3ef4vNfoui4p1Udt5gPsH7EG0SqQOaR3IhuH8N D3/Xkt0ez0WrkBj88iC2DELqeI5DtwtnnjysXHyjGzp17v1YBh3wthJ3nNjclGdJYO1P Rr3s7wCu9ShcLlg/vhVslWrAbQltfKGVxZZe7rTTele1mdU0JwPiLZ4+1kn7b1VLu1uc lu/QZxTE8JLiSmEFJHk/7HPfs3bC86fobhGfCdZvzOfJXVmhd69YkZPhH/detcDK9qZz tHGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=spQC5DgL3oN87S+iC1PglEQ45W/HemORZipZMoLzdbo=; b=d9jHG2acVOwytkq6hteI7oAuU+uCPVguTPnDK5rLcFAY0UtSPiMJWD9QrMizZI9cbe MjvMXHRllwiLGlCn6+8Sv6tLnPDSaoUgyFho8tZU6r6nFQd8FkIfIFv9af1hUpkWk2yE BHH1WlL/MWowilZydN435N8joGmBpxBbhKhF1ODqNnjqHjAOKU/XszIYAflypFZjlioZ 5SsxioVk0Mp39y6cUATcRsZGIw94yQ1bx+pstmDZaxvxTsuEfXITpshEHIzrw9yEUWv4 uoYqQdFepNMwlz6X4ovYFRC4DyLyX1eVYeUjEcYk89W007gYRllR32LDeM2NxYnGeuMG 3D5Q== X-Gm-Message-State: AJIora8ASRsKPfka1QYxPwVjKUYXyXD8pqq5S2FVpq4LrMSDc79+vO2p Xd+9LeAdaUX4Noc9DeyMVfcVRnAubAxtdQ3pKoa1Yg== X-Google-Smtp-Source: AGRyM1vSA2JOkaQqBtH9qzmnpbRJvsTC0Bp3SA27Hwqk66QdtarAJd6bAmkwBF0NfeyH35IKczAxtPrwNVBfqOoDbk8= X-Received: by 2002:a05:6870:a182:b0:10b:efbe:e65d with SMTP id a2-20020a056870a18200b0010befbee65dmr519829oaf.5.1659037807922; Thu, 28 Jul 2022 12:50:07 -0700 (PDT) MIME-Version: 1.0 References: <20220727064321.2953971-1-mw@semihalf.com> <20220727064321.2953971-7-mw@semihalf.com> <20220727143147.u6yd6wqslilspyhw@skbuf> <20220727163848.f4e2b263zz3vl2hc@skbuf> <20220728091643.m6c5d36pseenrw6l@skbuf> <20220728191630.wjmm4mfbhrvbolqq@skbuf> In-Reply-To: <20220728191630.wjmm4mfbhrvbolqq@skbuf> From: Marcin Wojtas Date: Thu, 28 Jul 2022 21:49:58 +0200 Message-ID: Subject: Re: [net-next: PATCH v3 6/8] net: core: switch to fwnode_find_net_device_by_node() To: Vladimir Oltean Cc: Andy Shevchenko , Linux Kernel Mailing List , ACPI Devel Maling List , netdev , "Rafael J. Wysocki" , Andy Shevchenko , Sean Wang , Landen Chao , Linus Walleij , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King - ARM Linux , Heiner Kallweit , Grzegorz Bernacki , Grzegorz Jaszczyk , Tomasz Nowicki , Samer El-Haj-Mahmoud , "upstream@semihalf.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org czw., 28 lip 2022 o 21:16 Vladimir Oltean napisa=C5=82(= a): > > On Thu, Jul 28, 2022 at 06:56:48PM +0200, Marcin Wojtas wrote: > > There was a regression even for OF in v1, but after switching to > > device_match_fwnode() it works indeed. Anyway patch v4 is imo useful, > > I'll only reword the commit message. > > Do you mean patch 4 or patch v4? If patch 4, of course it's useful, but Patch 4/8 in v4 :) I'm working on it right now to submit asap. > not for avoiding a regression with OF (case in which I drop all my claims > made earlier about fw_find_net_device_by_node), but rather to actually Change in the mvpp2 driver: - dev->dev.of_node =3D port_node; + device_set_node(&dev->dev, port_fwnode); is desired and correct anyway, so as a low-cost change I think it can be included in this series (which is in fact preparation-to-ACPI support). I will update the commit message. accordingly. > get something working with actual ACPI (although perhaps not in this > series, you'll need to add ACPI IDs in the mv88e6xxx driver some time v1 added all of this, but we agreed that ACPI-specific bits should be sent separately later, after extending the ACPI Specification. > later as well, maybe you could focus this series just on converting DSA > to play nice with fwnodes). If you're already thinking about the v4 of > this patch set, I'll respond to that in a separate email shortly.