From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A96D4C49EA6 for ; Thu, 24 Jun 2021 18:15:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8778A60FEB for ; Thu, 24 Jun 2021 18:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232604AbhFXSRf (ORCPT ); Thu, 24 Jun 2021 14:17:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbhFXSRd (ORCPT ); Thu, 24 Jun 2021 14:17:33 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3940C061756 for ; Thu, 24 Jun 2021 11:15:13 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id 19so5999839qky.13 for ; Thu, 24 Jun 2021 11:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=JzJBuslwkLHPNqksgBWPDVE4rBUHra0e4TjPjK87Jaw=; b=TvpxSU8R52dcR8I5BCAd4YsHAgys7Fq+7+bVYG+Mxc0+juKmNgHmf2yD0cfvo5jlx8 86PFP1VAU0EUC8vCNNKB3R31d8oeVcxlVB1+jJxqIxrfSNkGjBz/rKHeUs8G9G7bpFH8 oY6cHWgIDxv7+N9TJAkWCBa86Z4qp3DiwXLTZHvISUiUUndQ89JHvMKxPU9iRtDvJPFS pCgEWu73WJ5gfPUzKSICCEpYM5FENmx+/AFhy9gWcCzwCozwnnnmuufj1wWrQtyLnfeB o4YF3IjJqOs5IahnAq4lwjBYx79vGTNXfLeuMGCaqO27AM9hxslmU4UJog/EQVThkU+D FR/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JzJBuslwkLHPNqksgBWPDVE4rBUHra0e4TjPjK87Jaw=; b=EO7LFc9fvZddypRZKRavLinv1g/mW+LtWWoQZKyhRgSSQMSlsNBo6jVThawXQ5DLWc MD/S6D1fnVz/xuuu1NFJojaP5dSaGA9J6ItFi9Nl4/++J3c1oU0ypSqCFx5VmOXqS2+G FWDeOTraL2Ghx0HMYw0BwAxV5FlgWgfic3edYBh9NKgiXE+4VdEM4/EbLrXqfD782le9 rfmQr6DR75kUy6kfIiUYg3AK4SrZ0Gl0el8NAZWeRk6IBVVazbFkzxQ1Id0BwQ5njkEb z6+OnQejpd/qbfq/e2Y8rN4SyymwUbw7RdDELDv7w90VOiN+vDdZf67EVxd+dV4Z16tS FdDg== X-Gm-Message-State: AOAM530uv8kVBLVYkzphwHNrDjEgDQWHdKYveKblLyiDUL//bSutmVxE ThjJF65RjN7a4Rj9JzDU0VQ1rfkbwC4WuS4GKrjwmRENLTPoVg== X-Google-Smtp-Source: ABdhPJyPU3hpHd0oPNGuZHqtn+F2AjfqYyMNiVUhdShXNjjwWen/DvCI34a6HtIOXfMHSt4K7IKLbtNjyrWPUqaeSPU= X-Received: by 2002:a05:620a:2230:: with SMTP id n16mr7036857qkh.155.1624558512954; Thu, 24 Jun 2021 11:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20210624082911.5d013e8c@canb.auug.org.au> <20210624185430.692d4b60@canb.auug.org.au> <3d6ea68a-9654-6def-9533-56640ceae69f@kernel.org> In-Reply-To: <3d6ea68a-9654-6def-9533-56640ceae69f@kernel.org> From: Marcin Wojtas Date: Thu, 24 Jun 2021 20:15:00 +0200 Message-ID: Subject: Re: linux-next: build failure after merge of the net-next tree To: David Miller , Jakub Kicinski Cc: Stephen Rothwell , Naresh Kamboju , Networking , Linux Kernel Mailing List , Linux Next Mailing List , lkft-triage@lists.linaro.org, Nathan Chancellor Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David & Jakub, czw., 24 cze 2021 o 18:40 Nathan Chancellor napisa=C5= =82(a): > > Hi Marcin, > > On 6/24/2021 7:25 AM, Marcin Wojtas wrote: > > Hi Stephen, > > > > czw., 24 cze 2021 o 10:54 Stephen Rothwell napis= a=C5=82(a): > >> > >> Hi all, > >> > >> On Thu, 24 Jun 2021 11:43:14 +0530 Naresh Kamboju wrote: > >>> > >>> On Thu, 24 Jun 2021 at 07:59, Nathan Chancellor w= rote: > >>>> > >>>> On Thu, Jun 24, 2021 at 12:46:48AM +0200, Marcin Wojtas wrote: > >>>>> Hi Stephen, > >>>>> > >>>>> czw., 24 cze 2021 o 00:29 Stephen Rothwell n= apisa=C5=82(a): > >>>>>> > >>>>>> Hi all, > >>>>>> > >>>>>> Today's linux-next build (x86_64 modules_install) failed like this= : > >>>>>> > >>>>>> depmod: ../tools/depmod.c:1792: depmod_report_cycles_from_root: As= sertion `is < stack_size' failed. > >>> > >>> LKFT test farm found this build error. > >>> > >>> Regressions found on mips: > >>> > >>> - build/gcc-9-malta_defconfig > >>> - build/gcc-10-malta_defconfig > >>> - build/gcc-8-malta_defconfig > >>> > >>> depmod: ERROR: Cycle detected: fwnode_mdio -> of_mdio -> fwnode_mdio > >>> depmod: ERROR: Found 2 modules in dependency cycles! > >>> make[1]: *** [/builds/linux/Makefile:1875: modules_install] Error 1 > >>> > >>>>> Thank you for letting us know. Not sure if related, but I just foun= d > >>>>> out that this code won't compile for the !CONFIG_FWNODE_MDIO. Below > >>>>> one-liner fixes it: > >>>>> > >>>>> --- a/include/linux/fwnode_mdio.h > >>>>> +++ b/include/linux/fwnode_mdio.h > >>>>> @@ -40,7 +40,7 @@ static inline int fwnode_mdiobus_register(struct = mii_bus *bus, > >>>>> * This way, we don't have to keep compat bits around in d= rivers. > >>>>> */ > >>>>> > >>>>> - return mdiobus_register(mdio); > >>>>> + return mdiobus_register(bus); > >>>>> } > >>>>> #endif > >>>>> > >>>>> I'm curious if this is the case. Tomorrow I'll resubmit with above,= so > >>>>> I'd appreciate recheck. > >>> > >>> This proposed fix did not work. > >>> > >>>> Reverting all the patches in that series fixes the issue for me. > >>> > >>> Yes. > >>> Reverting all the (6) patches in that series fixed this build problem= . > >>> > >>> git log --oneline | head > >>> 3752a7bfe73e Revert "Documentation: ACPI: DSD: describe additional MA= C > >>> configuration" > >>> da53528ed548 Revert "net: mdiobus: Introduce fwnode_mdbiobus_register= ()" > >>> 479b72ae8b68 Revert "net/fsl: switch to fwnode_mdiobus_register" > >>> 92f85677aff4 Revert "net: mvmdio: add ACPI support" > >>> 3d725ff0f271 Revert "net: mvpp2: enable using phylink with ACPI" > >>> ffa8c267d44e Revert "net: mvpp2: remove unused 'has_phy' field" > >>> d61c8b66c840 Add linux-next specific files for 20210623 > >> > >> So I have reverted the merge of that topic branch from linux-next for > >> today. > > > > Just to understand correctly - you reverted merge from the local > > branch (I still see the commits on Dave M's net-next/master). I see a > > quick solution, but I'm wondering how I should proceed. Submit a > > correction patch to the mailing lists against the net-next? Or the > > branch is going to be reverted and I should resubmit everything as v4? > > As far as I am aware, net and net-next are not rebased so you would need > to submit a fixup patch against the current net-next with a proper > Fixes: tag. > TL;DR, we need to get rid of a helper routine (introduced so that to address review comments of v1), as it causes a depmod cycles when fwnode_/of_/acpi_mdio are built as modules. It can be done twofold: a. 3 commits, i.e: Revert "net: mdiobus: Introduce fwnode_mdbiobus_register()" Revert "net/fsl: switch to fwnode_mdiobus_register" net: mvmdio: resign from fwnode_mdiobus_register b. Same diff but squashed. Please let me know your preference, so that I can do it properly up front. Thanks, Marcin