From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F176C04A68 for ; Wed, 27 Jul 2022 18:45:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239023AbiG0SpF (ORCPT ); Wed, 27 Jul 2022 14:45:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230309AbiG0Soy (ORCPT ); Wed, 27 Jul 2022 14:44:54 -0400 Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99C2D9BA0C for ; Wed, 27 Jul 2022 10:41:23 -0700 (PDT) Received: by mail-oo1-xc34.google.com with SMTP id n8-20020a4ad628000000b00435bf6e372dso3326931oon.13 for ; Wed, 27 Jul 2022 10:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VXHqyZDYmIQ3rpqxptc15nYDRULliBEgKqonht7y21s=; b=KfA5hlXNMKatVFo7kjZB6fHQZh0bPOashrO56ytvMrdaUFnESzhb+pcJ+HV9wGgvTx kqumxc/h9xexjEi+9nIHmPtpScepB1PhfpoECzSoYSpAq10qe+ymLX1uW2pAK2UOvYEm FZrnEPUti3VwIjw5wkUf5iyeDr4pgPc56E5GeR3S363LfneRFu7x+tV5vJgSZ3f0FZhR 1eYYuIZpj2AwNqV/pDnzFK6pMtXYr21A/4/f90mzGYGzCJYF1OQa3omqkt0qlMyYJM78 hRmi6DMT/mfbpm1/hTgSJOIk9Y2FJAfWN9RFUR3WNyxsBd4pDQLjqW7OXqcT2DRmNIN/ 9h2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VXHqyZDYmIQ3rpqxptc15nYDRULliBEgKqonht7y21s=; b=5VWpbGBoLmhyG7zKnAsR1dINDND61Ap5GLs4I8/n1Hr7px+iRk2CX9xJ++0KsIOxlk BCH//Rp9PaReKBBmMC0u4r+0TF7TK0ckQubOziYh2rIbUW82jHKu9SmP2AtmlklXKlNp mjiUB6bKTrnpAuyS2QzEBUEQPX42Z1O9aaroQmj03RM2scqCXy2m7tdZ3IjyDI/s6eEO Pudmiv77VmF+SGJq/ymwo3AnsbkwgbxkSzm3mpyt5gYLNC/vJEcSLXrVG7f4suJhonbr F/LFam1peZGZg0KAetJSnPMPJogWAg0OYimdmetOpH4uYjZJpFPPswsoBkZhEamBgHAV cBCg== X-Gm-Message-State: AJIora/HOfGBPbiSC4Veb91dkOSy/VtU7U+95YGWIMN8tcsxYxkKtSLE Oh4WKXHXItxMei59gyVtvbXvRG9LrZNuNYIrbkQwig== X-Google-Smtp-Source: AGRyM1uObxFbk/OdalJ5bp779OxgIf3N8kPgC9BFL6XJs+LvsaPS3cBTKwyifuXYvvSAj9WSxRlU6+FIFIz5WVAJV4s= X-Received: by 2002:a4a:6550:0:b0:435:f3e8:8d3e with SMTP id z16-20020a4a6550000000b00435f3e88d3emr3987894oog.13.1658943682324; Wed, 27 Jul 2022 10:41:22 -0700 (PDT) MIME-Version: 1.0 References: <20220727064321.2953971-1-mw@semihalf.com> <20220727064321.2953971-7-mw@semihalf.com> <20220727143147.u6yd6wqslilspyhw@skbuf> In-Reply-To: From: Marcin Wojtas Date: Wed, 27 Jul 2022 19:41:10 +0200 Message-ID: Subject: Re: [net-next: PATCH v3 6/8] net: core: switch to fwnode_find_net_device_by_node() To: Andy Shevchenko Cc: Vladimir Oltean , Linux Kernel Mailing List , ACPI Devel Maling List , netdev , "Rafael J. Wysocki" , Andy Shevchenko , Sean Wang , Landen Chao , Linus Walleij , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King - ARM Linux , Heiner Kallweit , Grzegorz Bernacki , Grzegorz Jaszczyk , Tomasz Nowicki , Samer El-Haj-Mahmoud , upstream@semihalf.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org =C5=9Br., 27 lip 2022 o 19:00 Andy Shevchenko n= apisa=C5=82(a): > > On Wed, Jul 27, 2022 at 5:24 PM Marcin Wojtas wrote: > > =C5=9Br., 27 lip 2022 o 16:31 Vladimir Oltean napis= a=C5=82(a): > > > On Wed, Jul 27, 2022 at 08:43:19AM +0200, Marcin Wojtas wrote: > > ... > > > > > + dev =3D class_find_device(&net_class, NULL, fwnode, fwnode_fi= nd_parent_dev_match); > > > > > > This needs to maintain compatibility with DSA masters that have > > > dev->of_node but don't have dev->fwnode populated. > > > > Do you mean a situation analogous to what I addressed in: > > [net-next: PATCH v3 4/8] net: mvpp2: initialize port fwnode pointer > > ? > > > > I found indeed a couple of drivers that may require a similar change > > (e.g. dpaa2). > > > > IMO we have 2 options: > > - update these drivers > > Not Vladimir here, but my 2cents that update is best and elegant, it > can be done even before this series. > In general I agree it's desired, but I'm not sure if we can catch all cases just by reading code or rather base on regression reports later... Best regards, Marcin