From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F1ADC433EF for ; Tue, 21 Jun 2022 09:56:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242020AbiFUJ4T (ORCPT ); Tue, 21 Jun 2022 05:56:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbiFUJ4S (ORCPT ); Tue, 21 Jun 2022 05:56:18 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C91E027CE8 for ; Tue, 21 Jun 2022 02:56:17 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id a13so11581210lfr.10 for ; Tue, 21 Jun 2022 02:56:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+UauFON3Z5k4erj1lJhxb4xMRY3aeE01J2NPDi4cPiE=; b=FmNU07MSwd8ek+qnq+c1HaZujdUoSsVhCvencgloomp2smg94X2O7E9yd1MfePj7u1 s5eggE5sF6BUJKWK7G36SCnzKPgFjxv08NzUItZHIP9TmA0mMp183VisI9k/pD20WQCS nUnAKfO7vdTkq5EvAMGv1ez7HMsiXmAkXdwtsGGlDLS9YdHD98i3/hnYGzA+UbQqoRzZ 4t9A5NTPuV35XFoY2Jop+vrvQpXJmJjX+DT0UB01jSp3c7E/eTdqYVsdGpc9zmH34/u4 vKbktlJUCjGUQ3vmLvzNCgiat/Yrn2Qw5G/i0JVmXWMuiNICttCpxgPb53FSwW2HSOBl 7g1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+UauFON3Z5k4erj1lJhxb4xMRY3aeE01J2NPDi4cPiE=; b=TH63DUGL4FeRb/SQE0shJQm2rrJwpDP5FHWF+vxdWWevlOsGsdzEx78DMNT7rUumZx 8dHttsq2U0gVqjV9YgzXSXveTSUagSx3+wnP+ykJ4rwZon1cTrPp1WdsonTcg40RVl7q vJSfEk8SqeBW56StieGNXaJkB0sLRF5wTb7AheaGsUi7oRThfnb8v1Nfcc+y/Ww4nOkb tynaXSW+2Wfl7ON2ukIPB8Qrqkeo2qQmKsl3qYuWATRXp0RbjOUK2kQQ3avfDFLT2FDn QLs8vxQhiJza+8uR2k5VUVl3yrnUgW/XFt+lV2wB32Gheo0siQ1SyE7XHU/a1sQwBOdt 52wA== X-Gm-Message-State: AJIora/jb0KfJWnXD8hrw6TtJLspx11uWrXhK3op4c1aj5hRdk5ZH7yn JcEBvWnHcfGuegGTNgev3+Yy+Ld+qOnDZjc0ovWo2w== X-Google-Smtp-Source: AGRyM1vE6WbXLd9KAOeEIAD5vck9Crd9lsdZBLhmd4rzhe3mbEvRfXLywJ8rOiJRSr8/hHK3nCi5rIQ7bY2hjkHVh70= X-Received: by 2002:a05:6512:118f:b0:47f:6a1a:20d4 with SMTP id g15-20020a056512118f00b0047f6a1a20d4mr7179853lfr.428.1655805376108; Tue, 21 Jun 2022 02:56:16 -0700 (PDT) MIME-Version: 1.0 References: <20220620150225.1307946-1-mw@semihalf.com> <20220620150225.1307946-2-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Tue, 21 Jun 2022 11:56:06 +0200 Message-ID: Subject: Re: [net-next: PATCH 01/12] net: phy: fixed_phy: switch to fwnode_ API To: Andrew Lunn Cc: Linux Kernel Mailing List , ACPI Devel Maling List , netdev , "Rafael J. Wysocki" , Andy Shevchenko , Len Brown , vivien.didelot@gmail.com, Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , pabeni@redhat.com, Russell King - ARM Linux , Heiner Kallweit , Grzegorz Bernacki , Grzegorz Jaszczyk , Tomasz Nowicki , Samer El-Haj-Mahmoud , upstream@semihalf.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org pon., 20 cze 2022 o 19:59 Andrew Lunn napisa=C5=82(a): > > On Mon, Jun 20, 2022 at 05:02:14PM +0200, Marcin Wojtas wrote: > > This patch allows to use fixed_phy driver and its helper > > functions without Device Tree dependency, by swtiching from > > of_ to fwnode_ API. > > Do you actually need this? phylink does not use this code, it has its > own fixed link implementation. And that implementation is not limited > to 1G. > Yes, phylink has its own fixed-link handling, however the net/dsa/port.c relies on fixed_phy helpers these are not 1:1 equivalents. I assumed this migration (fixed_phy -> phylink) is not straightforward and IMO should be handled separately. Do you recall justification for not using phylink in this part of net/dsa/*? Thanks, Marcin