From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 449FFC48BE5 for ; Tue, 15 Jun 2021 15:13:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30AEC61584 for ; Tue, 15 Jun 2021 15:13:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231269AbhFOPPp (ORCPT ); Tue, 15 Jun 2021 11:15:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230079AbhFOPPm (ORCPT ); Tue, 15 Jun 2021 11:15:42 -0400 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 324E9C06175F for ; Tue, 15 Jun 2021 08:13:37 -0700 (PDT) Received: by mail-qt1-x833.google.com with SMTP id r7so3055686qta.12 for ; Tue, 15 Jun 2021 08:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=INX7H6XxUTAVbwgV5PMueO86g/kTATWT2HWC/q8m03E=; b=Lpcg96UfcrHiH3Nyy8ukJUz0gllsoQBs9pKtqzq7AkElQPEGWZLL1crv+MO4vjA7XH y0beMwxf9TL5+eXYJKMHElQAdrzQr7eqyrk2CF8q4xhLCqZYL1OM3vk2hqtkW3hykTZs he8X3IKzOSJY/vIXS8bNwJZa7XngB0QJOffllg/YQsriGHzb3bzH6P/UDGogewn0WxWM jAiJkTKdv0LUwCLw6XRy0Ms9wCEgnh84YMX44UEHRQ8H2QFYMFE7sE8/Oj0w6uOumjYP pZNqYZf3BeZBMPEfzwNg3xQ3KW4YU8UDrAhtPdDEPBgrdFh6TlkhBQRDI7GZlJSZ8mUZ uidA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=INX7H6XxUTAVbwgV5PMueO86g/kTATWT2HWC/q8m03E=; b=USoSt7Amrus84V2Z9AIf9yeML7lU37qw7exh4vbi5TWGtTkRwlvLhGBW3/wTNwGQOM 30lQk3yidL/z99WYB9IsueTnRPIw4tVqBlKXoEHL38d/C0MKAAZymtFpxCBd6ABqrzSC bwmjJu13eLcVfGDYWqPjyUqkw/RLOvSiZiJ5OAW/QSmlvABRV1qJ5377tGUF6sianFED Q/kgvF5YJ5YUfzepIWWan9jI3sm5t1TZMkXhgkfTHOEOBbsAyMIczCfuGxP7YI6+rUp2 hiJwXDRiT8tAIGsNlwwRWvbKF0u95dsht0cXE50tr6VWzQuwAACsGis7RoXq7/jgBFrl nrzA== X-Gm-Message-State: AOAM530vkbAgUOIBMhB04PUcv2lwd/1w/p1duSg+pfIt9Uki6ZvO4ZPs sibzG2hzUkiCaR7w80MRfJyVTrMX7zfXAuldCiT3uQ== X-Google-Smtp-Source: ABdhPJy/hI4Ht9IcKgP9E0y1PkP86xyD/hl/gG/Z/oqdlJ/mXFapXe/6vf2wDgq927qTtpy1Fqw3xgzF4N7t63KV+cc= X-Received: by 2002:ac8:6f11:: with SMTP id g17mr70081qtv.343.1623770016398; Tue, 15 Jun 2021 08:13:36 -0700 (PDT) MIME-Version: 1.0 References: <20210613183520.2247415-1-mw@semihalf.com> <20210613183520.2247415-2-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Tue, 15 Jun 2021 17:13:24 +0200 Message-ID: Subject: Re: [net-next: PATCH 1/3] net: mvmdio: add ACPI support To: Andrew Lunn Cc: Linux Kernel Mailing List , netdev , "David S. Miller" , Jakub Kicinski , Russell King - ARM Linux , Grzegorz Jaszczyk , Grzegorz Bernacki , upstream@semihalf.com, Samer El-Haj-Mahmoud , Jon Nettleton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, niedz., 13 cze 2021 o 21:20 Andrew Lunn napisa=C5=82(a): > > > - ret =3D of_mdiobus_register(bus, pdev->dev.of_node); > > + if (pdev->dev.of_node) > > + ret =3D of_mdiobus_register(bus, pdev->dev.of_node); > > + else if (is_acpi_node(pdev->dev.fwnode)) > > + ret =3D acpi_mdiobus_register(bus, pdev->dev.fwnode); > > + else > > + ret =3D -EINVAL; > > > This seems like something which could be put into fwnode_mdio.c. > Agree - I'll create a simple fwnode_mdiobus_register() helper there. Best regards, Marcin