All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Wojtas <mw@semihalf.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	pabeni@redhat.com, alexander.duyck@gmail.com,
	Stephen Hemminger <stephen@networkplumber.org>,
	j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,
	chris.snook@gmail.com, dchickles@marvell.com, sburla@marvell.com,
	fmanlunas@marvell.com, ajit.khaparde@broadcom.com,
	sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
	qiangqing.zhang@nxp.com, yisen.zhuang@huawei.com,
	salil.mehta@huawei.com, jesse.brandeburg@intel.com,
	anthony.l.nguyen@intel.com,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Russell King - ARM Linux <linux@armlinux.org.uk>,
	Sunil Kovvuri Goutham <sgoutham@marvell.com>,
	gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com,
	simon.horman@corigine.com, Heiner Kallweit <hkallweit1@gmail.com>,
	ecree.xilinx@gmail.com, habetsm.xilinx@gmail.com,
	kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
	woojung.huh@microchip.com, wintera@linux.ibm.com,
	roopa@nvidia.com, razor@blackwall.org, cai.huoqing@linux.dev,
	fei.qin@corigine.com, niklas.soderlund@corigine.com,
	yinjun.zhang@corigine.com, marcinguy@gmail.com,
	jesionowskigreg@gmail.com, jannh@google.com,
	hayeswang@realtek.com
Subject: Re: [PATCH net-next 3/4] net: make drivers set the TSO limit not the GSO limit
Date: Mon, 9 May 2022 16:31:28 +0200	[thread overview]
Message-ID: <CAPv3WKehhJgOFJRiGSsEb3FeOkm3iBSbSO-N39z8+n=7PWtxHA@mail.gmail.com> (raw)
In-Reply-To: <20220506025134.794537-4-kuba@kernel.org>

HI,

[snip]

> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index f6a54c7f0c69..384f5a16753d 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -5617,7 +5617,7 @@ static int mvneta_probe(struct platform_device *pdev)
>         dev->hw_features |= dev->features;
>         dev->vlan_features |= dev->features;
>         dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
> -       netif_set_gso_max_segs(dev, MVNETA_MAX_TSO_SEGS);
> +       netif_set_tso_max_segs(dev, MVNETA_MAX_TSO_SEGS);
>
>         /* MTU range: 68 - 9676 */
>         dev->min_mtu = ETH_MIN_MTU;
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 1a835b48791b..2b7eade373be 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -6861,7 +6861,7 @@ static int mvpp2_port_probe(struct platform_device *pdev,
>                 mvpp2_set_hw_csum(port, port->pool_long->id);
>
>         dev->vlan_features |= features;
> -       netif_set_gso_max_segs(dev, MVPP2_MAX_TSO_SEGS);
> +       netif_set_tso_max_segs(dev, MVPP2_MAX_TSO_SEGS);
>         dev->priv_flags |= IFF_UNICAST_FLT;
>

For mvpp2:
Reviewed-by: Marcin Wojtas <mw@semihalf.com>

Thanks,
Marcin

[snip]

  parent reply	other threads:[~2022-05-09 14:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06  2:51 [PATCH net-next 0/4] net: disambiguate the TSO and GSO limits Jakub Kicinski
2022-05-06  2:51 ` [PATCH net-next 1/4] net: add netif_inherit_tso_max() Jakub Kicinski
2022-05-06 11:27   ` Simon Horman
2022-05-06  2:51 ` [PATCH net-next 2/4] net: don't allow user space to lift the device limits Jakub Kicinski
2022-05-06  2:51 ` [PATCH net-next 3/4] net: make drivers set the TSO limit not the GSO limit Jakub Kicinski
2022-05-06 11:30   ` Simon Horman
2022-05-09 14:31   ` Marcin Wojtas [this message]
2022-05-06  2:51 ` [PATCH net-next 4/4] net: move netif_set_gso_max helpers Jakub Kicinski
2022-05-06  2:58 ` [PATCH net-next 0/4] net: disambiguate the TSO and GSO limits Eric Dumazet
2022-05-06 11:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPv3WKehhJgOFJRiGSsEb3FeOkm3iBSbSO-N39z8+n=7PWtxHA@mail.gmail.com' \
    --to=mw@semihalf.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=alexander.duyck@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=anthony.l.nguyen@intel.com \
    --cc=cai.huoqing@linux.dev \
    --cc=chris.snook@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dchickles@marvell.com \
    --cc=decui@microsoft.com \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=fei.qin@corigine.com \
    --cc=fmanlunas@marvell.com \
    --cc=gakula@marvell.com \
    --cc=habetsm.xilinx@gmail.com \
    --cc=haiyangz@microsoft.com \
    --cc=hayeswang@realtek.com \
    --cc=hkallweit1@gmail.com \
    --cc=hkelam@marvell.com \
    --cc=j.vosburgh@gmail.com \
    --cc=jannh@google.com \
    --cc=jesionowskigreg@gmail.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux@armlinux.org.uk \
    --cc=marcinguy@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=niklas.soderlund@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=qiangqing.zhang@nxp.com \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    --cc=salil.mehta@huawei.com \
    --cc=sbhatta@marvell.com \
    --cc=sburla@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=sgoutham@marvell.com \
    --cc=simon.horman@corigine.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=sriharsha.basavapatna@broadcom.com \
    --cc=stephen@networkplumber.org \
    --cc=sthemmin@microsoft.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vfalico@gmail.com \
    --cc=wei.liu@kernel.org \
    --cc=wintera@linux.ibm.com \
    --cc=woojung.huh@microchip.com \
    --cc=yinjun.zhang@corigine.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.