From: Chris Torek <chris.torek@gmail.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Git List <git@vger.kernel.org>, Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH] t1450: fix quoting of NUL byte when corrupting pack
Date: Sat, 1 Aug 2020 18:00:45 -0700 [thread overview]
Message-ID: <CAPx1GvcZFVfmP8aTdXu_epdSn1EDy_cP6-=hi65c_5DbNEq+FQ@mail.gmail.com> (raw)
In-Reply-To: <20200801220611.10453-1-martin.agren@gmail.com>
On Sat, Aug 1, 2020 at 3:08 PM Martin Ågren <martin.agren@gmail.com> wrote:
> printf '\0'
>
> to generate a NUL byte
[but]
> end up injecting the ASCII code for "0", 0x30, instead.
> - printf '\0' | dd of=.git/objects/pack/pack-$pack.pack bs=1 conv=notrunc seek=12 &&
> + printf "\0" | dd of=.git/objects/pack/pack-$pack.pack bs=1 conv=notrunc seek=12 &&
In sh/bash, this should make no difference, and that's what I get here.
Am I missing something?
$ printf '\0' | hexdump
0000000 0000
0000001
$ printf "\0" | hexdump
0000000 0000
0000001
Chris
next prev parent reply other threads:[~2020-08-02 1:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 22:06 [PATCH] t1450: fix quoting of NUL byte when corrupting pack Martin Ågren
2020-08-02 0:45 ` Junio C Hamano
2020-08-02 14:30 ` Martin Ågren
2020-08-02 17:22 ` Eric Sunshine
2020-08-06 20:08 ` [PATCH v2 0/2] t: don't spuriously close and reopen quotes Martin Ågren
2020-08-06 20:08 ` [PATCH v2 1/2] " Martin Ågren
2020-08-06 20:26 ` Eric Sunshine
2020-08-07 8:45 ` Martin Ågren
2020-08-07 16:17 ` Eric Sunshine
2020-08-07 17:16 ` Junio C Hamano
2020-08-06 20:08 ` [PATCH v2 2/2] t4104: modernize and simplify quoting Martin Ågren
2020-08-02 1:00 ` Chris Torek [this message]
2020-08-02 1:02 ` [PATCH] t1450: fix quoting of NUL byte when corrupting pack Chris Torek
2020-08-02 14:35 ` Martin Ågren
2020-08-02 16:20 ` Chris Torek
2020-08-02 17:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPx1GvcZFVfmP8aTdXu_epdSn1EDy_cP6-=hi65c_5DbNEq+FQ@mail.gmail.com' \
--to=chris.torek@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.