All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Maste <emaste@freebsd.org>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git mailing list <git@vger.kernel.org>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/3] t/lib-httpd: avoid using BSD's sed
Date: Wed, 26 Feb 2020 15:20:44 -0500	[thread overview]
Message-ID: <CAPyFy2ArnEFe33GFLsbcOEV37DZ=VJpF-Sckn-V_tJUrToir=w@mail.gmail.com> (raw)
In-Reply-To: <9900cacbfefb46610114702e6d48d8020f3f2866.1582747775.git.gitgitgadget@gmail.com>

On Wed, 26 Feb 2020 at 15:09, Johannes Schindelin via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Among other differences relative to GNU sed, BSD sed always ends its
> output with a trailing newline, even if the input did not have such a
> trailing newline.
>
> Surprisingly, this makes three httpd-based tests fail on macOS: t5616,
> t5702 and t5703. ("Surprisingly" because those tests have been around
> for some time, but apparently nobody runs them on macOS with a working
> Apache2 setup.)

Hmm, this is interesting - all tests (that are executed) are passing
on FreeBSD, in CI.

I tried on FreeBSD and do not see a trailing newline added; I'm not
sure how sed behaves on other BSDs. However, you probably want to
refer to macOS sed rather than BSD sed in the commit.

  reply	other threads:[~2020-02-26 20:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 20:09 [PATCH 0/3] ci: upgrade to the latest Azure Pipelines agent pools Johannes Schindelin via GitGitGadget
2020-02-26 20:09 ` [PATCH 1/3] t/lib-httpd: avoid using BSD's sed Johannes Schindelin via GitGitGadget
2020-02-26 20:20   ` Ed Maste [this message]
2020-02-27 15:40     ` Johannes Schindelin
2020-02-27 17:39       ` Ed Maste
2020-02-27 19:46         ` Johannes Schindelin
2020-02-28 23:57           ` CI/PR builds on FreeBSD, was " Johannes Schindelin
2020-02-26 20:26   ` Junio C Hamano
2020-02-26 22:22     ` Junio C Hamano
2020-02-27 15:42       ` Johannes Schindelin
2020-02-26 20:09 ` [PATCH 2/3] ci: prevent `perforce` from being quarantined Johannes Schindelin via GitGitGadget
2020-02-26 20:09 ` [PATCH 3/3] Azure Pipeline: switch to the latest agent pools Johannes Schindelin via GitGitGadget
2020-02-27 13:23 ` [PATCH v2 0/3] ci: upgrade to the latest Azure Pipelines " Johannes Schindelin via GitGitGadget
2020-02-27 13:23   ` [PATCH v2 1/3] t/lib-httpd: avoid using macOS' sed Johannes Schindelin via GitGitGadget
2020-02-27 13:23   ` [PATCH v2 2/3] ci: prevent `perforce` from being quarantined Johannes Schindelin via GitGitGadget
2020-02-27 13:23   ` [PATCH v2 3/3] Azure Pipeline: switch to the latest agent pools Johannes Schindelin via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPyFy2ArnEFe33GFLsbcOEV37DZ=VJpF-Sckn-V_tJUrToir=w@mail.gmail.com' \
    --to=emaste@freebsd.org \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.