All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Maste <emaste@freebsd.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: reorder include to fix FreeBSD build failure
Date: Sat, 13 Jul 2013 18:35:36 -0400	[thread overview]
Message-ID: <CAPyFy2BW9+hLC=7+oxnyiA17Lm484VgaQRz8S-RaV_vv92LoHg@mail.gmail.com> (raw)
In-Reply-To: <51E11A1B.2020503@msgid.tls.msk.ru>

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

On 13 July 2013 05:12, Michael Tokarev <mjt@tls.msk.ru> wrote:

> Remaining:
>
> struct mbuf {
>         union M_dat {
>                 char    m_dat_[1]; /* ANSI don't like 0 sized arrays */
>                 char    *m_ext_;
>         } M_dat;
> };
>
> #define m_dat           M_dat.m_dat_
> #define m_ext           M_dat.m_ext_
>
> This can be done by using an unnamed union, ie, by omitting
>

Yeah, struct mbuf and those #defines date back to the beginning of BSD
networking.

I think we're probably unconcerned with a slirp upstream at this point, so
such a change seems reasonable.  I'm not sure that anonymous union support
is universal across all compilers used to build QEMU though - do you know?

[-- Attachment #2: Type: text/html, Size: 1099 bytes --]

  reply	other threads:[~2013-07-13 22:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12 20:29 [Qemu-devel] [PATCH] slirp: reorder include to fix FreeBSD build failure Ed Maste
2013-07-13  9:12 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-07-13 22:35   ` Ed Maste [this message]
2013-07-14 10:14     ` Peter Maydell
2013-07-17  8:32     ` Jan Kiszka
2013-07-17  8:54       ` Michael Tokarev
2013-07-17 14:44         ` Ed Maste

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPyFy2BW9+hLC=7+oxnyiA17Lm484VgaQRz8S-RaV_vv92LoHg@mail.gmail.com' \
    --to=emaste@freebsd.org \
    --cc=jan.kiszka@siemens.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.