From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-media <linux-media@vger.kernel.org>,
jacopo@jmondi.org
Subject: Re: [PATCH v5 2/2] [media] imx214: Add imx214 camera sensor driver
Date: Thu, 4 Oct 2018 12:06:56 +0200 [thread overview]
Message-ID: <CAPybu_2CPQFwuGF9Pbbnqe6KHCZzm_70+Zs2xs3iPsUgQqjECQ@mail.gmail.com> (raw)
In-Reply-To: <20181003221415.jgpeea5ligm7oyr6@kekkonen.localdomain>
Hi Sakari
On Thu, Oct 4, 2018 at 12:14 AM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> On Wed, Oct 03, 2018 at 10:24:17PM +0200, Ricardo Ribalda Delgado wrote:
> ...
> > > > +static int imx214_enum_frame_size(struct v4l2_subdev *subdev,
> > > > + struct v4l2_subdev_pad_config *cfg,
> > > > + struct v4l2_subdev_frame_size_enum *fse)
> > > > +{
> > > > + if (fse->code != IMX214_MBUS_CODE)
> > > > + return -EINVAL;
> > > > +
> > > > + if (fse->index >= ARRAY_SIZE(imx214_modes))
> > >
> > > array_index_nospec() ?? I find it scary that you'd need that in drivers.
> > > :-o
>
> Uh... not needed.
>
> The value is just sent back to the user as such so this is fine AFAICT.
>
> > >
> > > > + return -EINVAL;
> > > > +
> > > > + fse->min_width = fse->max_width = imx214_modes[fse->index].width;
> > > > + fse->min_height = fse->max_height = imx214_modes[fse->index].height;
> > > > +
> > > > + return 0;
> > > > +}
>
> ...
>
> > > > + /*
> > > > + * WARNING!
> > > > + * Values obtained reverse engineering blobs and/or devices.
> > > > + * Ranges and functionality might be wrong.
> > > > + *
> > > > + * Sony, please release some register set documentation for the
> > > > + * device.
> > > > + *
> > > > + * Yours sincerely, Ricardo.
> > > > + */
> > > > + imx214->exposure = v4l2_ctrl_new_std(&imx214->ctrls, &imx214_ctrl_ops,
> > > > + V4L2_CID_EXPOSURE,
> > > > + 0, 0xffff, 1, 0x0c70);
> > >
> > > The exposure is in lines so it can't exceed frame height + blanking.
> > > There's a marginal, too. I don't know what it might be for this sensor
> > > though. Usually it's small, such as 8 or 16. The image will almost
> > > certainly be garbled if you exceed the allowed value.
> > >Seems that this sensor
> >
> > On this sensor what I am experiencing instead of garbage is that the
> > fps gets reduced. So I believe it is fine to
> > set it up this way.
>
> That's rather confusing as well. The user should explicitly need to change
> fps first, rather than it happening as a side effect of a seemingly
> unrelated control.
>
I'd rather maintain this behaviour until we get access to better documentation.
Currently I cannot change the fps on demand, just changing the
exposure time, so I have no proper way of set/get fps
> --
> Regards,
>
> Sakari Ailus
> sakari.ailus@linux.intel.com
--
Ricardo Ribalda
prev parent reply other threads:[~2018-10-04 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 13:09 [PATCH v5 2/2] [media] imx214: Add imx214 camera sensor driver Ricardo Ribalda Delgado
2018-10-03 19:46 ` Sakari Ailus
2018-10-03 20:24 ` Ricardo Ribalda Delgado
2018-10-03 22:14 ` Sakari Ailus
2018-10-04 10:06 ` Ricardo Ribalda Delgado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPybu_2CPQFwuGF9Pbbnqe6KHCZzm_70+Zs2xs3iPsUgQqjECQ@mail.gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.