From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37DFF71 for ; Fri, 30 Apr 2021 08:47:52 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id w3so104121945ejc.4 for ; Fri, 30 Apr 2021 01:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prusa3d-cz.20150623.gappssmtp.com; s=20150623; h=mime-version:content-transfer-encoding:cc:subject:from:to:date :message-id:in-reply-to; bh=ix10HKl4Ji6QvrIhi2BCp+LJFNaL/wGngqRsoRAXrcw=; b=qnXj4HI03B4usnHFixzqm+1A77XNUTnUhCdyrDYv/KkmDCNT7krP3Sji70SjV9YsxN BzSmnnPPltZ6X5GBtHSUBLRGC2ae1ITVpbJznYSh2kT5/9lkl50v1HO+1++ZLeRuqBDd lwW49APmr5oMSYEYMpLZPwqiEXi9GJtJPwRlgdysZTzhBAcJ/gECj3nJpz6RY91pP3Tv j6R2yNajDuns9TNFmJRUZhYjMCTpdBjnGZq/QTDXKy5ZODGw1ZsAMnuVhK2W6zr09p42 nmZbXvDpMdUiHwQwpOSaPlXEvD/vp8B4jbC5Dk592yZ3fk6GqSEuSzKzuKxjZ59at1ms wBPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:cc :subject:from:to:date:message-id:in-reply-to; bh=ix10HKl4Ji6QvrIhi2BCp+LJFNaL/wGngqRsoRAXrcw=; b=jmAj/ePlIWYtM/k10DpwdZIfyEJnSXgGTvTpllJwtWjTY5OaQscUHOacCmBByJaRFE yWkfkSWrpeHoC+4KvvqeWeYYf7WcuXDHIncExNAARH8rvSHd/zLz+PA6Tb/EfV7I6WZr NAWLgw2x4yPSMapBK+SktBso5yheYXy4WG7xYPkX4agcUpcdvnqh4jqf1JJh7EfvG/X/ +9FNtZ9A9UvT/yOMYgOyx1PZymEcWL1StkYJ/TlFLsmuxkvfRoVUlSQwxcME+JiVZM6M HNmDW3FCCNK+6AjZSuI9KkEjRkMcDRHjS2hfKR/gtH46As3HCA8BeDLSRVnqeTV7tH2/ Alow== X-Gm-Message-State: AOAM5329SJbMhJRFPWpYNwZ9Q97xz9xtkPVH3xXVBbnaVXbSHwaHu8KU x+Q2hU381+lyLOjKyI7phGkY8Q== X-Google-Smtp-Source: ABdhPJydNhoRcU4F9++M7+BFSAGysOcXhyO8/MEtoORm2Fzk3Ykujk6hiDy48VdoeeQHgRWdM6RLbA== X-Received: by 2002:a17:906:7257:: with SMTP id n23mr3146650ejk.412.1619772471402; Fri, 30 Apr 2021 01:47:51 -0700 (PDT) Received: from localhost (ip-213-220-236-33.net.upcbroadband.cz. [213.220.236.33]) by smtp.gmail.com with ESMTPSA id s20sm751262edu.93.2021.04.30.01.47.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Apr 2021 01:47:50 -0700 (PDT) X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Cc: "Thierry Reding" , "Lee Jones" , "Maxime Ripard" , "Chen-Yu Tsai" , "Jernej Skrabec" , , , , , "Roman Beranek" Subject: Re: [PATCH] pwm: sun4i: Round delay time up to a nearest jiffy From: "Roman Beranek" To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Date: Fri, 30 Apr 2021 09:17:49 +0200 Message-Id: In-Reply-To: <20210430064145.nzlcw3lpayzapnbx@pengutronix.de> Hello Uwe, On Fri Apr 30, 2021 at 8:41 AM CEST, Uwe Kleine-K=C3=B6nig wrote: > On Fri, Apr 30, 2021 at 04:19:32AM +0200, Roman Ber=C3=A1nek wrote: > > On Thu, Apr 29, 2021 at 2:04 PM Uwe Kleine-K=C3=B6nig wrote: > > > On Wed, Apr 28, 2021 at 02:14:31PM +0200, Roman Ber=C3=A1nek wrote: > > > > Correct, the output may stay in an active state. I only discovered = this > > > > bug as I investigated a report of unreliable screen timeout. The pe= riod > > > > we use the PWM with is 50 us. > > > > > > What I don't like here is that the delay is quite coarse and might st= ill > > > be too short. (Maybe I miss something, but consider the current perio= d > > > is quite long, then you configure a short one and then disable. In th= is > > > case the inital long setting might still be active.) > >=20 > > The delay is calculated from the original period (cstate.period), > > not the one that was just written into PWM_CHx_PRD 2 lines above. > > Yes, but that's not good enough. Consider the PWM is running with a > period of 4s and the period just started. Then you call > > pwm_apply_state(mypwm, &(struct pwm_state){ > .period =3D 20, > .enabled =3D 1, > ... > }) > > This doesn't result into the waiting code being run, because > .enabled =3D 1. Then immidiately after that call: > > pwm_apply_state(mypwm, &(struct pwm_state){ > .period =3D 20, > .enabled =3D 0, > ... > }) > > which triggers the waiting but only based on a period of 20 ns while the > 4s period is still active. OK, now I see what you mean. To remedy this, the delay shall occur regardless of state->enabled. In my view, this lies beneath the scope of the patch though and would be better served as a follow-up. Cheers, Roman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F1CAC433ED for ; Fri, 30 Apr 2021 08:49:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3EF16140C for ; Fri, 30 Apr 2021 08:49:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3EF16140C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=prusa3d.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:Message-Id:Date:To:From:Subject:Cc: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=L8IZRyXVa9PRzYo4mFuDh0gm6hh6tQzaW0IwOV2Y00M=; b=K5f7iK4rnCLgUCd32k+5JzFBV PHzKNLud4J2GjlWRhFNFulPdwascAP+WnYTEGPBg8UbXz5Fc9n+H83+MH4oOYgw6EoYc0GkaJvvcC JpttVUCEQm69rLryIcB4AVRZ9VIs4FLK6AXk9oa4QK9ubt9EiZNYu9EefZTllqZGtzcoT32sJlQl6 FqlIqt8rwicX+uO+CZW2vZ28vrzruNNMZPyid7hXC5JDHzx7CF/CWyY6ReTWFgWd/r++4PGvShv3R /NVKA5/a0N8QqTz5nUKSrBu+DxqjIXtqX3mCUXOfp3ypQN0yFzDhOwAcdNagCVAEdcFVGWPJmwjm8 eiOJyPL0w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lcOoa-007XGA-4b; Fri, 30 Apr 2021 08:48:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcOoY-007XFq-8e for linux-arm-kernel@desiato.infradead.org; Fri, 30 Apr 2021 08:47:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Message-Id:Date:To:From: Subject:Cc:Content-Type:Content-Transfer-Encoding:Mime-Version:Sender: Reply-To:Content-ID:Content-Description:References; bh=ix10HKl4Ji6QvrIhi2BCp+LJFNaL/wGngqRsoRAXrcw=; b=Ol6DrP94vyKzviEdPLs8S7vdQp wzHMNCzDusehKsfet/+DjfW7SLf0XLozbhKsgWodnX+8O+rrqbfF0+3ejRbSJKnO4pwsjM4o37Szu kg62LxZbbnvIEcK2wn6QoSu1uivvGQAlOsQuDepwzvMN3qa170BvTrecY7zbwwYNH4kKhWOANYqkv eA0bHno8b0uq/WmeVLz9nBeTJ5l7K1YbmpeKjKFLRNAE1zGtT7srtKepdOpH96heQB/2ofhM9KWVb eZQx4zjzSGOmQLOHErRKmcL1odAl5NrBXdGbCSutwxiygwm+dtE/1jimjR0ldSXY1NtJ54DZIy5oX 7/QGm4jA==; Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcOoT-001FkG-LQ for linux-arm-kernel@lists.infradead.org; Fri, 30 Apr 2021 08:47:56 +0000 Received: by mail-ej1-x62b.google.com with SMTP id gx5so11999343ejb.11 for ; Fri, 30 Apr 2021 01:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prusa3d-cz.20150623.gappssmtp.com; s=20150623; h=mime-version:content-transfer-encoding:cc:subject:from:to:date :message-id:in-reply-to; bh=ix10HKl4Ji6QvrIhi2BCp+LJFNaL/wGngqRsoRAXrcw=; b=qnXj4HI03B4usnHFixzqm+1A77XNUTnUhCdyrDYv/KkmDCNT7krP3Sji70SjV9YsxN BzSmnnPPltZ6X5GBtHSUBLRGC2ae1ITVpbJznYSh2kT5/9lkl50v1HO+1++ZLeRuqBDd lwW49APmr5oMSYEYMpLZPwqiEXi9GJtJPwRlgdysZTzhBAcJ/gECj3nJpz6RY91pP3Tv j6R2yNajDuns9TNFmJRUZhYjMCTpdBjnGZq/QTDXKy5ZODGw1ZsAMnuVhK2W6zr09p42 nmZbXvDpMdUiHwQwpOSaPlXEvD/vp8B4jbC5Dk592yZ3fk6GqSEuSzKzuKxjZ59at1ms wBPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:cc :subject:from:to:date:message-id:in-reply-to; bh=ix10HKl4Ji6QvrIhi2BCp+LJFNaL/wGngqRsoRAXrcw=; b=r78yf5oF0zCt7GFCRRi9a1pM3bwI+zY+wOxbK6zJtLR5N5R/e45Ba05xdjWpIPS9vH oU8zUQru9TbROnVmK41q2CYJP4Pu+YAWMvaRJrL5dfAx5MLISKT1rnUOZUilJq+bn/YO xF3u5TImOJ1iwHWIwGe7wM3rqPx9beEbBS3LyMRiyz8wMRB7sB0rIXN8SXf6EkFPibiA X6ftqj5322Jt10Ep5yp190yLa030a/ijtNxujj8EkMZhoYvYjhNHv6RYJ5mRmEGoMvGd FtCcn6m8hnazWlUhMsRsfH80DFgjbUVioG6Ldu/P7Enu5DyjgMwuGOue7PQ9fmnNT2Um ySfg== X-Gm-Message-State: AOAM532WfEo7mMdnu2Q9e9hQQ5SXkb+/+ff6DA1KIjbKYl30wwrBg6va 3q7w4myYZftYRlpWAwBVQjjJ4iF5tklPVcKJSeI= X-Google-Smtp-Source: ABdhPJydNhoRcU4F9++M7+BFSAGysOcXhyO8/MEtoORm2Fzk3Ykujk6hiDy48VdoeeQHgRWdM6RLbA== X-Received: by 2002:a17:906:7257:: with SMTP id n23mr3146650ejk.412.1619772471402; Fri, 30 Apr 2021 01:47:51 -0700 (PDT) Received: from localhost (ip-213-220-236-33.net.upcbroadband.cz. [213.220.236.33]) by smtp.gmail.com with ESMTPSA id s20sm751262edu.93.2021.04.30.01.47.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Apr 2021 01:47:50 -0700 (PDT) Mime-Version: 1.0 Cc: "Thierry Reding" , "Lee Jones" , "Maxime Ripard" , "Chen-Yu Tsai" , "Jernej Skrabec" , , , , , "Roman Beranek" Subject: Re: [PATCH] pwm: sun4i: Round delay time up to a nearest jiffy From: "Roman Beranek" To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Date: Fri, 30 Apr 2021 09:17:49 +0200 Message-Id: In-Reply-To: <20210430064145.nzlcw3lpayzapnbx@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210430_014753_774610_030F91AD X-CRM114-Status: GOOD ( 23.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gVXdlLAoKT24gRnJpIEFwciAzMCwgMjAyMSBhdCA4OjQxIEFNIENFU1QsIFV3ZSBLbGVp bmUtS8O2bmlnIHdyb3RlOgo+IE9uIEZyaSwgQXByIDMwLCAyMDIxIGF0IDA0OjE5OjMyQU0gKzAy MDAsIFJvbWFuIEJlcsOhbmVrIHdyb3RlOgo+ID4gT24gVGh1LCBBcHIgMjksIDIwMjEgYXQgMjow NCBQTSBVd2UgS2xlaW5lLUvDtm5pZyB3cm90ZToKPiA+ID4gT24gV2VkLCBBcHIgMjgsIDIwMjEg YXQgMDI6MTQ6MzFQTSArMDIwMCwgUm9tYW4gQmVyw6FuZWsgd3JvdGU6Cj4gPiA+ID4gQ29ycmVj dCwgdGhlIG91dHB1dCBtYXkgc3RheSBpbiBhbiBhY3RpdmUgc3RhdGUuIEkgb25seSBkaXNjb3Zl cmVkIHRoaXMKPiA+ID4gPiBidWcgYXMgSSBpbnZlc3RpZ2F0ZWQgYSByZXBvcnQgb2YgdW5yZWxp YWJsZSBzY3JlZW4gdGltZW91dC4gVGhlIHBlcmlvZAo+ID4gPiA+IHdlIHVzZSB0aGUgUFdNIHdp dGggaXMgNTAgdXMuCj4gPiA+Cj4gPiA+IFdoYXQgSSBkb24ndCBsaWtlIGhlcmUgaXMgdGhhdCB0 aGUgZGVsYXkgaXMgcXVpdGUgY29hcnNlIGFuZCBtaWdodCBzdGlsbAo+ID4gPiBiZSB0b28gc2hv cnQuIChNYXliZSBJIG1pc3Mgc29tZXRoaW5nLCBidXQgY29uc2lkZXIgdGhlIGN1cnJlbnQgcGVy aW9kCj4gPiA+IGlzIHF1aXRlIGxvbmcsIHRoZW4geW91IGNvbmZpZ3VyZSBhIHNob3J0IG9uZSBh bmQgdGhlbiBkaXNhYmxlLiBJbiB0aGlzCj4gPiA+IGNhc2UgdGhlIGluaXRhbCBsb25nIHNldHRp bmcgbWlnaHQgc3RpbGwgYmUgYWN0aXZlLikKPiA+IAo+ID4gVGhlIGRlbGF5IGlzIGNhbGN1bGF0 ZWQgZnJvbSB0aGUgb3JpZ2luYWwgcGVyaW9kIChjc3RhdGUucGVyaW9kKSwKPiA+IG5vdCB0aGUg b25lIHRoYXQgd2FzIGp1c3Qgd3JpdHRlbiBpbnRvIFBXTV9DSHhfUFJEIDIgbGluZXMgYWJvdmUu Cj4KPiBZZXMsIGJ1dCB0aGF0J3Mgbm90IGdvb2QgZW5vdWdoLiBDb25zaWRlciB0aGUgUFdNIGlz IHJ1bm5pbmcgd2l0aCBhCj4gcGVyaW9kIG9mIDRzIGFuZCB0aGUgcGVyaW9kIGp1c3Qgc3RhcnRl ZC4gVGhlbiB5b3UgY2FsbAo+Cj4gcHdtX2FwcGx5X3N0YXRlKG15cHdtLCAmKHN0cnVjdCBwd21f c3RhdGUpewo+IC5wZXJpb2QgPSAyMCwKPiAuZW5hYmxlZCA9IDEsCj4gLi4uCj4gfSkKPgo+IFRo aXMgZG9lc24ndCByZXN1bHQgaW50byB0aGUgd2FpdGluZyBjb2RlIGJlaW5nIHJ1biwgYmVjYXVz ZQo+IC5lbmFibGVkID0gMS4gVGhlbiBpbW1pZGlhdGVseSBhZnRlciB0aGF0IGNhbGw6Cj4KPiBw d21fYXBwbHlfc3RhdGUobXlwd20sICYoc3RydWN0IHB3bV9zdGF0ZSl7Cj4gLnBlcmlvZCA9IDIw LAo+IC5lbmFibGVkID0gMCwKPiAuLi4KPiB9KQo+Cj4gd2hpY2ggdHJpZ2dlcnMgdGhlIHdhaXRp bmcgYnV0IG9ubHkgYmFzZWQgb24gYSBwZXJpb2Qgb2YgMjAgbnMgd2hpbGUgdGhlCj4gNHMgcGVy aW9kIGlzIHN0aWxsIGFjdGl2ZS4KCk9LLCBub3cgSSBzZWUgd2hhdCB5b3UgbWVhbi4gVG8gcmVt ZWR5IHRoaXMsIHRoZSBkZWxheSBzaGFsbCBvY2N1cgpyZWdhcmRsZXNzIG9mIHN0YXRlLT5lbmFi bGVkLgoKSW4gbXkgdmlldywgdGhpcyBsaWVzIGJlbmVhdGggdGhlIHNjb3BlIG9mIHRoZSBwYXRj aCB0aG91Z2ggYW5kIHdvdWxkIGJlCmJldHRlciBzZXJ2ZWQgYXMgYSBmb2xsb3ctdXAuCgpDaGVl cnMsClJvbWFuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==