All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Barros Pena, Belen" <belen.barros.pena@intel.com>
To: "Wang, Shane" <shane.wang@intel.com>,
	"Xu, Dongxiao" <dongxiao.xu@intel.com>,
	"Lu, Lianhao" <lianhao.lu@intel.com>
Cc: "Purdie, Richard" <richard.purdie@intel.com>,
	"Lock, Joshua" <joshua.lock@intel.com>,
	"yocto@yoctoproject.org" <yocto@yoctoproject.org>,
	"Eggleton, Paul" <paul.eggleton@intel.com>
Subject: Re: RFC: Hob 1.2 design
Date: Mon, 6 Feb 2012 11:53:59 +0000	[thread overview]
Message-ID: <CB5565F6.72C6%belen.barros.pena@intel.com> (raw)
In-Reply-To: <3AB6CE7F274E534CAFD089D127A8A1FC0FCEBEDF@SHSMSX102.ccr.corp.intel.com>

Hi Shane and team,

In general all sounds good. I just have a couple of small comments, which I've added below.

Belen

From: "Wang, Shane" <shane.wang@intel.com<mailto:shane.wang@intel.com>>
Date: Fri, 3 Feb 2012 05:29:57 +0000
To: "Xu, Dongxiao" <dongxiao.xu@intel.com<mailto:dongxiao.xu@intel.com>>, "Belen Barros Pena (Intel)" <belen.barros.pena@intel.com<mailto:belen.barros.pena@intel.com>>, "Lu, Lianhao" <lianhao.lu@intel.com<mailto:lianhao.lu@intel.com>>
Cc: "Eggleton, Paul" <paul.eggleton@intel.com<mailto:paul.eggleton@intel.com>>, "Purdie, Richard" <richard.purdie@intel.com<mailto:richard.purdie@intel.com>>, "Zhang, Jessica" <jessica.zhang@intel.com<mailto:jessica.zhang@intel.com>>, "Lock, Joshua" <joshua.lock@intel.com<mailto:joshua.lock@intel.com>>, "Liu, Song" <song.liu@intel.com<mailto:song.liu@intel.com>>, "Stewart, David C" <david.c.stewart@intel.com<mailto:david.c.stewart@intel.com>>, "yocto@yoctoproject.org<mailto:yocto@yoctoproject.org>" <yocto@yoctoproject.org<mailto:yocto@yoctoproject.org>>
Subject: RE: RFC: Hob 1.2 design

Dongxiao and I have a discussion on that again.

Belen, please ignore the issue for the deployment button below, and we have several suggestions.

1. To make the Packages Screen and the Packages dialog the same.
The Packages Screen is shown after users click “Build packages”. That is one step of the process.
However, the content shown in the Package dialog is all what we have built out last time. It is very possible users start from there and don’t want to go back to the Image configuration screen and click “Build Image”.

Sorry, I am not sure I understand. What you seem to be saying is that we will eliminate the 'View packages' button from the Image configuration screen and the Packages dialogue. Users will access packages information via the 'Build packages' option, which will bring them to the Packages screen. Is this correct?

2. As mentioned in my last email, we want to add “Clean” in the GUI. The reason is the build will fail, say, do_fetch, then we have an option to allow users to clean what we built out and rebuild. Otherwise, the sstate could be reused for the next build. Users can do it by running “bitbake –c cleanall” in the command line. But we hope to provide this feature in the GUI.
If you agree the above, then the action “Clean” is for a recipe or multiple recipes, and clicking “Clean” will go to the screen at 4:00, since cleaning includes some tasks.
Then we could make the Recipes dialog to be a screen, do you agree?

Yes: I agree with you. Making Recipes a screen instead of a dialogue seems like a good solution. However, I am not sure the 'Clean' function should be in the Recipes screen: it should probably be an option that is displayed when the build fails. If you select it you go to the screen at 4:00 to provide information about the cleaning tasks and once they are done, you get the Recipes screen ready for you to build again. I think this 'build failed' scenario is very important, and I would like to design it carefully. Would  it be ok if I work on it this week and send you some suggestions?

The other reason is users can view recipes and click “Build Packages”, no need go back to the Image configuration screen.
The use case is:
1) View Recipes in the Image configuration -> the Recipes screen -> Select recipes and Build packages -> Log -> the Packages screen …
2) View Recipes in the Image configuration -> the Recipes screen -> Select recipes and Build packages -> Log -> Failure -> Go back to the Recipes screen -> Clean something -> Log -> the Recipes screen -> Build packages again -> Log -> Success -> the Packages screen …
3) View Recipes in the Image configuration -> the Recipes screen -> Select recipes -> Go back to the Image configuraion -> “Build Image”
4) Nothing want to view in the Image configuration after choosing “base image” -> “Build packages” -> Log -> the Packages screen …
5) Nothing want to view in the Image configuration after choosing “base image” -> “Build packages” -> Log -> Failure -> Go back to the Image configuration -> View Recipes -> the Recipes screen -> Clean something -> Log -> the Recipe screen -> …
6) Nothing want to view in the Image configuration after choosing “base image” -> “Build Image” -> Log -> the Image details …
and so on…

This seems to make sense. Just a small comment about the use case number 3. I think the Recipes screen should have 2 actions: "build packages" and "build image", so that users who want to build an image directly from the Recipes screen don't need to go back to the Image configuration screen in order to build the image.

3. When build is failed, there is a “Back” button. But go back to where is determined by where you come from.

I'll keep this in mind when designing the 'build failed' scenario.

4. After users open an image by “My images”, some time there should not be a “Save Template” because we don’t have build process.
Let’s show “Save Template” when “Congratulations! Your image is ready!” is shown, OK?

This sounds ok to me. Should we have a 'save as template' option in the Image configuration screen? Or will we just have it in the Image details screen when you get there after completing the build process?

5. In the Image details screen, “Settings” is obviously not good to be shown there. Can we remove “Load Template”? Because it will initiate a new build. Let’s ask users to click “Build new image” to be on the Image configuration and click “Load Template”.
We just keep “My Images” in the last screen (the Image details screen), is it OK?
And remove “Edit Packages” and “Edit Configuration”, if the build process is not executed this time. (ditto for “Save Template” in 4.)

Happy with this.

6. In Josh’s email, FRI 2 image can also be run, though it is an image for real machine. Can we keep two buttons “Run” and “Deploy” on the Image details screen and let uses decide what he/she wants? I admit an error possibly happens if the image doesn’t match the action, but we just report the error.

Not so happy with this one ;) If an option is going to generate an error when selected, it should not be there at all. GUI's must be defensive: they must prevent user errors. This is a fundamental principle of interaction design. We should only present the  'Run' (on qemu) option if the image is suitable for qemu running. We should only display the 'Deploy' option for live images. If there is no way to reliably determine what type of image we are dealing with and which options are suitable for them, the 'Run' and 'Deploy' functionality should not be there at all. Better wait until we find a work around.

Having said that, it seems to me that using the file extension to determine what's the appropriate action for each image should work the vast majority of times. If someone has changed the extension of the image, well, that would be an edge case (how likely are people to do that?), and we should not get into the trap of designing for the edge case, which is what we would be doing if we were to display both 'run' and 'deploy' for all images.

Thoughts?
Thanks.
--
Shane

From: Xu, Dongxiao
Sent: Friday, February 03, 2012 8:57 AM
To: Wang, Shane; Barros Pena, Belen; Lu, Lianhao
Cc: Eggleton, Paul; Purdie, Richard; Zhang, Jessica; Lock, Joshua; Liu, Song; Stewart, David C; yocto@yoctoproject.org<mailto:yocto@yoctoproject.org>
Subject: RE: RFC: Hob 1.2 design

One more from me that, Hob may work as a deploy tool, and in the new movie, the approach is to select “My images” and then click deploy button. I think normal user may not have such knowledge. I am still wondering if adding a “deploy” button in the tool bar?

Thanks,
Dongxiao

From: Wang, Shane
Sent: Friday, February 03, 2012 8:26 AM
To: Wang, Shane; Barros Pena, Belen; Xu, Dongxiao; Lu, Lianhao
Cc: Eggleton, Paul; Purdie, Richard; Zhang, Jessica; Lock, Joshua; Liu, Song; Stewart, David C; yocto@yoctoproject.org<mailto:yocto@yoctoproject.org>
Subject: RE: RFC: Hob 1.2 design

I get one more:

In the Image details screen, after opening an image file by clicking “My images”, we don’t allow to “Edit Package”, I think.
Because with an image only, we can’t generate the packages from it, you can’t assume there is a build directory (tmp/), is my understanding correct?

--
Shane
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



  parent reply	other threads:[~2012-02-06 11:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3AB6CE7F274E534CAFD089D127A8A1FC0FCE9F5F@SHSMSX102.ccr.corp.intel.com>
     [not found] ` <CB4F0427.6A93%belen.barros.pena@intel.com>
2012-02-02 12:48   ` RFC: Hob 1.2 design Wang, Shane
2012-02-02 22:29     ` Joshua Lock
2012-02-03  0:25     ` Wang, Shane
2012-02-03  0:56       ` Xu, Dongxiao
2012-02-03  5:29         ` Wang, Shane
2012-02-03 15:01           ` Barros Pena, Belen
2012-02-06 11:53           ` Barros Pena, Belen [this message]
2012-02-03  0:35     ` Xu, Dongxiao
2012-02-01  1:39 Wang, Shane
2012-02-01 17:28 ` Scott Garman
2012-02-02 10:12   ` Jack Mitchell
2012-02-06 21:32 ` Joshua Lock
2012-02-07 11:23   ` Barros Pena, Belen
2012-02-07 16:17     ` Joshua Lock
2012-02-08 10:23       ` Barros Pena, Belen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB5565F6.72C6%belen.barros.pena@intel.com \
    --to=belen.barros.pena@intel.com \
    --cc=dongxiao.xu@intel.com \
    --cc=joshua.lock@intel.com \
    --cc=lianhao.lu@intel.com \
    --cc=paul.eggleton@intel.com \
    --cc=richard.purdie@intel.com \
    --cc=shane.wang@intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.