From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Errors of doing "make install-tools" with xen-4.2-unstable? Date: Fri, 11 May 2012 17:44:16 +0100 Message-ID: References: <1336753463.23818.131.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="B_3419603063_121100067" Return-path: In-Reply-To: <1336753463.23818.131.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Bei Guan Cc: xen-devel List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3419603063_121100067 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit On 11/05/2012 17:24, "Ian Campbell" wrote: > On Fri, 2012-05-11 at 17:10 +0100, Bei Guan wrote: > > >> No, it doesn't work for me. There is the same error. > > Hrm. Since you can reproduce would you mind experimenting a bit to > figure out the correct fix for this? > > Perhaps adding -Wno-unused-result to C flags helps (google suggests it > may not)? > > Or maybe just assigning to a dummy variable. Bei, Please try the attached patch. -- Keir > Ian. > >> My environment and gcc version are like this: >> >> root@gavin-desktop:~# uname -a >> Linux gavin-desktop 2.6.32-5-xen-amd64 #1 SMP Thu May 19 01:16:47 UTC >> 2011 x86_64 GNU/Linux >> >> root@gavin-desktop:~# gcc -v >> Using built-in specs. >> Target: x86_64-linux-gnu >> Configured with: ../src/configure -v --with-pkgversion='Ubuntu >> 4.4.3-4ubuntu5' >> --with-bugurl=file:///usr/share/doc/gcc-4.4/README.Bugs >> --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr >> --enable-shared --enable-multiarch --enable-linker-build-id >> --with-system-zlib --libexecdir=/usr/lib --without-included-gettext >> --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.4 >> --program-suffix=-4.4 --enable-nls --enable-clocale=gnu >> --enable-libstdcxx-debug --enable-plugin --enable-objc-gc >> --disable-werror --with-arch-32=i486 --with-tune=generic >> --enable-checking=release --build=x86_64-linux-gnu >> --host=x86_64-linux-gnu --target=x86_64-linux-gnu >> Thread model: posix >> gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5) >> >> >> >> >> Thanks, >> Bei Guan >> >> >> >> >> >> 8<------------------------------------------------------ >> >> # HG changeset patch >> # User Ian Campbell >> # Date 1336751175 -3600 >> # Node ID 15ed8f45c4e57a1e206af020e0ff17b792108e99 >> # Parent adc74e492edfee6cf44e433e3e93743a3cf71999 >> blktap: avoid attribute warn_unused_result build failures. >> >> I'm not proud of this, but since none of these callers of >> read/write have any >> other error handling and return void themselves (for several >> links up the call >> chain AFAICT) and because I don't really want to get into a >> massive reworking >> of blktap2 I suppose it is at least pragmatic >> >> Signed-off-by: Ian Campbell >> >> diff -r adc74e492edf -r 15ed8f45c4e5 >> tools/blktap2/drivers/tapdisk-log.c >> --- a/tools/blktap2/drivers/tapdisk-log.c Fri May 11 >> 16:19:16 2012 +0100 >> +++ b/tools/blktap2/drivers/tapdisk-log.c Fri May 11 >> 16:46:15 2012 +0100 >> @@ -247,7 +247,7 @@ tlog_flush(void) >> wsize = ((size + 511) & (~511)); >> >> memset(tapdisk_log.buf + size, '\n', wsize - size); >> - write(fd, tapdisk_log.buf, wsize); >> + (void)write(fd, tapdisk_log.buf, wsize); >> >> tapdisk_log.p = tapdisk_log.buf; >> >> diff -r adc74e492edf -r 15ed8f45c4e5 >> tools/blktap2/drivers/tapdisk-queue.c >> --- a/tools/blktap2/drivers/tapdisk-queue.c Fri May 11 >> 16:19:16 2012 +0100 >> +++ b/tools/blktap2/drivers/tapdisk-queue.c Fri May 11 >> 16:46:15 2012 +0100 >> @@ -435,7 +435,7 @@ tapdisk_lio_ack_event(struct tqueue *que >> uint64_t val; >> >> if (lio->flags & LIO_FLAG_EVENTFD) >> - read(lio->event_fd, &val, sizeof(val)); >> + (void)read(lio->event_fd, &val, sizeof(val)); >> } >> >> static void >> diff -r adc74e492edf -r 15ed8f45c4e5 >> tools/blktap2/drivers/tapdisk-stream.c >> --- a/tools/blktap2/drivers/tapdisk-stream.c Fri May 11 >> 16:19:16 2012 +0100 >> +++ b/tools/blktap2/drivers/tapdisk-stream.c Fri May 11 >> 16:46:15 2012 +0100 >> @@ -145,7 +145,7 @@ tapdisk_stream_poll_clear(struct tapdisk >> { >> int dummy; >> >> - read(p->pipe[POLL_READ], &dummy, sizeof(dummy)); >> + (void)read(p->pipe[POLL_READ], &dummy, sizeof(dummy)); >> p->set = 0; >> } >> >> @@ -155,7 +155,7 @@ tapdisk_stream_poll_set(struct tapdisk_s >> int dummy = 0; >> >> if (!p->set) { >> - write(p->pipe[POLL_WRITE], &dummy, >> sizeof(dummy)); >> + (void)write(p->pipe[POLL_WRITE], &dummy, >> sizeof(dummy)); >> p->set = 1; >> } >> } >> @@ -203,7 +203,7 @@ tapdisk_stream_print_request(struct tapd >> { >> unsigned long idx = (unsigned >> long)tapdisk_stream_request_idx(s, sreq); >> char *buf = (char *)MMAP_VADDR(s->vbd->ring.vstart, >> idx, 0); >> - write(s->out_fd, buf, sreq->secs << SECTOR_SHIFT); >> + (void)write(s->out_fd, buf, sreq->secs << >> SECTOR_SHIFT); >> } >> >> static void >> diff -r adc74e492edf -r 15ed8f45c4e5 >> tools/blktap2/drivers/tapdisk2.c >> --- a/tools/blktap2/drivers/tapdisk2.c Fri May 11 16:19:16 >> 2012 +0100 >> +++ b/tools/blktap2/drivers/tapdisk2.c Fri May 11 16:46:15 >> 2012 +0100 >> @@ -79,7 +79,12 @@ main(int argc, char *argv[]) >> if (optind != argc) >> usage(argv[0], EINVAL); >> >> - chdir("/"); >> + if (chdir("/")) { >> + DPRINTF("failed to chdir(/): %d\n", errno); >> + err = 1; >> + goto out; >> + } >> + >> tapdisk_start_logging("tapdisk2"); >> >> err = tapdisk_server_init(); >> >> >> >> >> >> -- >> Best Regards, >> Bei Guan >> > > --B_3419603063_121100067 Content-type: application/octet-stream; name="00-tapdisk-check-io-result" Content-disposition: attachment; filename="00-tapdisk-check-io-result" Content-transfer-encoding: base64 ZGlmZiAtciBhZjZkMjRkNDdiNTYgdG9vbHMvYmxrdGFwMi9kcml2ZXJzL3RhcGRpc2stZGlm Zi5jCi0tLSBhL3Rvb2xzL2Jsa3RhcDIvZHJpdmVycy90YXBkaXNrLWRpZmYuYwlGcmkgTWF5 IDExIDEyOjIwOjQzIDIwMTIgKzAxMDAKKysrIGIvdG9vbHMvYmxrdGFwMi9kcml2ZXJzL3Rh cGRpc2stZGlmZi5jCUZyaSBNYXkgMTEgMTc6NDM6NDcgMjAxMiArMDEwMApAQCAtMzksNiAr MzksNyBAQAogI2luY2x1ZGUgInRhcGRpc2stdmJkLmgiCiAjaW5jbHVkZSAidGFwZGlzay1z ZXJ2ZXIuaCIKICNpbmNsdWRlICJ0YXBkaXNrLWRpc2t0eXBlLmgiCisjaW5jbHVkZSAidGFw ZGlzay11dGlscy5oIgogI2luY2x1ZGUgImxpYnZoZC5oIgogCiAjZGVmaW5lIFBPTExfUkVB RCAgICAgICAgICAgICAgICAgICAgICAgIDAKQEAgLTE3MCw3ICsxNzEsNyBAQCB0YXBkaXNr X3N0cmVhbV9wb2xsX2NsZWFyKHN0cnVjdCB0YXBkaXNrCiB7CiAJaW50IGR1bW15OwogCi0J cmVhZChwLT5waXBlW1BPTExfUkVBRF0sICZkdW1teSwgc2l6ZW9mKGR1bW15KSk7CisJcmVh ZF9leGFjdChwLT5waXBlW1BPTExfUkVBRF0sICZkdW1teSwgc2l6ZW9mKGR1bW15KSk7CiAJ cC0+c2V0ID0gMDsKIH0KIApAQCAtMTgwLDcgKzE4MSw3IEBAIHRhcGRpc2tfc3RyZWFtX3Bv bGxfc2V0KHN0cnVjdCB0YXBkaXNrX3MKIAlpbnQgZHVtbXkgPSAwOwogCiAJaWYgKCFwLT5z ZXQpIHsKLQkJd3JpdGUocC0+cGlwZVtQT0xMX1dSSVRFXSwgJmR1bW15LCBzaXplb2YoZHVt bXkpKTsKKwkJd3JpdGVfZXhhY3QocC0+cGlwZVtQT0xMX1dSSVRFXSwgJmR1bW15LCBzaXpl b2YoZHVtbXkpKTsKIAkJcC0+c2V0ID0gMTsKIAl9CiB9CmRpZmYgLXIgYWY2ZDI0ZDQ3YjU2 IHRvb2xzL2Jsa3RhcDIvZHJpdmVycy90YXBkaXNrLWxvZy5jCi0tLSBhL3Rvb2xzL2Jsa3Rh cDIvZHJpdmVycy90YXBkaXNrLWxvZy5jCUZyaSBNYXkgMTEgMTI6MjA6NDMgMjAxMiArMDEw MAorKysgYi90b29scy9ibGt0YXAyL2RyaXZlcnMvdGFwZGlzay1sb2cuYwlGcmkgTWF5IDEx IDE3OjQzOjQ3IDIwMTIgKzAxMDAKQEAgLTM3LDYgKzM3LDcgQEAKICNpbmNsdWRlIDxzeXMv dGltZS5oPgogCiAjaW5jbHVkZSAidGFwZGlzay1sb2cuaCIKKyNpbmNsdWRlICJ0YXBkaXNr LXV0aWxzLmgiCiAKICNkZWZpbmUgTUFYX0VOVFJZX0xFTiAgICAgIDUxMgogI2RlZmluZSBN QVhfRVJST1JfTUVTU0FHRVMgMTYKQEAgLTI0Nyw3ICsyNDgsNyBAQCB0bG9nX2ZsdXNoKHZv aWQpCiAJd3NpemUgPSAoKHNpemUgKyA1MTEpICYgKH41MTEpKTsKIAogCW1lbXNldCh0YXBk aXNrX2xvZy5idWYgKyBzaXplLCAnXG4nLCB3c2l6ZSAtIHNpemUpOwotCXdyaXRlKGZkLCB0 YXBkaXNrX2xvZy5idWYsIHdzaXplKTsKKwl3cml0ZV9leGFjdChmZCwgdGFwZGlza19sb2cu YnVmLCB3c2l6ZSk7CiAKIAl0YXBkaXNrX2xvZy5wID0gdGFwZGlza19sb2cuYnVmOwogCmRp ZmYgLXIgYWY2ZDI0ZDQ3YjU2IHRvb2xzL2Jsa3RhcDIvZHJpdmVycy90YXBkaXNrLXF1ZXVl LmMKLS0tIGEvdG9vbHMvYmxrdGFwMi9kcml2ZXJzL3RhcGRpc2stcXVldWUuYwlGcmkgTWF5 IDExIDEyOjIwOjQzIDIwMTIgKzAxMDAKKysrIGIvdG9vbHMvYmxrdGFwMi9kcml2ZXJzL3Rh cGRpc2stcXVldWUuYwlGcmkgTWF5IDExIDE3OjQzOjQ3IDIwMTIgKzAxMDAKQEAgLTQzNSw3 ICs0MzUsNyBAQCB0YXBkaXNrX2xpb19hY2tfZXZlbnQoc3RydWN0IHRxdWV1ZSAqcXVlCiAJ dWludDY0X3QgdmFsOwogCiAJaWYgKGxpby0+ZmxhZ3MgJiBMSU9fRkxBR19FVkVOVEZEKQot CQlyZWFkKGxpby0+ZXZlbnRfZmQsICZ2YWwsIHNpemVvZih2YWwpKTsKKwkJcmVhZF9leGFj dChsaW8tPmV2ZW50X2ZkLCAmdmFsLCBzaXplb2YodmFsKSk7CiB9CiAKIHN0YXRpYyB2b2lk CmRpZmYgLXIgYWY2ZDI0ZDQ3YjU2IHRvb2xzL2Jsa3RhcDIvZHJpdmVycy90YXBkaXNrLXN0 cmVhbS5jCi0tLSBhL3Rvb2xzL2Jsa3RhcDIvZHJpdmVycy90YXBkaXNrLXN0cmVhbS5jCUZy aSBNYXkgMTEgMTI6MjA6NDMgMjAxMiArMDEwMAorKysgYi90b29scy9ibGt0YXAyL2RyaXZl cnMvdGFwZGlzay1zdHJlYW0uYwlGcmkgTWF5IDExIDE3OjQzOjQ3IDIwMTIgKzAxMDAKQEAg LTM4LDYgKzM4LDcgQEAKICNpbmNsdWRlICJ0YXBkaXNrLXZiZC5oIgogI2luY2x1ZGUgInRh cGRpc2stc2VydmVyLmgiCiAjaW5jbHVkZSAidGFwZGlzay1kaXNrdHlwZS5oIgorI2luY2x1 ZGUgInRhcGRpc2stdXRpbHMuaCIKIAogI2RlZmluZSBQT0xMX1JFQUQgICAgICAgICAgICAg ICAgICAgICAgICAwCiAjZGVmaW5lIFBPTExfV1JJVEUgICAgICAgICAgICAgICAgICAgICAg IDEKQEAgLTE0NSw3ICsxNDYsNyBAQCB0YXBkaXNrX3N0cmVhbV9wb2xsX2NsZWFyKHN0cnVj dCB0YXBkaXNrCiB7CiAJaW50IGR1bW15OwogCi0JcmVhZChwLT5waXBlW1BPTExfUkVBRF0s ICZkdW1teSwgc2l6ZW9mKGR1bW15KSk7CisJcmVhZF9leGFjdChwLT5waXBlW1BPTExfUkVB RF0sICZkdW1teSwgc2l6ZW9mKGR1bW15KSk7CiAJcC0+c2V0ID0gMDsKIH0KIApAQCAtMTU1 LDcgKzE1Niw3IEBAIHRhcGRpc2tfc3RyZWFtX3BvbGxfc2V0KHN0cnVjdCB0YXBkaXNrX3MK IAlpbnQgZHVtbXkgPSAwOwogCiAJaWYgKCFwLT5zZXQpIHsKLQkJd3JpdGUocC0+cGlwZVtQ T0xMX1dSSVRFXSwgJmR1bW15LCBzaXplb2YoZHVtbXkpKTsKKwkJd3JpdGVfZXhhY3QocC0+ cGlwZVtQT0xMX1dSSVRFXSwgJmR1bW15LCBzaXplb2YoZHVtbXkpKTsKIAkJcC0+c2V0ID0g MTsKIAl9CiB9CkBAIC0yMDMsNyArMjA0LDcgQEAgdGFwZGlza19zdHJlYW1fcHJpbnRfcmVx dWVzdChzdHJ1Y3QgdGFwZAogewogCXVuc2lnbmVkIGxvbmcgaWR4ID0gKHVuc2lnbmVkIGxv bmcpdGFwZGlza19zdHJlYW1fcmVxdWVzdF9pZHgocywgc3JlcSk7CiAJY2hhciAqYnVmID0g KGNoYXIgKilNTUFQX1ZBRERSKHMtPnZiZC0+cmluZy52c3RhcnQsIGlkeCwgMCk7Ci0Jd3Jp dGUocy0+b3V0X2ZkLCBidWYsIHNyZXEtPnNlY3MgPDwgU0VDVE9SX1NISUZUKTsKKwl3cml0 ZV9leGFjdChzLT5vdXRfZmQsIGJ1Ziwgc3JlcS0+c2VjcyA8PCBTRUNUT1JfU0hJRlQpOwog fQogCiBzdGF0aWMgdm9pZApkaWZmIC1yIGFmNmQyNGQ0N2I1NiB0b29scy9ibGt0YXAyL2Ry aXZlcnMvdGFwZGlzay11dGlscy5jCi0tLSBhL3Rvb2xzL2Jsa3RhcDIvZHJpdmVycy90YXBk aXNrLXV0aWxzLmMJRnJpIE1heSAxMSAxMjoyMDo0MyAyMDEyICswMTAwCisrKyBiL3Rvb2xz L2Jsa3RhcDIvZHJpdmVycy90YXBkaXNrLXV0aWxzLmMJRnJpIE1heSAxMSAxNzo0Mzo0NyAy MDEyICswMTAwCkBAIC0xNzUsMyArMTc1LDQwIEBAIGludCB0YXBkaXNrX2xpbnV4X3ZlcnNp b24odm9pZCkKIH0KIAogI2VuZGlmCitpbnQgcmVhZF9leGFjdChpbnQgZmQsIHZvaWQgKmRh dGEsIHNpemVfdCBzaXplKQoreworICAgIHNpemVfdCBvZmZzZXQgPSAwOworICAgIHNzaXpl X3QgbGVuOworCisgICAgd2hpbGUgKCBvZmZzZXQgPCBzaXplICkKKyAgICB7CisgICAgICAg IGxlbiA9IHJlYWQoZmQsIChjaGFyICopZGF0YSArIG9mZnNldCwgc2l6ZSAtIG9mZnNldCk7 CisgICAgICAgIGlmICggKGxlbiA9PSAtMSkgJiYgKGVycm5vID09IEVJTlRSKSApCisgICAg ICAgICAgICBjb250aW51ZTsKKyAgICAgICAgaWYgKCBsZW4gPT0gMCApCisgICAgICAgICAg ICBlcnJubyA9IDA7CisgICAgICAgIGlmICggbGVuIDw9IDAgKQorICAgICAgICAgICAgcmV0 dXJuIC0xOworICAgICAgICBvZmZzZXQgKz0gbGVuOworICAgIH0KKworICAgIHJldHVybiAw OworfQorCitpbnQgd3JpdGVfZXhhY3QoaW50IGZkLCBjb25zdCB2b2lkICpkYXRhLCBzaXpl X3Qgc2l6ZSkKK3sKKyAgICBzaXplX3Qgb2Zmc2V0ID0gMDsKKyAgICBzc2l6ZV90IGxlbjsK KworICAgIHdoaWxlICggb2Zmc2V0IDwgc2l6ZSApCisgICAgeworICAgICAgICBsZW4gPSB3 cml0ZShmZCwgKGNvbnN0IGNoYXIgKilkYXRhICsgb2Zmc2V0LCBzaXplIC0gb2Zmc2V0KTsK KyAgICAgICAgaWYgKCAobGVuID09IC0xKSAmJiAoZXJybm8gPT0gRUlOVFIpICkKKyAgICAg ICAgICAgIGNvbnRpbnVlOworICAgICAgICBpZiAoIGxlbiA8PSAwICkKKyAgICAgICAgICAg IHJldHVybiAtMTsKKyAgICAgICAgb2Zmc2V0ICs9IGxlbjsKKyAgICB9CisKKyAgICByZXR1 cm4gMDsKK30KZGlmZiAtciBhZjZkMjRkNDdiNTYgdG9vbHMvYmxrdGFwMi9kcml2ZXJzL3Rh cGRpc2stdXRpbHMuaAotLS0gYS90b29scy9ibGt0YXAyL2RyaXZlcnMvdGFwZGlzay11dGls cy5oCUZyaSBNYXkgMTEgMTI6MjA6NDMgMjAxMiArMDEwMAorKysgYi90b29scy9ibGt0YXAy L2RyaXZlcnMvdGFwZGlzay11dGlscy5oCUZyaSBNYXkgMTEgMTc6NDM6NDcgMjAxMiArMDEw MApAQCAtMzksNCArMzksNyBAQCBpbnQgdGFwZGlza19uYW1lZHVwKGNoYXIgKiosIGNvbnN0 IGNoYXIgCiBpbnQgdGFwZGlza19nZXRfaW1hZ2Vfc2l6ZShpbnQsIHVpbnQ2NF90ICosIHVp bnQzMl90ICopOwogaW50IHRhcGRpc2tfbGludXhfdmVyc2lvbih2b2lkKTsKIAoraW50IHJl YWRfZXhhY3QoaW50IGZkLCB2b2lkICpkYXRhLCBzaXplX3Qgc2l6ZSk7IC8qIEVPRiA9PiAt MSwgZXJybm89MCAqLworaW50IHdyaXRlX2V4YWN0KGludCBmZCwgY29uc3Qgdm9pZCAqZGF0 YSwgc2l6ZV90IHNpemUpOworCiAjZW5kaWYKZGlmZiAtciBhZjZkMjRkNDdiNTYgdG9vbHMv YmxrdGFwMi9kcml2ZXJzL3RhcGRpc2syLmMKLS0tIGEvdG9vbHMvYmxrdGFwMi9kcml2ZXJz L3RhcGRpc2syLmMJRnJpIE1heSAxMSAxMjoyMDo0MyAyMDEyICswMTAwCisrKyBiL3Rvb2xz L2Jsa3RhcDIvZHJpdmVycy90YXBkaXNrMi5jCUZyaSBNYXkgMTEgMTc6NDM6NDcgMjAxMiAr MDEwMApAQCAtNzksNyArNzksMTIgQEAgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQog CWlmIChvcHRpbmQgIT0gYXJnYykKIAkJdXNhZ2UoYXJndlswXSwgRUlOVkFMKTsKIAotCWNo ZGlyKCIvIik7CisJaWYgKGNoZGlyKCIvIikpIHsKKwkJRFBSSU5URigiZmFpbGVkIHRvIGNo ZGlyKC8pOiAlZFxuIiwgZXJybm8pOworCQllcnIgPSAxOworCQlnb3RvIG91dDsKKwl9CisK IAl0YXBkaXNrX3N0YXJ0X2xvZ2dpbmcoInRhcGRpc2syIik7CiAKIAllcnIgPSB0YXBkaXNr X3NlcnZlcl9pbml0KCk7Cg== --B_3419603063_121100067 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --B_3419603063_121100067--