From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41720 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnfuX-0002bK-Jf
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 18:54:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OnfuW-0006EP-Jw
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 18:54:37 -0400
Received: from cantor2.suse.de ([195.135.220.15]:59501 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OnfuW-0006EK-C4
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 18:54:36 -0400
Subject: Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging
Mime-Version: 1.0 (Apple Message framework v1081)
Content-Type: text/plain; charset=us-ascii
From: Alexander Graf <agraf@suse.de>
In-Reply-To: <4C72FB2C.9000404@codemonkey.ws>
Date: Tue, 24 Aug 2010 00:54:33 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <CCBA2EE2-70EC-451F-9A64-EAE5D579DF3C@suse.de>
References: <1282600951-30803-1-git-send-email-agraf@suse.de>	<1282600951-30803-5-git-send-email-agraf@suse.de>	<4C72F46D.5040606@codemonkey.ws>	<F481E293-2570-47BF-8575-9D78E83EA573@suse.de>
	<B5AAA57B-BD29-4F78-AE4C-4D63B41B539C@suse.de>
	<4C72FB2C.9000404@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel List <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>, Markus Armbruster <armbru@redhat.com>


On 24.08.2010, at 00:50, Anthony Liguori wrote:

> On 08/23/2010 05:45 PM, Alexander Graf wrote:
>>> Device_add already works with this set and only required minor =
changes the s390 specific code. So that part was pretty slick :). The =
part that didn't work was the drive_add one.
>>>=20
>>> What is blockdev_add supposed to be? drive_add without IF_SCSI?
>=20
> drive_add without if=3D and without the PCI-isms.
>=20
>>> To be a bit more precise on how things work with this set:
>>>=20
>>> (qemu) drive_add 0 id=3Dmy_disk,if=3Dnone,file=3D/dev/null
>>> OK
>>>    =20
>=20
> In theory, something like:
>=20
> (qemu) blockdev_add id=3Dmy_disk,file=3D/dev/null

So why add yet another command when we could use the existing drive_add? =
Wouldn't it make more sense to deprecate if=3D!none, move forward from =
there, make if=3Dnone the default and around 0.16 or so drop if=3D from =
drive_add?


Alex