From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C970EC07E95 for ; Thu, 8 Jul 2021 00:26:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D0A161C83 for ; Thu, 8 Jul 2021 00:26:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D0A161C83 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1HsE-0001I0-HV for qemu-devel@archiver.kernel.org; Wed, 07 Jul 2021 20:26:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Hrd-0000bY-Mx for qemu-devel@nongnu.org; Wed, 07 Jul 2021 20:26:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Hrb-0003dC-Q8 for qemu-devel@nongnu.org; Wed, 07 Jul 2021 20:26:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625703959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to; bh=zJ14AsBvnpDyeB+jXIBEXMelPLsn1ueIE9wr1ycXpWc=; b=Po5UQIKsW6wgLa6/+epcFdn5Ke2TychWkH2mcUngJrSQFgcx9s8XXh5xe3EfrGQE5s6TdT r09qI6GWuUsOwanag++kMfZLuQZjJLD4pUZX7OtpPwXb/U1nzFXTgiqHN3hjApM/DEBvRU BABjPUYlzY/cfPt3BGxWmGcSFaJ2sTY= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-531-8jLGhHrEPFOcClTZqokbzQ-1; Wed, 07 Jul 2021 20:25:58 -0400 X-MC-Unique: 8jLGhHrEPFOcClTZqokbzQ-1 Received: by mail-pf1-f200.google.com with SMTP id w2-20020aa785820000b029032396e2bf68so1763936pfn.17 for ; Wed, 07 Jul 2021 17:25:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:from:to :cc:subject:date:message-id:in-reply-to; bh=zJ14AsBvnpDyeB+jXIBEXMelPLsn1ueIE9wr1ycXpWc=; b=MJ8TZvm7/0kgt1bbQ3qkyroYbu+tHtonQPNp+e2x7qEEkfUt/KDXES1K9b7UVKjt/M P+hfHahcBATJZLxHtKFpIINPKo7gSdnhRicEi/4GdtfmKviaQpmsOAals1B950E8+Gxi GLcAdLTpXagZuzopGJ32V8sLnsdByJkjG1o4JlLyARIj/cK2YqCQvWHo8J+pIM27rKSc 03ZfGyhrsRoznjbw1Gknt7kQtfNBm2n3NZp+Pos5YhTNf+JJjQQRR6rHRhudmiXfUhi8 rIhYsn/dznhefThyGbJDdk75IJ+UDJ9J8hhVUTYe7aot6BmxY+znKwo7wsj3ZBbCsqop uQgA== X-Gm-Message-State: AOAM533fFfOKn+gV8ZwxYxJ6s9VetXTa+5rxTgyCj4z/mPc/KZ42fG2v /5hnyQbGkkHC6teBF/VIer/E4didXskeGY3aH9/sA2gJVBr5oed0uYXH3+G7zRbjlNpT4FEH0/6 sobKDaL8raOKAgpM= X-Received: by 2002:a63:d84b:: with SMTP id k11mr28869524pgj.372.1625703957060; Wed, 07 Jul 2021 17:25:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz39J+aZ+EQhAlLmK8KESw0IU9SUCgHL2Ek/G6qsOkKiEN6SAHL4asOrKbjBl7PaXkSa+TDbQ== X-Received: by 2002:a63:d84b:: with SMTP id k11mr28869512pgj.372.1625703956853; Wed, 07 Jul 2021 17:25:56 -0700 (PDT) Received: from localhost ([2601:1c0:4600:3f84:cb33:5075:e7f0:7862]) by smtp.gmail.com with ESMTPSA id b62sm151344pfb.149.2021.07.07.17.25.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jul 2021 17:25:56 -0700 (PDT) Mime-Version: 1.0 From: "Connor Kuehl" To: "Miroslav Rezanina" , Subject: Re: [PATCH] Fix libpmem configuration option Date: Wed, 07 Jul 2021 17:22:43 -0700 Message-Id: In-Reply-To: <20210707075144.82717-1-mrezanin@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ckuehl@redhat.com X-Mimecast-Spam-Score: 1 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Received-SPF: pass client-ip=216.205.24.124; envelope-from=ckuehl@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.439, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed Jul 7, 2021 at 12:51 AM PDT, Miroslav Rezanina wrote: > For some reason, libpmem option setting was set to work in an opposite > way (--enable-libpmem disabled it and vice versa). Fixing this so > configuration works properly. > > Signed-off-by: Miroslav Rezanina > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 7994bdee92..ffa93cc5fd 100755 > --- a/configure > +++ b/configure > @@ -1501,9 +1501,9 @@ for opt do > ;; > --disable-debug-mutex) debug_mutex=3Dno > ;; > - --enable-libpmem) libpmem=3Ddisabled > + --enable-libpmem) libpmem=3D"enabled" > ;; > - --disable-libpmem) libpmem=3Denabled > + --disable-libpmem) libpmem=3D"disabled" > ;; > --enable-xkbcommon) xkbcommon=3D"enabled" > ;; > -- > 2.27.0 Good catch. Reviewed-by: Connor Kuehl or Tested-by: Connor Kuehl