All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: Romain Naour <romain.naour@gmail.com>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/efl: fix build failure with eeze disabled
Date: Tue, 1 Feb 2022 23:02:04 +0100	[thread overview]
Message-ID: <CD04B430-5777-49D1-85BA-BB174708E3C8@benettiengineering.com> (raw)
In-Reply-To: <168006d0-d098-07e2-7203-489d7573a3ec@mind.be>

Hi Arnout,

> Il giorno 1 feb 2022, alle ore 22:53, Arnout Vandecappelle <arnout@mind.be> ha scritto:
> 
> 
> 
>> On 24/01/2022 11:09, Giulio Benetti wrote:
>> Elput depends on eeze, so if we disable eeze we also need to disable elput
>> by setting the option "input" to false.
>> Fixes:
>> https://bugs.busybox.net/show_bug.cgi?id=14531
> 
> There are two other patches that somehow deal with this issue [1][2] in addition to this one [3].
> 
> Could someone choose between the and mark the rest as Superseded in patchwork?

Fabrice commented on mine that mine was better.
Then the Romain one came out few days ago and I can tell his one is better.

So I would go for the Romain patch.

I set mine as superseded and Fabrice can do the before.

Best regards
Giulio

> 
> 
> Regards,
> Arnout
> 
> [1] https://patchwork.ozlabs.org/project/buildroot/patch/20211230221904.3064022-1-fontaine.fabrice@gmail.com/
> [2] https://patchwork.ozlabs.org/project/buildroot/patch/20220129224651.1282263-4-romain.naour@gmail.com/
> [3] https://patchwork.ozlabs.org/project/buildroot/patch/20220124100920.3005564-1-giulio.benetti@benettiengineering.com/
> 
> 
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>  package/efl/efl.mk | 2 ++
>>  1 file changed, 2 insertions(+)
>> diff --git a/package/efl/efl.mk b/package/efl/efl.mk
>> index ed0a8acc1d..c93961475d 100644
>> --- a/package/efl/efl.mk
>> +++ b/package/efl/efl.mk
>> @@ -65,6 +65,8 @@ EFL_DEPENDENCIES += udev
>>  EFL_CONF_OPTS += -Deeze=true
>>  else
>>  EFL_CONF_OPTS += -Deeze=false
>> +# input(elput) requires eeze, so disable it accordingly
>> +EFL_CONF_OPTS += -Dinput=false
>>  endif
>>    ifeq ($(BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT),y)
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-02-01 22:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 10:09 [Buildroot] [PATCH] package/efl: fix build failure with eeze disabled Giulio Benetti
2022-02-01 21:53 ` Arnout Vandecappelle
2022-02-01 22:02   ` Giulio Benetti [this message]
2022-02-01 22:04     ` Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CD04B430-5777-49D1-85BA-BB174708E3C8@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.