From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Campbell Subject: Re: [PATCH] eal/linuxapp: Add parameter to specify master lcore id Date: Mon, 3 Nov 2014 13:02:08 -0400 Message-ID: References: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu> <53CD3E26.1060708@neclab.eu> <7F861DC0615E0C47A872E6F3C5FCDDBD01161242@BPXM14GP.gisp.nec.co.jp> <10116389.N4VFaZKECM@xps13> <7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp> <53CFA637.1090706@neclab.eu> Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Simon Kuenzer Return-path: In-Reply-To: <53CFA637.1090706-kcmmt4fgdiuHXe+LvDLADg@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Simon, Thanks for the patch, this will be useful for us. I responded = separately to your original post with one suggestion. Our application currently assumes that DPDK will assign the first bit = set in the coremask to the master lcore. As far as I can tell, this is = hard-coded as of 1.7.1. But we would like the ability for our = application to specify any bit from the coremask to serve as the master = lcore. I don=E2=80=99t see any compatibility issues with this. Existing = applications should behave as before. Thomas, could this be accepted for the 1.8 release? Or will that only = happen if the BSD side can be patched as well? -Aaron > On Jul 23, 2014, at 9:10 AM, Simon Kuenzer = wrote: >=20 > Hi all, >=20 > the only issue I could imagine is that current DPDK applications are > utilizing the implicit assumption that the master lcore is always set = to > the first available lcore. I would consider this as a "bug" in the > application because it sets up its worker threads not "properly". >=20 > However, as far I could check it, the DPDK framework seems to cope = with > it correctly. > It would be nice if somebody else could confirm my statement. >=20 > Thanks, >=20 > Simon >=20 > On 23.07.2014 10:53, Hiroshi Shimamoto wrote: >> Hi, >>=20 >>> Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to = specify master lcore id >>>=20 >>> Hi Hiroshi, >>>=20 >>> 2014-07-22 23:40, Hiroshi Shimamoto: >>>> does anyone have interest in this functionality? >>>>=20 >>>> I think this is important and useful. >>>> Since we should care about core assignment to get high performance >>>> and the master lcore thread is special in DPDK, we will want to >>>> assign the master to the target core. >>>> For example, with hyperthreading I'd like to make a pair of packet >>>> processing threads into one physical core and separate the master >>>> thread which does some management. >>>=20 >>> Thank you for showing your interest. >>> Does it mean you carefully reviewed this patch? In this case, I'd = appreciate >>> a note "Reviewed-by:". >>=20 >> Not yet deeply, wait a bit, we're testing this patch in our = application. >> Will report if it works fine. >>=20 >> By the way, we should add the same code into the BSD code, right? >>=20 >> thanks, >> Hiroshi >>=20 >>>=20 >>> Thanks >>> -- >>> Thomas >=20