From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH v4 1/8] hvmloader: Remove all 64-bit print
	arguments
Date: Fri, 21 Jun 2013 12:20:18 +0100
Message-ID: <CDE9F582.2A831%keir.xen@gmail.com>
References: <20932.12167.39614.419035@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20932.12167.39614.419035@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>
Cc: Hanweidong <hanweidong@huawei.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 21/06/2013 11:48, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:

> George Dunlap writes ("[PATCH v4 1/8] hvmloader: Remove all 64-bit print
> arguments"):
>> The printf() available to hvmloader does not handle 64-bit data types;
>> manually break them down as two 32-bit strings.
>> 
>> v4:
>>  - Make macros for the requisite format and bit shifting
> 
> This is an improvement.
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Acked-by: Keir Fraser <keir@xen.org>

I like it because it makes it easy to go implement %llx properly later. I
think it's dumb we're not doing that now to be honest, we have code in Xen
that could be pinched.

 -- Keir