From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tomoki.sekiyama@hds.com>) id 1UtiQG-00020U-AC
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:02:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tomoki.sekiyama@hds.com>) id 1UtiQ9-0002Bc-Fy
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:01:56 -0400
Received: from usindpps05.hds.com ([207.126.252.18]:59554)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tomoki.sekiyama@hds.com>) id 1UtiQ9-0002BN-AO
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:01:49 -0400
From: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Date: Mon, 1 Jul 2013 17:59:40 +0000
Message-ID: <CDF7238B.35F7%Tomoki.Sekiyama@hds.com>
In-Reply-To: <51D19733.4040107@redhat.com>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <90993DD436EC684390ACE1AB252C434E@hds.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v4 09/10] qemu-ga: install Windows VSS
 provider on `qemu-ga -s install'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "libaiqing@huawei.com" <libaiqing@huawei.com>, "mdroth@linux.vnet.ibm.com" <mdroth@linux.vnet.ibm.com>, "stefanha@gmail.com" <stefanha@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "lcapitulino@redhat.com" <lcapitulino@redhat.com>, "vrozenfe@redhat.com" <vrozenfe@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, Seiji Aguchi <seiji.aguchi@hds.com>, "areis@redhat.com" <areis@redhat.com>

On 7/1/13 10:50 , "Laszlo Ersek" <lersek@redhat.com> wrote:

>On 06/06/13 17:06, Tomoki Sekiyama wrote:
>>+#ifdef HAS_VSS_SDK
>> +                if (FAILED(COMRegister())) {
>> +                    return EXIT_FAILURE;
>> +                }
>
>COMRegister() seems to print error messages on failure, OK.
>
>> +#endif
>>                  return ga_install_service(path, log_filepath,
>>fixed_state_dir);
>
>Shouldn't you call COMUnregister() if ga_install_service() fails?
>Otherwise we might end up with a half-installed service (COM app catalog
>entry for VSS provider: yes, VSS provider DLL: yes, VSS client / qemu-ga
>service: no).

Agreed. I will fix this.

Thanks,
Tomoki Sekiyama