From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 72F05E00444 for ; Fri, 14 Feb 2014 07:12:04 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 14 Feb 2014 07:12:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,845,1384329600"; d="scan'208";a="475261612" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 14 Feb 2014 07:12:02 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.96]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0123.003; Fri, 14 Feb 2014 15:11:59 +0000 From: "Barros Pena, Belen" To: "Reyna, David L (Wind River)" , "Damian, Alexandru" Thread-Topic: review request for configure details page Thread-Index: Ac8pVTipvr/OHTyCSgC2T6rxfhlFdAAQeHsA Date: Fri, 14 Feb 2014 15:11:59 +0000 Message-ID: References: <5E53D14CE4667A45B9A06760DE5D13D055DC6CC6@ALA-MBB.corp.ad.wrs.com> In-Reply-To: <5E53D14CE4667A45B9A06760DE5D13D055DC6CC6@ALA-MBB.corp.ad.wrs.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.237.224.31] MIME-Version: 1.0 Cc: "toaster@yoctoproject.org" Subject: Re: review request for configure details page X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Feb 2014 15:12:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable On 14/02/2014 09:19, "Reyna, David" wrote: >Hi Belen and Alex, >=20 >I have the configuration page ready for review at: >=B3dreyna/configure-detail-view=B2 >=20 >Implementation Notes: >=20 >* In the file list pop-up dialog, I truncate the variable=B9s value to 200 >characters max. > >=20 >The reason is that I discovered for variables (like =B3BBINCLUDE=B2) with >very long values, the pop-up is in fact unable by design to scroll to the >end, to show the file list. I think that 200 characters give the right >idea, and the result looks consistent > with the more normal pop-ups. >=20 >* I have the file filters working for each of the indicated categories. >=20 >I will note that in my examinations that there were a few file types that >were not covered by the existing categories, and I wondered if you were >ok that. >=20 > poky/meta/classes/* > poky/bitbake/lib/bb/* Yes, you are right: the configuration file filters don't cover every single configuration file that exists. They are an attempt to categorise configuration into useful groups, but the categorisation is not exhaustive.=20 Hopefully search will help address the classification gaps. For example, you can search for poky/bitbake/lib/bb/ and that will return all the variables that are set in files inside that directory (for example, in cooker.py, or data_smart.py). >=20 >* I have the filter for the descriptions. >=20 >I ended on filtering on the presence of a space character, because I >could not find an appropriate alternate field lookup. I suppose I could >try a regex test. >=20 >* I implemented the file list such the last file is the one shown. >=20 >I was however curious if it is absolutely the case that the foreign key >select on the VariableHistory table is guaranteed to be in time order. I >did manually examine the first 100 rows and found that indeed that the >rows were in primary key sequential > order, but that is not proof. This is a very good point. Should we be looking into confirming this or creating some mechanism to collect the right sequence? >=20 >Thanks, >David >=20 >=20