All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Barros Pena, Belen" <belen.barros.pena@intel.com>
To: "Barros Pena, Belen" <belen.barros.pena@intel.com>,
	Amit Kumar Chaudhary <amit@floatingpondtech.com>,
	"toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Re: Errors and Warnings listing on the dashboard page.
Date: Wed, 26 Feb 2014 13:59:05 +0000	[thread overview]
Message-ID: <CF33A2CB.3E36F%belen.barros.pena@intel.com> (raw)
In-Reply-To: <CF33A0E6.3E35D%belen.barros.pena@intel.com>

And of course I forgot something: sorry about that.

If there are no warnings in a build, the build dashboard is showing a
warnings section saying '0 warnings'. Instead, the warnings section should
not exist when there are no warnings.

Cheers

Belén

On 26/02/2014 13:52, "Barros Pena, Belen" <belen.barros.pena@intel.com>
wrote:

>On 26/02/2014 12:13, "Amit Kumar Chaudhary" <amit@floatingpondtech.com>
>wrote:
>
>>
>>Hello, 
>>
>>
>>This is the patch I had been working on, It is complete now and works as
>>expected (as the prototype page), can you please review?
>>
>>
>>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=achaudha
>>r
>>y/errors_warning_on_builddashboard&id=1aaada41ec2129bd9bc31cc591b75f6d9bc
>>b
>>7251
>
>Hi Amit,
>
>From an interface standpoint, this is looking pretty good. I am however
>seeing some mismatch between the number of warnings and the number of
>messages shown in the warnings section. It looks like the number of
>warnings is displaying the overall number of entries in the orm_logmessage
>table. 
>
>The number of warnings should be the number of entries in the
>orm_logmessage table with level = 1. The number of errors should be the
>number of entries with level = 2.
>
>Any chance you could verify is this what's is being shown in the
>interface?
>
>Thanks!
>
>Belén
>
>
>>
>>
>>Thanks!
>>
>>
>>-- 
>>Amit Kumar Chaudhary
>>
>>
>>
>>On 24 February 2014 at 8:46:21 pm, Amit Kumar Chaudhary
>>(amit@floatingpondtech.com <mailto://amit@floatingpondtech.com>) wrote:
>>
>>Thanks Alex,
>>
>>
>>"The LogMessage table is designed to hold logs coming from the build
>>process itself²
>>
>>
>>This is the part I was trying to figure out. I have got the handle on how
>>to retrieve the messages from the table, (how those were put in there in
>>the first place is still a mystery),
>> I have added the following code to 'builddashboard(request, build_id)¹
>>function defined in toastergui/views.py
>>
>>
>>     context = {
>>             'build' : Build.objects.filter(pk=build_id)[0],
>>-            'recipecount' :
>>Recipe.objects.filter(layer_version__id__in=Layer_Version.objects.filter(
>>b
>>uild=build_id)).count()
>>+            'recipecount' :
>>Recipe.objects.filter(layer_version__id__in=Layer_Version.objects.filter(
>>b
>>uild=build_id)).count(),
>>+            'logmessages': LogMessage.objects.filter(build=build_id),
>>     }
>>     return render(request, template, context)
>>
>>
>>now I can use the logmessages in
>>toastergui/templates/builddashboard.html, using the html code I was
>>trying to re-use below. I have a patch that nearly works, I will clean
>>that up a bit and post it for giving a better picture.
>>
>>
>>Thanks for all the insights.
>>
>>
>>-- 
>>Amit Kumar Chaudhary
>>
>>
>>
>>On 20 February 2014 at 8:34:36 pm, Damian, Alexandru
>>(alexandru.damian@intel.com <mailto://alexandru.damian@intel.com>) wrote:
>>
>>Hello,
>>
>>
>>The LogMessage table is designed to hold logs coming from the build
>>process itself, and not logs that result from normal task execution.
>>It is the difference between the output displayed from the bitbake
>>command, and the output from the "make" command in a "do_compile" task.
>>
>>
>>For the latter case, we currently do not hold/save the content of such
>>log files. We do not have yet a strategy on determining what log files
>>are important, and saving everything may be
>> a prohibitive cost in terms of storage.
>>
>>
>>Hope this helps,
>>Alex
>>
>>
>>
>>On Thu, Feb 20, 2014 at 11:18 AM, Amit Kumar Chaudhary
>><amit@floatingpondtech.com> wrote:
>>
>>Hello, 
>>
>>
>>I am just beginning with the toaster and web apps in general, and I am
>>trying to add errors and warning listing to the build dashboard page, as
>>prototyped at
>>
>>
>>https://www.yoctoproject.org/toaster/build-dashboard-failed.html#errors
>>
>>
>>I am trying to re-use the following code --
>>
>>
>>
>><td>{{build.errors_no}}:{% if  build.errors_no %}{% for error in logs
>>%}{% if error.build == build %}{% if error.level == 2
>>%}<p>{{error.message}}</p>{% endif %}{% endif %}{% endfor %}{% else
>>%}None{% endif %}</td>
>>
>>
>>from 
>>~/poky-contrib/bitbake/lib/toaster/bldviewer/templates/simple_build.html.
>>
>>
>>And, I am expecting the logs, for example at
>>~/poky-contrib/build/tmp/log/cooker/qemux86/20140213120738.log
>>
>>
>>to be read via LogMessage class below
>>
>>
>>class LogMessage(models.Model):
>>    INFO = 0
>>    WARNING = 1
>>    ERROR = 2
>>
>>
>>    LOG_LEVEL = ( (INFO, "info"),
>>            (WARNING, "warn"),
>>            (ERROR, "error") )
>>
>>
>>    build = models.ForeignKey(Build)
>>    level = models.IntegerField(choices=LOG_LEVEL, default=INFO)
>>‹>    message=models.CharField(max_length=240)
>>    pathname = models.FilePathField(max_length=255, blank=True)
>>    lineno = models.IntegerField(null=True)
>>
>>
>>implemented in ~/poky-contrib/bitbake/lib/toaster/orm/models.py.
>>
>>
>>But, I can¹t seem to find the code that does it, reading from the log
>>file to the sqlite table. Could someone please point me to the files/path
>>that might contain this code, or such code for other tables.
>>
>>
>>Thanks!
>>
>>
>>
>>-- 
>>Amit Kumar Chaudhary
>>
>>
>>
>>
>>_______________________________________________
>>toaster mailing list
>>toaster@yoctoproject.org
>>https://lists.yoctoproject.org/listinfo/toaster
>>
>>
>>
>>
>>
>>
>>
>>
>>--
>>Alex Damian
>>Yocto Project
>>
>>SSG / OTC 
>>
>>
>>
>>
>>
>>
>>_______________________________________________
>>toaster mailing list
>>toaster@yoctoproject.org
>>https://lists.yoctoproject.org/listinfo/toaster
>>
>>
>>
>>
>
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster


  reply	other threads:[~2014-02-26 14:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-20 11:18 Errors and Warnings listing on the dashboard page Amit Kumar Chaudhary
2014-02-20 15:04 ` Damian, Alexandru
     [not found] ` <AK2VCmoAADYfUwYZngQa1zNKOTA>
2014-02-24 15:16   ` Amit Kumar Chaudhary
     [not found]   ` <AK+VCmoAADfjUwtlVwOu4B9x834>
2014-02-26 12:13     ` Amit Kumar Chaudhary
2014-02-26 13:52       ` Barros Pena, Belen
2014-02-26 13:59         ` Barros Pena, Belen [this message]
2014-02-25 17:22 ` Reyna, David
     [not found] ` <AK+VCmoAAKVFUwzReQybVnuHOhU>
2014-02-26  6:54   ` Amit Kumar Chaudhary
2014-02-27 12:59 Amit Kumar Chaudhary
     [not found] <ALCVCmoAAM3hUw82zAi9LHa0k0Q>
2014-03-03 15:26 ` Amit Kumar Chaudhary
2014-03-03 17:14   ` Barros Pena, Belen
     [not found]   ` <ALGVCmoAAWuHUxS5NQQjRHR7lXs>
2014-03-07 13:01     ` Amit Kumar Chaudhary
2014-03-07 13:24       ` Barros Pena, Belen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CF33A2CB.3E36F%belen.barros.pena@intel.com \
    --to=belen.barros.pena@intel.com \
    --cc=amit@floatingpondtech.com \
    --cc=toaster@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.