From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 4D3EBE00897 for ; Fri, 28 Feb 2014 02:42:59 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 28 Feb 2014 02:42:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,561,1389772800"; d="scan'208";a="491433555" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga002.jf.intel.com with ESMTP; 28 Feb 2014 02:42:58 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.177]) by IRSMSX103.ger.corp.intel.com ([169.254.3.84]) with mapi id 14.03.0123.003; Fri, 28 Feb 2014 10:42:56 +0000 From: "Barros Pena, Belen" To: "Reyna, David L (Wind River)" , "Damian, Alexandru" Thread-Topic: V4: review request for configure details page Thread-Index: Ac80GuUwRLT7CeSXSmaQpVCSIWnr4AAVvE2A Date: Fri, 28 Feb 2014 10:42:56 +0000 Message-ID: References: <5E53D14CE4667A45B9A06760DE5D13D055DD6F6D@ALA-MBB.corp.ad.wrs.com> In-Reply-To: <5E53D14CE4667A45B9A06760DE5D13D055DD6F6D@ALA-MBB.corp.ad.wrs.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.237.224.31] MIME-Version: 1.0 Cc: Paul Eggleton , "toaster@yoctoproject.org" Subject: Re: V4: review request for configure details page X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2014 10:43:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable All pretty good. Just a couple of comments below. Cheers Bel=E9n On 28/02/2014 01:08, "Reyna, David" wrote: >PENDING ISSUES: > >>Where should I map the help for variable name with patterns of the form >>"do_*" > >I sent email on this question separately. Right, didn't realise before, but those should not be part of the variables table at all. They are just coming in because they are listed in documentation.conf. Is there any way we can filter them out? > >>"My only doubts are about case 2, where >>I am not sure it makes sense to show the last file when the search string >>is found in any other file for a certain variable." > >I propose that most user searches are for variable names, so the file >column will appear to reflect the default behavior. If I do not by >default include the last file, then searching for variable names will >_always_ result in the file column becoming empty (expect by >coincidence), which does not look like the normal behavior for the page. > >It may only look odd if you do a search for example for "conf/bitbake", >where you would get all of the matches _plus_ the last file. Given the >downside in the previous and more common use case, I think that this >little bit of extra information is worth it. Agreed. Thanks for all the work in refining the search behaviour: this is great stuff :)