From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51326)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dmitry@daynix.com>) id 1btoWN-0000c7-Rp
	for qemu-devel@nongnu.org; Tue, 11 Oct 2016 00:18:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dmitry@daynix.com>) id 1btoWJ-000713-CA
	for qemu-devel@nongnu.org; Tue, 11 Oct 2016 00:18:30 -0400
Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:34634)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dmitry@daynix.com>) id 1btoWJ-00070I-23
	for qemu-devel@nongnu.org; Tue, 11 Oct 2016 00:18:27 -0400
Received: by mail-lf0-x242.google.com with SMTP id p80so1465525lfp.1
	for <qemu-devel@nongnu.org>; Mon, 10 Oct 2016 21:18:26 -0700 (PDT)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (1.0)
From: Dmitry Fleytman <dmitry@daynix.com>
In-Reply-To: <57FC5DFE.4070708@cn.fujitsu.com>
Date: Tue, 11 Oct 2016 07:18:23 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <CF3873C8-01E0-41B8-AEB1-8068382FBFE1@daynix.com>
References: <1473839464-8670-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<1473839464-8670-9-git-send-email-caoj.fnst@cn.fujitsu.com>
	<87k2du7oo7.fsf@dusky.pond.sub.org>
	<57EE0CFB.4070002@cn.fujitsu.com>
	<878tu9ttzv.fsf@dusky.pond.sub.org>
	<017DDFF7-F80A-4C07-B533-4BEBEEA641CE@daynix.com>
	<57FC5DFE.4070708@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v3 8/8] vmxnet3: remove unnecessary
 internal msix state flag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: Markus Armbruster <armbru@redhat.com>, Marcel Apfelbaum <marcel@redhat.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>


> On 11 Oct 2016, at 6:35, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
>=20
>=20
>=20
>> On 10/06/2016 05:39 PM, Dmitry Fleytman wrote:
>>=20
>=20
>>=20
>> Hello,
>>=20
>> Yes, from what I see, this call is wrong and leads to
>> reference leaks on device unload at migration target.
>> It should be removed.
>>=20
>> Best regards,
>> Dmitry
>>=20
>=20
> Hi,Dmitry
>=20
>    =46rom what I saw, current code will call msix_vector_use twice on migr=
ation target, which is wrong. I am not quite follow you on "reference leak",=
 are you saying the same thing as me? if not, could you help to explain more=
?

Hello,

Yes, I meant exactly this :)

msix_vector_use() increments vector reference counter each time it is called=
,
so device holds two references to used vectors after migration.

The second reference will be leaked because there is no second call to msix_=
vector_unuse() on unload.

Best Regards,
Dmitry

>=20
> --=20
> Yours Sincerely,
>=20
> Cao jin
>=20
>=20