From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <belen.barros.pena@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id CB244E00B93
	for <toaster@yoctoproject.org>; Thu, 27 Mar 2014 04:51:34 -0700 (PDT)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
	by orsmga102.jf.intel.com with ESMTP; 27 Mar 2014 04:46:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,742,1389772800"; d="scan'208";a="481322102"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
	by orsmga001.jf.intel.com with ESMTP; 27 Mar 2014 04:51:33 -0700
Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by
	IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server
	(TLS) id 14.3.123.3; Thu, 27 Mar 2014 11:48:02 +0000
Received: from irsmsx106.ger.corp.intel.com ([169.254.8.58]) by
	IRSMSX151.ger.corp.intel.com ([163.33.192.59]) with mapi id
	14.03.0123.003; Thu, 27 Mar 2014 11:48:02 +0000
From: "Barros Pena, Belen" <belen.barros.pena@intel.com>
To: "Reyna, David L (Wind River)" <david.reyna@windriver.com>, "Damian,
	Alexandru" <alexandru.damian@intel.com>
Thread-Topic: [review-request] Bug #5920 "Secondary sorting criteria not
	working"
Thread-Index: Ac9JS2DJBDisi9lHTgeAlQkWQfGzZgAZwW6A
Date: Thu, 27 Mar 2014 11:48:01 +0000
Message-ID: <CF59C01A.40AA2%belen.barros.pena@intel.com>
References: <5E53D14CE4667A45B9A06760DE5D13D055E57C69@ALA-MBA.corp.ad.wrs.com>
In-Reply-To: <5E53D14CE4667A45B9A06760DE5D13D055E57C69@ALA-MBA.corp.ad.wrs.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: Microsoft-MacOutlook/14.3.9.131030
x-originating-ip: [10.237.224.30]
MIME-Version: 1.0
Cc: "toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Re: [review-request] Bug #5920 "Secondary sorting criteria not working"
X-BeenThere: toaster@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Web based interface for BitBake <toaster.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/toaster>
List-Post: <mailto:toaster@yoctoproject.org>
List-Help: <mailto:toaster-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Mar 2014 11:51:42 -0000
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <AE7EFD9B71C19944A9E5489DFDBE483A@intel.com>
Content-Transfer-Encoding: quoted-printable

On 26/03/2014 23:34, "Reyna, David" <david.reyna@windriver.com> wrote:

>Hi Belen,
>=20
>Here is my branch for 5920 =B3Secondary sorting criteria not working=B2. I=
t
>will add a secondary sort for all tables when the current sort is a
>different column that the table=B9s respective default sort.
>=20
>The branch is here: dreyna/secondary_sort_5920

I am getting an error in the builds page with this branch:

Invalid filter: 'get_dict_value'

Full trace below:

Environment:


Request Method: GET
Request URL:=20
http://localhost:8000/gui/builds/?count=3D10&orderby=3Dcompleted_on%3A-&pag=
e=3D1

Django Version: 1.5
Python Version: 2.7.3
Installed Applications:
('django.contrib.staticfiles',
 'django.contrib.humanize',
 'orm',
 'toastermain',
 'toastergui',
 'bldviewer',
 'south')
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware')


Template error:
In template=20
/home/yocto/poky/bitbake/lib/toaster/toastergui/templates/build.html,
error at line 96
   Invalid filter: 'get_dict_value'
   86 :             <td class=3D"target">{% for t in build.target_set.all %=
}
<a href=3D"{% url "builddashboard" build.id <http://build.id/> %}">
{{t.target}} </a> <br />{% endfor %}</td>


   87 :             <td class=3D"machine"><a href=3D"{% url "builddashboard=
"
build.id <http://build.id/> %}">{{build.machine}}</a></td>


   88 :             <td class=3D"started_on"><a href=3D"{% url
"builddashboard" build.id <http://build.id/>
%}">{{build.started_on|date:"d/m/y H:i"}}</a></td>


   89 :             <td class=3D"completed_on"><a href=3D"{% url
"builddashboard" build.id <http://build.id/>
%}">{{build.completed_on|date:"d/m/y H:i"}}</a></td>


   90 :             <td class=3D"failed_tasks error">{% query
build.task_build outcome=3D4 order__gt=3D0 as exectask%}{% if exectask.coun=
t
=3D=3D 1 %}<a href=3D"{% url "task" build.id <http://build.id/> exectask.0.=
id
<http://exectask.0.id/> %}">{{exectask.0.recipe.name
<http://exectask.0.recipe.name/>}}.{{exectask.0.task_name}}</a>{% elif
exectask.count > 1%}<a href=3D"{% url "tasks" build.id <http://build.id/>
%}?filter=3Doutcome%3A4">{{exectask.count}}</a>{%endif%}</td>


   91 :             <td class=3D"errors_no">{% if  build.errors_no %}<a
class=3D"errors_no error" href=3D"{% url "builddashboard" build.id
<http://build.id/>%}#errors">{{build.errors_no}}
error{{build.errors_no|pluralize}}</a>{%endif%}</td>


   92 :             <td class=3D"warnings_no">{% if  build.warnings_no %}<a
class=3D"warnings_no warning" href=3D"{% url "builddashboard" build.id
<http://build.id/> %}#warnings">{{build.warnings_no}}
warning{{build.warnings_no|pluralize}}</a>{%endif%}</td>


   93 :             <td class=3D"time"><a href=3D"{% url "buildtime" build.=
id
<http://build.id/> %}">{{build.timespent|sectohms}}</a></td>


   94 :             <td class=3D"log">{{build.cooker_log_path}}</td>


   95 :             <td class=3D"output">


   96 :                {% if build.outcome =3D=3D build.SUCCEEDED %}


   97 :               <a href=3D"{%url "builddashboard" build.id
<http://build.id/>%}#images">{{fstypes|get_dict_value:build.id
<http://build.id/>}}</a>


   98 :               {% endif %}


   99 :             </td>


   100 :         </tr>


   101 :=20


   102 :         {% endfor %}


   103 :=20


   104 :=20


   105 : {% include "basetable_bottom.html" %}


   106 :=20


Traceback:
File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py"
in get_response
  115.                         response =3D callback(request,
*callback_args, **callback_kwargs)
File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in builds
  376.     return render(request, template, context)
File "/usr/local/lib/python2.7/dist-packages/django/shortcuts/__init__.py"
in render
  53.     return HttpResponse(loader.render_to_string(*args, **kwargs),
File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py" in
render_to_string
  170.         t =3D get_template(template_name)
File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py" in
get_template
  146.     template, origin =3D find_template(template_name)
File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py" in
find_template
  135.             source, display_name =3D loader(name, dirs)
File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py" in
__call__
  43.         return self.load_template(template_name, template_dirs)
File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py" in
load_template
  49.             template =3D get_template_from_string(source, origin,
template_name)
File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py" in
get_template_from_string
  157.     return Template(source, origin, name)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
__init__
  125.         self.nodelist =3D compile_string(template_string, origin)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
compile_string
  153.     return parser.parse()
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
parse
  274.                     compiled_result =3D compile_func(self, token)
File=20
"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py" in
do_extends
  215.     nodelist =3D parser.parse()
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
parse
  274.                     compiled_result =3D compile_func(self, token)
File=20
"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py" in
do_block
  190.     nodelist =3D parser.parse(('endblock',))
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
parse
  274.                     compiled_result =3D compile_func(self, token)
File=20
"/usr/local/lib/python2.7/dist-packages/django/template/defaulttags.py" in
do_if
  917.         nodelist =3D parser.parse(('endif',))
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
parse
  274.                     compiled_result =3D compile_func(self, token)
File=20
"/usr/local/lib/python2.7/dist-packages/django/template/defaulttags.py" in
do_for
  767.     nodelist_loop =3D parser.parse(('empty', 'endfor',))
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
parse
  274.                     compiled_result =3D compile_func(self, token)
File=20
"/usr/local/lib/python2.7/dist-packages/django/template/defaulttags.py" in
do_if
  903.     nodelist =3D parser.parse(('elif', 'else', 'endif'))
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
parse
  253.                 filter_expression =3D
self.compile_filter(token.contents)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
compile_filter
  353.         return FilterExpression(token, self)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
__init__
  564.                 filter_func =3D parser.find_filter(filter_name)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
find_filter
  359.             raise TemplateSyntaxError("Invalid filter: '%s'" %
filter_name)

Exception Type: TemplateSyntaxError at /gui/builds/
Exception Value: Invalid filter: 'get_dict_value'



>=20
>It depends on these two commits before it:
>  6012:
>f648d5018f7d3ae6eb81f0a05bdbbfe51080eece =B3Duplicate search results
>returned in the build page=B2
>  5947:fd12d8aad22eadee20723a1b5323035e0ac47742 =B3Replace fstypes lookup
>on main build page=B2
>=20
>Thanks,
>David
>=20
>=20
>=20
>=20