RE: ibv_post_send/recv kernel path optimizations

["Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

> +	qp = idr_read_qp(cmd.qp_handle, file->ucontext);
> +	if (!qp)
> +		goto out_raw_qp;
> +
> +	if (qp->qp_type == IB_QPT_RAW_ETH) {
> +		resp.bad_wr = 0;
> +		ret = qp->device->post_send(qp, NULL, NULL);

This looks odd to me and can definitely confuse someone reading the code.  It adds assumptions to uverbs about the underlying driver implementation and ties that to the QP type.  I don't know if it makes more sense to key off something in the cmd or define some other property of the QP, but the NULL parameters into post_send are non-intuitive.
 
> +		if (ret)
> +			resp.bad_wr = cmd.wr_count;

Is this always the case?

- Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html