All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marciniszyn, Mike" <mike.marciniszyn@cornelisnetworks.com>
To: Guo Zhi <qtxuning1999@sjtu.edu.cn>,
	"Dalessandro, Dennis" <dennis.dalessandro@cornelisnetworks.com>,
	"dledford@redhat.com" <dledford@redhat.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c
Date: Mon, 27 Sep 2021 13:05:07 +0000	[thread overview]
Message-ID: <CH0PR01MB7153E9B96065CEB8308816B2F2A79@CH0PR01MB7153.prod.exchangelabs.com> (raw)
In-Reply-To: <20210922134857.619602-1-qtxuning1999@sjtu.edu.cn>

> Subject: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c
> 
> Pointers should be printed with %p or %px rather than cast to (unsigned long
> long) and printed with %llx.
> Change %llx to %p to print the pointer.
> 
> Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn>
> ---
>  drivers/infiniband/hw/hfi1/ipoib_tx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/ipoib_tx.c
> b/drivers/infiniband/hw/hfi1/ipoib_tx.c
> index e74ddbe4658..15b0cb0f363 100644
> --- a/drivers/infiniband/hw/hfi1/ipoib_tx.c
> +++ b/drivers/infiniband/hw/hfi1/ipoib_tx.c
> @@ -876,14 +876,14 @@ void hfi1_ipoib_tx_timeout(struct net_device
> *dev, unsigned int q)
>  	struct hfi1_ipoib_txq *txq = &priv->txqs[q];
>  	u64 completed = atomic64_read(&txq->complete_txreqs);
> 
> -	dd_dev_info(priv->dd, "timeout txq %llx q %u stopped %u stops %d
> no_desc %d ring_full %d\n",
> -		    (unsigned long long)txq, q,
> +	dd_dev_info(priv->dd, "timeout txq %p q %u stopped %u stops %d
> no_desc %d ring_full %d\n",
> +		    txq, q,
>  		    __netif_subqueue_stopped(dev, txq->q_idx),
>  		    atomic_read(&txq->stops),
>  		    atomic_read(&txq->no_desc),
>  		    atomic_read(&txq->ring_full));
> -	dd_dev_info(priv->dd, "sde %llx engine %u\n",
> -		    (unsigned long long)txq->sde,
> +	dd_dev_info(priv->dd, "sde %p engine %u\n",
> +		    txq->sde,
>  		    txq->sde ? txq->sde->this_idx : 0);
>  	dd_dev_info(priv->dd, "flow %x\n", txq->flow.as_int);
>  	dd_dev_info(priv->dd, "sent %llu completed %llu used %llu\n",
> --
> 2.33.0

This patch has the correct case, but is not noted as a V2.

Jason, this one is ok.

Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>

  parent reply	other threads:[~2021-09-27 13:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 13:48 [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c Guo Zhi
2021-09-22 17:51 ` Marciniszyn, Mike
2021-09-22 18:05   ` Bart Van Assche
2021-09-23  6:45     ` Leon Romanovsky
2021-09-23 11:04       ` Marciniszyn, Mike
2021-09-23 11:44         ` Leon Romanovsky
2021-09-23 12:18           ` Marciniszyn, Mike
2021-09-24  2:46       ` Bart Van Assche
2021-09-24 14:43         ` Marciniszyn, Mike
2021-09-25  0:20           ` Guo Zhi
2021-09-23 11:03     ` Marciniszyn, Mike
2021-09-23 13:15       ` Jason Gunthorpe
2021-09-23  2:03   ` 郭志
2021-09-23 12:51   ` 郭志
2021-09-27 13:05 ` Marciniszyn, Mike [this message]
2021-09-27 17:42 ` Jason Gunthorpe
  -- strict thread matches above, loose matches on Subject: below --
2021-09-22 12:33 Guo Zhi
2021-09-22 12:37 ` Dennis Dalessandro
2021-09-24 14:46 ` Marciniszyn, Mike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH0PR01MB7153E9B96065CEB8308816B2F2A79@CH0PR01MB7153.prod.exchangelabs.com \
    --to=mike.marciniszyn@cornelisnetworks.com \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=dledford@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=qtxuning1999@sjtu.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.