From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F98DC433F5 for ; Tue, 8 Mar 2022 10:23:52 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA4CB4068E; Tue, 8 Mar 2022 11:23:51 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2066.outbound.protection.outlook.com [40.107.223.66]) by mails.dpdk.org (Postfix) with ESMTP id DE14A4068B for ; Tue, 8 Mar 2022 11:23:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CnKbboryqn8o1ixxkphoNk9J0QzgSZUm3MbX2/2CpWPh28MvOxpGLR8BtPUwsNHUCXOGAXnvTHI19WYumwf+zkYv0+fzORMjTwM+UMA/G3dHmR4vEEIOj88gacS7jJViiiW48dLmraoPcgB+jVSNYPiMp58n6WXwlvqNHJvKwtSrQs0pYCwPjDhyA4y87SXhBk5jsFIJRzHBU2/YBaWkwyRFE3PVHGYyNdF/xvkN37FTy+x2UsCXQ+Sm3ywC/No5dGQRfKw2uMCtrIrdCxhzQ4vzW76WYnj6ak5vmpRk0OMGwQNyHO5mgNGZBoQhJQ4pPXm/bH6enwIUB20BpkIfEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FqGFFBMBWuwafISREjp+2jS0rvdiXPK/vm39qvAzico=; b=QPm2eyVrMm81zE/9isMcOJqigt2JDjmRX5LBOfTk49hUYLtx0OvBL1v8Av3N4ysRaOZ34KoFIJnNFvfHAr5sGW7tFvIkU4/j2XxR+8EM2Gzgo+5pbW6h9jg8waUzyuNpoTI1v/kcoRzY7aMGLzVMaKZ+fx0koaWbh+OHB6Hm5fe3NqIRODANulfYNOA6XJcVU2niQnyloedJccVbk3xYE8iyapVTYS3qaH1+YLeiDnRt8VswMAJbzVUYv0La9rKSuSPHAzzTCHx/Mj1Ye2rfVbhrME03D+gcHjpHy6VoAbDsLaCtxIC4myItRT8/iB5rhTzjySYgMg1BP70zdIdnAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FqGFFBMBWuwafISREjp+2jS0rvdiXPK/vm39qvAzico=; b=g8d2teyGjgHSzP4Wf59yVFHqI8eGThYT9n4eiAe6dss2NSocR+tuoMXD7yTzUXZ0973hmIFXnvyjvApOay0qEKx/YLW97t6AldofCVPA3l5TtuwZduOAaWiSC9YcI7GYtxlZUPjoYJ6/6LgrRL+Uuqe52CZ/efnO2YD6jM5UUPrHE5U5cw+tZ6W0/thgPSsPbYWvA37dgXek96EU7aOYy9YzGa43KZ1YalEv3zBtDgmD4n0IlXD7TaIJ/BCLad1JHcSBidSgarB6jKr6LlyfO61F8XvXz25DKJGFg7Atc0l9ntu7fS6TjfyQGmCC16DIPeQlg0WJkQlT78vvPueZ2Q== Received: from CH0PR12MB5386.namprd12.prod.outlook.com (2603:10b6:610:d5::5) by BYAPR12MB3351.namprd12.prod.outlook.com (2603:10b6:a03:de::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.16; Tue, 8 Mar 2022 10:23:46 +0000 Received: from CH0PR12MB5386.namprd12.prod.outlook.com ([fe80::6170:6f26:32a0:9640]) by CH0PR12MB5386.namprd12.prod.outlook.com ([fe80::6170:6f26:32a0:9640%3]) with mapi id 15.20.5038.027; Tue, 8 Mar 2022 10:23:46 +0000 From: Matan Azrad To: Thinh Tran , "dev@dpdk.org" CC: "drc@linux.vnet.ibm.com" Subject: RE: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl Thread-Topic: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl Thread-Index: AQHYMnYlwA60wGCo0Uu58oUaEFCi0ay1SBHA Date: Tue, 8 Mar 2022 10:23:45 +0000 Message-ID: References: <20220307225256.172328-1-thinhtr@linux.vnet.ibm.com> In-Reply-To: <20220307225256.172328-1-thinhtr@linux.vnet.ibm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fdfe685b-f6da-4c6b-2248-08da00edba61 x-ms-traffictypediagnostic: BYAPR12MB3351:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QgJ78Nn7MXOJRWqZDwBFOH8ioNeEGVeu7icz/CgP1LT5auY+Gt5wIpenKOOTVsUNx5vFTyZ8c44/4PaBLXH/yY0Dr+bvYlmofFtIybqWJkuRApGZ8ASqsA0QwXxmItSuJWDZWttMHbXi3T50RotpULqr8slWdocKNJxixLzab9kcO0rrPUBgZBMhFrKussbGL5URZqs1SQZCrGU3nvrCmiJ5BFxpTgQTI3InNBGBOrZ1FLbxorGW6NiCXfIRIkEHjLdPaKjF7QCw3UI6R7ZL/dh1oOORZoMvmh4/v0QSqf5DnOKkvOU9XMfmCIlZVSFuTExkgMMX2sVDcdYKBNsDaGrOCsxA0InJG9E+5hkEgb11p4xctiU2bQihNP/eQB8nkGKxdxydULNWr65NQY4kpsneRPkxME7OJ0eNaWcNzq88NDr/vTWY/6hpkGAYoaaRVmVTTnxEw2tVb7e0dyd7yirEZlhm/XU8g7pupfy8+yU3KHspShRPdCZu+dGfU0vO0zcNuIqv4gjNNaYE/ZUfUoYBEg29ugEUenDChi/o77lTgDI1a3capQp6bMw7RCNE9MVvMuRIL4lo3xlOAUkw09c0MCtT+Uku/gdt9MMtcqJ39j0CorCovBJ5DPLbQAEg8J4YkNZTagQsSowll2aGMFJ3oU9NnaHm5OZdGccZAuWgFiT6HONoGQxon73VA5CscR+B7fociAZO5OsU+GUEsg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR12MB5386.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(52536014)(5660300002)(4326008)(64756008)(66446008)(66476007)(66556008)(66946007)(8676002)(76116006)(33656002)(2906002)(8936002)(110136005)(38100700002)(122000001)(316002)(186003)(38070700005)(508600001)(86362001)(55016003)(71200400001)(6506007)(7696005)(9686003)(26005)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TMuNQK4XAFejHjnPjtAkzbjT5zBxY+8sykjC6UiYHeHix0OChbDyMflX2rCv?= =?us-ascii?Q?+m501J6uu5D4gY4hX0ShoxPlQxaqjhcybeGes//Sw8HXl/0en8hZvGevpZXC?= =?us-ascii?Q?obpo5ayu+OobFN2mfJgvHxuicEDcBzP2JeiMHzkBuFI0XzDFvctkIPPtP/V8?= =?us-ascii?Q?Gr8ivaX+UdOqFjOL7e7k6dNGy3qdkCvytD22eOuBAJlzJuKPeMNJAnFuJBGO?= =?us-ascii?Q?JwX23TAwGPpwGkmePuthFiJa0VxHS1vF1Evfbrfe87WNrt/OTmUogxd1ZG45?= =?us-ascii?Q?BcAvHpvRJfBKR7wK1oDFJNDnpnMrLmvMGTCJIfGjFj1vDI8crD5E+KhPc2qQ?= =?us-ascii?Q?yDjxzFXiIF29VXE4QSUPdAUAKozkOUDIpEOkAFIRl6jzElr2kL0EDXh3yZvs?= =?us-ascii?Q?dB5Vamh4PoL5khTwS0t5wgrrSPn3lPlcnkcdvuXY7CRHFjTGHhGTjvUZh7no?= =?us-ascii?Q?mx61tgQsYuIuRYWkkHdMrcueiQnZ2/IWnBEnfhiC93Ncb9juiK8j2kfG4CDV?= =?us-ascii?Q?T8uYaO1WuewIvnZFSThn6YtEHWI0N4AAuMMAXo1pyVD2+Fi9E5KhAbRco18m?= =?us-ascii?Q?IuYSEEt6yUHbUvwTW7OdkuXnCMyxAU6XhVsoD7lDHbfkmunBD0VC46eK9GMM?= =?us-ascii?Q?v1gk7okgjOCxtXqkCVMnErZedxw8E40vEX/Q5iQl80n8Ogc2qsrnWGnzwQYQ?= =?us-ascii?Q?unpW6YSNJfKHQpPIahaUQrgc72FFxxCpnCgkpbbEMFhEc6rwFNKsxRdEFxYn?= =?us-ascii?Q?YXE/kGxPTZcRj1FXunvbxch7tdcFWfrWawLTAIIc9JoHcALVJIOqwG9Fkndo?= =?us-ascii?Q?12d08SIwOi/4sDCJUP0RaolJeKD5yq4KLEvM50flMEdPi+EeTPnaM06Dq5qq?= =?us-ascii?Q?6vE6zE3sczsUfFZdxuV27cJfLmY1Arr0WObet15KcVo5WpjkWJu0naupPZR7?= =?us-ascii?Q?XIUSmkWC+Ocp1yi0GR0J+PcY43P21HavbooPX4MZLoa8s9TyO8wOJVXJS3RR?= =?us-ascii?Q?x+IaloY9zlOJgujGvG0GlRMhOZpyQ08EatNZ5bbMUW5DoYN9jkEfnSlYyoFY?= =?us-ascii?Q?DhM2xpd5bwL4she+fTQ16rs4yHtMfHwPPk2SKPNAsKykwhthvkKgUP8+a8cm?= =?us-ascii?Q?g7020wY/jYEnybjocgkvQXvDOk7yNntmqDLpmZZdzS3NMZbK7bh6Hh6+LMM0?= =?us-ascii?Q?zJSN7ajXz3dkQq7RQG4HHkqHzKB5j4IDohZLSodjSQjrvjZhTWOKWDmBKAxn?= =?us-ascii?Q?h9qWi3Vv2Y6YDoCDmrmPDnEmpa+RQeBq1ahysrtw6TOhQ/ueC/38dmydtcYs?= =?us-ascii?Q?Y8WvwvczGdr0dBRRNr4J5Y6g9EAseIHTpuH8UDdtGz3+AoqSj0GdANjJ8HGO?= =?us-ascii?Q?YXtwTp6R/C3/bXJH1bglMQ3muTJCCCEKO8hV8iQUQ27MxeqXDt5oHLaO897T?= =?us-ascii?Q?GGPTPey05gXtXMOS/4Bh02ndeaf/yUjkFJuh2ARXy2hrhIEtrFHQSUocBsfq?= =?us-ascii?Q?h/DL5KSYlGurnCSrX0/edyp6ENSiATtprvIuP5AZNuL8y2hr2A6GyT+cEe6h?= =?us-ascii?Q?W0cE6xnOSmVJM6eYgGNiNxFHPGyOEKadoe7+PzmhdYLIDD10S7VNLsWJWPnG?= =?us-ascii?Q?/Em77JoYZJSEQXPQnV+Bm7E=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5386.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdfe685b-f6da-4c6b-2248-08da00edba61 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2022 10:23:45.9430 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y3aaqgE/zO5jQ7QvnwIS5/BThyx1IrMbFEPjGjIWx2G1Y4Nc1RuY3pkOFGFNugCkiB6NzmKR0ki7Gs+77aCsrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3351 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Thinh Tran > I hit a failure during ports drop queue RQ creation when my adapters are = on CPU > socket ID 1 instead of socket ID 0: > .... > EAL: Probe PCI driver: mlx5_pci (15b3:1019) device: 0020:01:00.0 (socket = 1) > EAL: set_mempolicy failed: Invalid argument > mlx5_common: Failed to allocate memory for RQ. > mlx5_net: Port 0 drop queue RQ creation failed. > mlx5_net: Cannot create drop RX queue > mlx5_net: probe of PCI device 0020:01:00.0 aborted after encountering an > error: Success > EAL: Probe PCI driver: mlx5_pci (15b3:1019) device: 0020:01:00.1 (socket = 1) > EAL: set_mempolicy failed: Invalid argument > mlx5_common: Failed to allocate memory for RQ. > mlx5_net: Port 0 drop queue RQ creation failed. > mlx5_net: Cannot create drop RX queue > mlx5_net: probe of PCI device 0020:01:00.1 aborted after encountering an > error: Success > TELEMETRY: No legacy callbacks, legacy socket not created > testpmd: No probed ethernet devices > ... >=20 > The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before cal= ling the > mlx5_rxq_create_devx_rq_resources() which eventually calls > mlx5_devx_rq_create() with correct CPU socket ID. > Result with this patch: > ...... > EAL: Probe PCI driver: mlx5_pci (15b3:1019) device: 0020:01:00.0 (socket = 1) > EAL: Probe PCI driver: mlx5_pci (15b3:1019) device: 0020:01:00.1 (socket = 1) > TELEMETRY: No legacy callbacks, legacy socket not created Interactive-mod= e > selected ...... > Configuring Port 0 (socket 1) > Port 0: 0C:42:A1:ED:C1:20 > Configuring Port 1 (socket 1) > Port 1: 0C:42:A1:ED:C1:21 > Checking link statuses... > Done >=20 >=20 > Signed-off-by: Thinh Tran > Reviewed-by: David Christensen Acked-by: Matan Azrad