From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Date: Wed, 6 May 2020 09:04:06 +0000 Subject: [PATCH 20/36] bdinfo: sh: arc: Drop arch-specific print_bi_mem() In-Reply-To: References: <20200504231732.98778-1-sjg@chromium.org> <20200504231732.98778-12-sjg@chromium.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, > Subject: Re: [PATCH 20/36] bdinfo: sh: arc: Drop arch-specific print_bi_mem() > > On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > > > It isn't worth having arch-specific code for such minor output > > differences. In fact it is better if all archs are consistent. > > > > Drop the arch-specific code in print_bi_mem() and inline it to avoid a > > two-line function. > > > > Signed-off-by: Simon Glass > > --- > > > > cmd/bdinfo.c | 17 ++--------------- > > 1 file changed, 2 insertions(+), 15 deletions(-) I guess this entire series is available in the following tree, right? https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/tree/bd-working In that case I'm very happy with that change as well as removal of the duplicated spaghetti-code - thanks for taking care of that! Acked-by: Alexey Brodkin