From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88384C433EF for ; Fri, 25 Mar 2022 07:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240422AbiCYIA0 (ORCPT ); Fri, 25 Mar 2022 04:00:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbiCYIAZ (ORCPT ); Fri, 25 Mar 2022 04:00:25 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EC4C3DA63 for ; Fri, 25 Mar 2022 00:58:50 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id o10so13783738ejd.1 for ; Fri, 25 Mar 2022 00:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=mime-version:content-transfer-encoding:date:message-id:cc:subject :from:to:references:in-reply-to; bh=YNqe6IKQwYU1SXQAtrDZx7Ab2V139yZrlAAi/SFO/aQ=; b=uONsPRuQB+JMPTjrrZXDNX9+tYvAwUVXzuxU7B7b6xzGdgQffKhED+1WkANhvZu/3R ECVyrCWklcku038ZFfN2E+UYkMZP1NfzPToi/rt4EvREaeMbJlG3OLfQ0ee45eySZLVM teGum288u8sFE7jVV1rZP1qZvahMEitALpxe6ZVr5018nLhCEHWYAoUqyD29FZSc3z+U ssUC53eeGpYye/VY3P90BZoBjajHxl6jDRjF1FCC0r3J26XJL7oxiiro4JB31TRfPdh+ J9+w8S922rIcyzuR2lfBSIJVc6FTp0P+Buet5AZWt9j+5t8nRh7STWRNpYSgmbXUD0gP lZvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:content-transfer-encoding:date :message-id:cc:subject:from:to:references:in-reply-to; bh=YNqe6IKQwYU1SXQAtrDZx7Ab2V139yZrlAAi/SFO/aQ=; b=bW11uzIVvbdYVYMQnO7/PPMfzNgxHZmT9EHTXwr5WZ9wJPNNS8cchHQPeAOIxxLiRE llWZzIVECfqoGoT8X6QE8mzyH6Oo8oq7QFqm8zBqNFjzhPC/xF543nT0yFj+jYUsprg8 R22SaPb9EiiBG59U+yxOrnWdhEfnlTpsi9YD6S0LfdBNkfgHQRF3OkzY+YW2Cw1k8WI/ SvhPkHjww7pRsm6iMb3RwO1TGE0xPqEpXxJi6VIYcRDQi9Fqx1CbOc9qMzO0WRemZC/M 7jElKlpaz2l9cgH8vSY7ADhBmrnDcRQCROJ6KOMCVzfnv0jAfspJCplynxpcDAl8J72m XYmw== X-Gm-Message-State: AOAM53362VBWGrmgkbN4Oc2YdwXqB9sG3LlulCFyfFpYqs3yzK5BKAwz hRAQtnIFzYvOhF/VFf/PHicxfw== X-Google-Smtp-Source: ABdhPJyGmgoyqTfWdSJLcXAdfk5XkWpJmQ/J5c9pZ+zK1/fBk0F9kLpL3O6/Xqrkn+9QLuwVPVL5IA== X-Received: by 2002:a17:906:3ec9:b0:6bb:2eb9:84f with SMTP id d9-20020a1709063ec900b006bb2eb9084fmr9968528ejj.86.1648195128732; Fri, 25 Mar 2022 00:58:48 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a21-20020a170906275500b006d10c07fabesm2007178ejd.201.2022.03.25.00.58.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Mar 2022 00:58:48 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 25 Mar 2022 08:58:47 +0100 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, "Stanimir Varbanov" , "Andy Gross" , "Bjorn Andersson" , "Mauro Carvalho Chehab" , , Subject: Re: [PATCH 1/2] media: venus: hfi: Add error message for timeout error From: "Luca Weiss" To: "Luca Weiss" , References: <20220114110226.130380-1-luca.weiss@fairphone.com> In-Reply-To: <20220114110226.130380-1-luca.weiss@fairphone.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi everyone, any feedback on this patch and the following one? Regards Luca On Fri Jan 14, 2022 at 12:02 PM CET, Luca Weiss wrote: > This error can appear with wrong configuration and is difficult to find > as it just returns -ETIMEDOUT with no further message. > > Signed-off-by: Luca Weiss > --- > drivers/media/platform/qcom/venus/hfi_venus.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/medi= a/platform/qcom/venus/hfi_venus.c > index 3a75a27632fb..9a34662fea38 100644 > --- a/drivers/media/platform/qcom/venus/hfi_venus.c > +++ b/drivers/media/platform/qcom/venus/hfi_venus.c > @@ -1583,8 +1583,10 @@ static int venus_suspend_3xx(struct venus_core *co= re) > */ > ret =3D readx_poll_timeout(venus_cpu_and_video_core_idle, hdev, val, va= l, > 1500, 100 * 1500); > - if (ret) > + if (ret) { > + dev_err(dev, "wait for cpu and video core idle fail (%d)\n", ret); > return ret; > + } > =20 > ret =3D venus_prepare_power_collapse(hdev, false); > if (ret) { > --=20 > 2.34.1