From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Richard Cochran <richardcochran@gmail.com>,
Arnd Bergmann <arnd@kernel.org>
Cc: Nicolas Pitre <nico@fluxnic.net>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Kurt Kanzenbach <kurt@linutronix.de>,
"Saleem, Shiraz" <shiraz.saleem@intel.com>,
"Ertman, David M" <david.m.ertman@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies
Date: Wed, 4 Aug 2021 20:53:05 +0000 [thread overview]
Message-ID: <CO1PR11MB5089005017FE714B8A37F9B0D6F19@CO1PR11MB5089.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210803205455.GA3517@hoboy.vegasvil.org>
> -----Original Message-----
> From: Richard Cochran <richardcochran@gmail.com>
> Sent: Tuesday, August 03, 2021 1:55 PM
> To: Arnd Bergmann <arnd@kernel.org>
> Cc: Nicolas Pitre <nico@fluxnic.net>; Keller, Jacob E <jacob.e.keller@intel.com>;
> Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Jakub
> Kicinski <kuba@kernel.org>; Arnd Bergmann <arnd@arndb.de>; Kurt
> Kanzenbach <kurt@linutronix.de>; Saleem, Shiraz <shiraz.saleem@intel.com>;
> Ertman, David M <david.m.ertman@intel.com>; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK
> dependencies
>
>
> On Tue, Aug 03, 2021 at 07:00:49PM +0200, Arnd Bergmann wrote:
>
> > If you turn all those 'select' lines into 'depends on', this will work, but it's
> > not actually much different from what I'm suggesting.
>
> "depends" instead of "select" works for me. I just want it simple and clear.
>
> > Maybe we can do it
> > in two steps: first fix the build failure by replacing all the 'imply'
> > statements
> > with the correct dependencies, and then you send a patch on top that
> > turns PPS and PTP_1588_CLOCK into bool options.
>
> Sounds good.
>
> Thanks,
> Richard
Works for me too.
Thanks,
Jake
WARNING: multiple messages have this Message-ID (diff)
From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies
Date: Wed, 4 Aug 2021 20:53:05 +0000 [thread overview]
Message-ID: <CO1PR11MB5089005017FE714B8A37F9B0D6F19@CO1PR11MB5089.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210803205455.GA3517@hoboy.vegasvil.org>
> -----Original Message-----
> From: Richard Cochran <richardcochran@gmail.com>
> Sent: Tuesday, August 03, 2021 1:55 PM
> To: Arnd Bergmann <arnd@kernel.org>
> Cc: Nicolas Pitre <nico@fluxnic.net>; Keller, Jacob E <jacob.e.keller@intel.com>;
> Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Jakub
> Kicinski <kuba@kernel.org>; Arnd Bergmann <arnd@arndb.de>; Kurt
> Kanzenbach <kurt@linutronix.de>; Saleem, Shiraz <shiraz.saleem@intel.com>;
> Ertman, David M <david.m.ertman@intel.com>; intel-wired-lan at lists.osuosl.org;
> netdev at vger.kernel.org; linux-kernel at vger.kernel.org
> Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK
> dependencies
>
>
> On Tue, Aug 03, 2021 at 07:00:49PM +0200, Arnd Bergmann wrote:
>
> > If you turn all those 'select' lines into 'depends on', this will work, but it's
> > not actually much different from what I'm suggesting.
>
> "depends" instead of "select" works for me. I just want it simple and clear.
>
> > Maybe we can do it
> > in two steps: first fix the build failure by replacing all the 'imply'
> > statements
> > with the correct dependencies, and then you send a patch on top that
> > turns PPS and PTP_1588_CLOCK into bool options.
>
> Sounds good.
>
> Thanks,
> Richard
Works for me too.
Thanks,
Jake
next prev parent reply other threads:[~2021-08-04 20:53 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 14:59 [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies Arnd Bergmann
2021-08-02 14:59 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 16:49 ` Richard Cochran
2021-08-02 16:49 ` [Intel-wired-lan] " Richard Cochran
2021-08-02 19:54 ` Keller, Jacob E
2021-08-02 19:54 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-02 20:32 ` Arnd Bergmann
2021-08-02 20:32 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 20:46 ` Keller, Jacob E
2021-08-02 20:46 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-02 20:59 ` Arnd Bergmann
2021-08-02 20:59 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 21:09 ` Keller, Jacob E
2021-08-02 21:09 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-02 21:10 ` Keller, Jacob E
2021-08-02 21:10 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-02 21:22 ` Nicolas Pitre
2021-08-02 21:22 ` [Intel-wired-lan] " Nicolas Pitre
2021-08-03 20:29 ` Arnd Bergmann
2021-08-03 20:29 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 23:09 ` Richard Cochran
2021-08-02 23:09 ` [Intel-wired-lan] " Richard Cochran
2021-08-02 23:45 ` Keller, Jacob E
2021-08-02 23:45 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-03 0:03 ` Richard Cochran
2021-08-03 0:03 ` [Intel-wired-lan] " Richard Cochran
2021-08-03 6:59 ` Arnd Bergmann
2021-08-03 6:59 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 15:55 ` Richard Cochran
2021-08-03 15:55 ` [Intel-wired-lan] " Richard Cochran
2021-08-03 16:14 ` Richard Cochran
2021-08-03 16:14 ` [Intel-wired-lan] " Richard Cochran
2021-08-03 17:00 ` Arnd Bergmann
2021-08-03 17:00 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 17:18 ` Keller, Jacob E
2021-08-03 17:18 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-03 18:27 ` Arnd Bergmann
2021-08-03 18:27 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 23:25 ` Keller, Jacob E
2021-08-03 23:25 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-04 11:18 ` Arnd Bergmann
2021-08-04 11:18 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 20:54 ` Richard Cochran
2021-08-03 20:54 ` [Intel-wired-lan] " Richard Cochran
2021-08-04 20:53 ` Keller, Jacob E [this message]
2021-08-04 20:53 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB5089005017FE714B8A37F9B0D6F19@CO1PR11MB5089.namprd11.prod.outlook.com \
--to=jacob.e.keller@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=richardcochran@gmail.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.