From: "Keller, Jacob E" <firstname.lastname@example.org> To: Jakub Kicinski <email@example.com> Cc: Jiri Pirko <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org> Subject: RE: [net-next 0/4] devlink: add dry run support for flash update Date: Sat, 9 Oct 2021 00:32:49 +0000 [thread overview] Message-ID: <CO1PR11MB50899080E3A33882F9630C98D6B39@CO1PR11MB5089.namprd11.prod.outlook.com> (raw) In-Reply-To: <email@example.com> > -----Original Message----- > From: Jakub Kicinski <firstname.lastname@example.org> > Sent: Friday, October 08, 2021 5:18 PM > To: Keller, Jacob E <email@example.com> > Cc: Jiri Pirko <firstname.lastname@example.org>; email@example.com > Subject: Re: [net-next 0/4] devlink: add dry run support for flash update > > On Fri, 8 Oct 2021 23:58:45 +0000 Keller, Jacob E wrote: > > > > Doesn't the policy checks prevent any unknown attributes? > > > > Or are unknown attributes silently ignored? > > > > > > Did you test it? > > > > > > DEVLINK_CMD_FLASH_UPDATE has GENL_DONT_VALIDATE_STRICT set. > > > > Hmm. I did run into an issue while initially testing where > > DEVLINK_ATTR_DRY_RUN wasn't in the devlink_nla_policy table and it > > rejected the command with an unknown attribute. I had to add the > > attribute to the policy table to fix this. > > > > I'm double checking on a different kernel now with the new userspace > > to see if I get the same behavior. > > Weird. > > > I'm not super familiar with the validation code or what > > GENL_DONT_VALIDATE_STRICT means... > > > > Indeed.. I just did a search for GENL_DONT_VALIDATE_STRICT and the > > only uses I can find are ones which *set* the flag. Nothing ever > > checks it!! > > > > I suspect it got removed at some point.. still digging into exact > > history though... > > > It's passed by genl_family_rcv_msg_doit() to > genl_family_rcv_msg_attrs_parse() where it chooses the netlink policy. Ah.. I see how its done. It's passed as the argument so you don't see a direct comparison which makes it look like there isn't one... Feels like there could probably be a better abstraction that was more readable here... Anyways. I'll confirm what happens on the kernel that doesn't have the attribute defined at all. I wonder if the thing I saw differently was because the attribute *was* known but wasn't in policy. I.e. because it was defined it was validated.... Yep, I confirm that on a kernel without the DRY_RUN flag that it would allow the run because we aren't being strict. I am guessing that we can't convert devlink over to strict validation? Thanks, Jake
next prev parent reply other threads:[~2021-10-09 0:32 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-08 10:41 Jacob Keller 2021-10-08 10:41 ` [net-next 1/4] ice: move and rename ice_check_for_pending_update Jacob Keller 2021-10-08 10:41 ` [net-next 2/4] ice: move ice_devlink_flash_update and merge with ice_flash_pldm_image Jacob Keller 2021-10-08 10:41 ` [net-next 3/4] devlink: add dry run attribute to flash update Jacob Keller 2021-10-08 10:41 ` [net-next 4/4] ice: support dry run of a flash update to validate firmware file Jacob Keller 2021-10-08 12:37 ` [net-next 0/4] devlink: add dry run support for flash update Jiri Pirko 2021-10-08 18:21 ` Jakub Kicinski 2021-10-08 21:43 ` Keller, Jacob E 2021-10-08 22:35 ` Jakub Kicinski 2021-10-08 23:58 ` Keller, Jacob E 2021-10-09 0:17 ` Jakub Kicinski 2021-10-09 0:32 ` Keller, Jacob E [this message] 2021-10-09 1:29 ` Jakub Kicinski 2022-04-25 23:05 ` Jacob Keller 2021-10-11 8:21 ` Keller, Jacob E 2021-10-11 23:21 ` Keller, Jacob E 2021-10-08 21:42 ` Keller, Jacob E
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CO1PR11MB50899080E3A33882F9630C98D6B39@CO1PR11MB5089.namprd11.prod.outlook.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='RE: [net-next 0/4] devlink: add dry run support for flash update' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.