From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Richard Cochran <richardcochran@gmail.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Kurt Kanzenbach <kurt@linutronix.de>,
"Saleem, Shiraz" <shiraz.saleem@intel.com>,
"Ertman, David M" <david.m.ertman@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies
Date: Mon, 2 Aug 2021 21:09:19 +0000 [thread overview]
Message-ID: <CO1PR11MB5089DBFAEB671ED58D9BAEADD6EF9@CO1PR11MB5089.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAK8P3a379=Qi7g7Hmf299GgM-6g32Them81uYXPqRDZDro_azg@mail.gmail.com>
> -----Original Message-----
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Monday, August 02, 2021 1:59 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: Richard Cochran <richardcochran@gmail.com>; Nicolas Pitre
> <nicolas.pitre@linaro.org>; Brandeburg, Jesse <jesse.brandeburg@intel.com>;
> Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Arnd Bergmann
> <arnd@arndb.de>; Kurt Kanzenbach <kurt@linutronix.de>; Saleem, Shiraz
> <shiraz.saleem@intel.com>; Ertman, David M <david.m.ertman@intel.com>;
> intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK
> dependencies
>
> I don't want to mess with the semantics of the keyword any further.
> The original meaning was meant to avoid circular dependencies
> by making it a softer version of 'select' that would not try to select
> anything that has unmet dependencies. The current version made
> it even softer by only having an effect during 'make defconfig'
> and 'make oldconfig' but not preventing it from being soft-disabled
> any more. Changing it yet again is guarantee to break lots of the
> existing users, while probably also bringing back the original problem
> of the circular dependencies.
>
> Arnd
Yea ok that makes sense. Better to use a new keyword if we do at all.
WARNING: multiple messages have this Message-ID (diff)
From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies
Date: Mon, 2 Aug 2021 21:09:19 +0000 [thread overview]
Message-ID: <CO1PR11MB5089DBFAEB671ED58D9BAEADD6EF9@CO1PR11MB5089.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAK8P3a379=Qi7g7Hmf299GgM-6g32Them81uYXPqRDZDro_azg@mail.gmail.com>
> -----Original Message-----
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Monday, August 02, 2021 1:59 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: Richard Cochran <richardcochran@gmail.com>; Nicolas Pitre
> <nicolas.pitre@linaro.org>; Brandeburg, Jesse <jesse.brandeburg@intel.com>;
> Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Arnd Bergmann
> <arnd@arndb.de>; Kurt Kanzenbach <kurt@linutronix.de>; Saleem, Shiraz
> <shiraz.saleem@intel.com>; Ertman, David M <david.m.ertman@intel.com>;
> intel-wired-lan at lists.osuosl.org; netdev at vger.kernel.org; linux-
> kernel at vger.kernel.org
> Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK
> dependencies
>
> I don't want to mess with the semantics of the keyword any further.
> The original meaning was meant to avoid circular dependencies
> by making it a softer version of 'select' that would not try to select
> anything that has unmet dependencies. The current version made
> it even softer by only having an effect during 'make defconfig'
> and 'make oldconfig' but not preventing it from being soft-disabled
> any more. Changing it yet again is guarantee to break lots of the
> existing users, while probably also bringing back the original problem
> of the circular dependencies.
>
> Arnd
Yea ok that makes sense. Better to use a new keyword if we do at all.
next prev parent reply other threads:[~2021-08-02 21:09 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 14:59 [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies Arnd Bergmann
2021-08-02 14:59 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 16:49 ` Richard Cochran
2021-08-02 16:49 ` [Intel-wired-lan] " Richard Cochran
2021-08-02 19:54 ` Keller, Jacob E
2021-08-02 19:54 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-02 20:32 ` Arnd Bergmann
2021-08-02 20:32 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 20:46 ` Keller, Jacob E
2021-08-02 20:46 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-02 20:59 ` Arnd Bergmann
2021-08-02 20:59 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 21:09 ` Keller, Jacob E [this message]
2021-08-02 21:09 ` Keller, Jacob E
2021-08-02 21:10 ` Keller, Jacob E
2021-08-02 21:10 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-02 21:22 ` Nicolas Pitre
2021-08-02 21:22 ` [Intel-wired-lan] " Nicolas Pitre
2021-08-03 20:29 ` Arnd Bergmann
2021-08-03 20:29 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-02 23:09 ` Richard Cochran
2021-08-02 23:09 ` [Intel-wired-lan] " Richard Cochran
2021-08-02 23:45 ` Keller, Jacob E
2021-08-02 23:45 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-03 0:03 ` Richard Cochran
2021-08-03 0:03 ` [Intel-wired-lan] " Richard Cochran
2021-08-03 6:59 ` Arnd Bergmann
2021-08-03 6:59 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 15:55 ` Richard Cochran
2021-08-03 15:55 ` [Intel-wired-lan] " Richard Cochran
2021-08-03 16:14 ` Richard Cochran
2021-08-03 16:14 ` [Intel-wired-lan] " Richard Cochran
2021-08-03 17:00 ` Arnd Bergmann
2021-08-03 17:00 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 17:18 ` Keller, Jacob E
2021-08-03 17:18 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-03 18:27 ` Arnd Bergmann
2021-08-03 18:27 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 23:25 ` Keller, Jacob E
2021-08-03 23:25 ` [Intel-wired-lan] " Keller, Jacob E
2021-08-04 11:18 ` Arnd Bergmann
2021-08-04 11:18 ` [Intel-wired-lan] " Arnd Bergmann
2021-08-03 20:54 ` Richard Cochran
2021-08-03 20:54 ` [Intel-wired-lan] " Richard Cochran
2021-08-04 20:53 ` Keller, Jacob E
2021-08-04 20:53 ` [Intel-wired-lan] " Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB5089DBFAEB671ED58D9BAEADD6EF9@CO1PR11MB5089.namprd11.prod.outlook.com \
--to=jacob.e.keller@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=richardcochran@gmail.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.