All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Engel, Amit" <Amit.Engel@Dell.com>
To: Sagi Grimberg <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"hch@lst.de" <hch@lst.de>
Subject: RE: [PATCH] nvmet_tcp: fix header digest verification
Date: Mon, 25 Oct 2021 08:47:14 +0000	[thread overview]
Message-ID: <CO1PR19MB48856AA2F52E022418DEA773EE839@CO1PR19MB4885.namprd19.prod.outlook.com> (raw)
In-Reply-To: <4a71a194-c715-a38d-6b3e-560eae714451@grimberg.me>

In nvmet_tcp_try_recv_pdu:
1. After kernel_recvmsg, 'queue->offset' is equal to 'sizeof(struct nvme_tcp_hdr)'

2. update queue->left = hdr->hlen - queue->offset + hdgst and 'goto recv'

3. after recvmsg , the offset is greater than the digest.

So , In this case offset != hdr->hlen 

This will lead to nvmet_tcp_verify_hdgst to always pass, which 

Thanks
Amit


Internal Use - Confidential

-----Original Message-----
From: Sagi Grimberg <sagi@grimberg.me> 
Sent: Wednesday, October 20, 2021 8:53 PM
To: Engel, Amit; linux-nvme@lists.infradead.org; hch@lst.de
Subject: Re: [PATCH] nvmet_tcp: fix header digest verification


[EXTERNAL EMAIL] 


> One of our tests found that
> With the current code,
> recv_digest == exp_digest even if the pdu header digest is being 
> modified (synthetically) For example:
> In case that pdu header digest is changed to 0xffffffff, recv == exp 
> == 0xfffffff, and nvmet_tcp_verify_hdgst returns 0 - which is wrong

Not sure I follow. Can you describe in which case the passed offset !=
hdr->hlen?


> Internal Use - Confidential

Is this confidential?

  reply	other threads:[~2021-10-25  8:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211019113307.31852-1-amit.engel@dell.com>
2021-10-19 12:18 ` [PATCH] nvmet_tcp: fix header digest verification Sagi Grimberg
2021-10-20 15:43   ` Engel, Amit
2021-10-20 17:53     ` Sagi Grimberg
2021-10-25  8:47       ` Engel, Amit [this message]
2021-10-26 15:34         ` Sagi Grimberg
2021-10-27  6:50           ` Engel, Amit
     [not found] <20211027064927.20452-1-amit.engel@dell.com>
2021-10-27  7:09 ` Sagi Grimberg
2021-10-27  7:21 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR19MB48856AA2F52E022418DEA773EE839@CO1PR19MB4885.namprd19.prod.outlook.com \
    --to=amit.engel@dell.com \
    --cc=hch@lst.de \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.