All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuval Mintz <Yuval.Mintz@qlogic.com>
To: Hariprasad Shenai <hariprasad@chelsio.com>
Cc: netdev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	"leedom@chelsio.com" <leedom@chelsio.com>,
	"nirranjan@chelsio.com" <nirranjan@chelsio.com>
Subject: RE: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf_vlan
Date: Wed, 24 Aug 2016 10:02:57 +0000	[thread overview]
Message-ID: <CO2PR11MB00884270FCB88896B9B1754B97EA0@CO2PR11MB0088.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20160824094003.GA21672@hari-Latitude-E5550>

> > Are you preventing VGT configuration once VST is configured?
> > If not, what to prevent VM user from configuring vlan interfaces on
> > top of the VF, even if VST is configured?
> Again this misses documentation, what if VLAN interface is already configured in
> VM before VST is configured.
> Before there were callbacks to add/remove vlan interface, now that is removed
> how to achieve it?
>     OR
> am I missing something?

I can only offer what our drivers [bnx2x, qed*] are doing - 
  -  VST is achieved by FW adding the vlan tag [unknowingly to VF] on egress traffic,
and silently stripping the vlan tag from the incoming traffic [so VF driver never
sees the tag].
  - Once VST is enabled, device [well, actually PF driver] would reject any further
requests for configuring VGT.
  - Once VST is configured, device would silently drop any vlan-tagged egress
Traffic sent  by VF, and would classify incoming traffic for that VF only if it's
tagged with the VGT vlan-id.
This has the effect of making existing vlan-interface over the VF completely
dysfunctional [as all transmissions from them would be dropped and they'll
never see any additional incoming traffic].

  reply	other threads:[~2016-08-24 10:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24  6:50 [PATCH net-next 0/2] cxgb4: Adds support for VF mgmt ndo's Hariprasad Shenai
2016-08-24  6:50 ` [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf_vlan Hariprasad Shenai
2016-08-24  7:08   ` Yuval Mintz
2016-08-24  8:22     ` Hariprasad Shenai
2016-08-24  8:31       ` Yuval Mintz
2016-08-24  9:40         ` Hariprasad Shenai
2016-08-24 10:02           ` Yuval Mintz [this message]
2016-08-25 23:24   ` David Miller
2016-08-24  6:50 ` [PATCH net-next 2/2] cxgb4: Add support for ndo_get_vf_config Hariprasad Shenai
2016-08-24  7:15   ` Yuval Mintz
2016-08-24  7:58     ` Hariprasad Shenai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO2PR11MB00884270FCB88896B9B1754B97EA0@CO2PR11MB0088.namprd11.prod.outlook.com \
    --to=yuval.mintz@qlogic.com \
    --cc=davem@davemloft.net \
    --cc=hariprasad@chelsio.com \
    --cc=leedom@chelsio.com \
    --cc=netdev@vger.kernel.org \
    --cc=nirranjan@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.