From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Chulski <stefanc@marvell.com>
Date: Thu, 8 Apr 2021 19:18:09 +0000
Subject: [EXT] Re: [PATCH v1 2/5] net: phy: marvell: extend 88E2110 to use
 both 2.5GHz modes
In-Reply-To: <beb0fc68-7bd7-bf30-fc1c-9c5cfc1d3baa@denx.de>
References: <20210324092008.1300548-1-sr@denx.de>
 <20210324101949.v1.2.I60e61534246755c890f5283d6041f9c8fbcea87b@changeid>
 <20210324104418.2ee37fee@thinkpad>
 <CO6PR18MB4417B62F4DC8E5F95C1DC5BECA639@CO6PR18MB4417.namprd18.prod.outlook.com>
 <20210324114713.1f36e11a@thinkpad>
 <CO6PR18MB4417B7F2D9C1B3BD4CC88B51CA639@CO6PR18MB4417.namprd18.prod.outlook.com>
 <CO6PR18MB3873F8F3C3636E876B472811B0639@CO6PR18MB3873.namprd18.prod.outlook.com>
 <CO6PR18MB3873B721D3C55F28D71FCE26B0639@CO6PR18MB3873.namprd18.prod.outlook.com>
 <20210324145208.2559de68@thinkpad>
 <CO6PR18MB3873804D81FDE467A5A02BEAB0639@CO6PR18MB3873.namprd18.prod.outlook.com>
 <20210324234550.11a5e8a9@thinkpad>
 <CO6PR18MB3873A0D16C2CCE1DDFEF873DB0629@CO6PR18MB3873.namprd18.prod.outlook.com>
 <beb0fc68-7bd7-bf30-fc1c-9c5cfc1d3baa@denx.de>
Message-ID: <CO6PR18MB3873CC0C6CED884EE8C21969B0749@CO6PR18MB3873.namprd18.prod.outlook.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> 
> Stefan, you suggest to drop this define from PHY_INTERFACE enum which we
> can't easily do with other drivers (like NXP) also referencing this macro.
> 
> How to continue then?
> 
> Thanks,
> Stefan

Probably we should drop SGMII_2500 from this series, introduce "manage" devicetree property(that would indicate if inband supported or not).
For example this is armada-8040-mcbin.dtsi In kernel, when in-band supported:
&cp1_eth2 {
	/* CPS Lane 5 */
	status = "okay";
	/* Network PHY */
	phy-mode = "2500base-x";
	managed = "in-band-status";
	/* Generic PHY, providing serdes lanes */
	phys = <&cp1_comphy5 2>;
	sfp = <&sfp_eth3>;
}; 

If in-band not supported(for example PPv2 MAC connected to 88E2110 in 2.5G speed) we would use default managed = "auto" and fixed link property.

Regards.