From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E63C433F5 for ; Mon, 18 Oct 2021 07:02:24 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 98C7E60F36 for ; Mon, 18 Oct 2021 07:02:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 98C7E60F36 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB1DA40041; Mon, 18 Oct 2021 09:02:22 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 316F74003C for ; Mon, 18 Oct 2021 09:02:21 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19HMnNgX002329; Mon, 18 Oct 2021 00:02:15 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2102.outbound.protection.outlook.com [104.47.70.102]) by mx0b-0016f401.pphosted.com with ESMTP id 3brt1s1ey4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Oct 2021 00:02:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ClmRV23tqhkoZIg63N/SYfRILI323vQxCZB73Pc3XWI5nHYnv7q7yE8M9GgPDLrg9wnmu1bbgkZnDOceuyhMoP1Tmkm/YFjeNKG5QGgQ0+QcwwIJD/Y5vXgbamUOAauWq0yxEtHy1Ey8jYK/k3290H5+J4jXhMp+aGcOQivctbUU4Mo2Dz6AjoNR9i+QrWLBgSLCtvmBAMPJb2e8vGMPsbnVq7Rv11lo2jtic4pOa1+hN8gKfzyxMyVJaPfcfm6aNtwfAAFeSfhX36bL0OJTEDPZ3W9TG0TiVdsl7rPS9EB/T4XNX8TSQR4PtWUY8dbWBer9ZHd3cN20djVZeS1/EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9SlB3eWFYpJ3ttMZqXGDLclyVwieiEOHgkRub/8LsYI=; b=Y3RvZDeAVJrUr9UQsY/x/J2chTjQd3TtddrA51B9U6pHOhp1Zsh6/NkVUHSZO9gGtqV55W3JuZbHfyzKu71dbma3cqMPkXxtiK5uRxUwF287pP3A8v9NsklNjc7S0SwJGUFvCPydVew0Ey+ks5yPYfpidB8hfM4hh12zH1N2UJ58EOR/7m7VaVyAnG25LWhN5K7hfm9YS8gElgxjy9aWjlif2mfunaPq7ym5vetn7uhHkyzC3OU+hhniifkQBTpeu4uGc2OhjQ8mgy+vx+kBRFPoeWagsJO8QtSBHXdiDNuIJJR+gDFaSAcOGvl59s/ez2N4tuWmXI/YKU+1X+wp2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9SlB3eWFYpJ3ttMZqXGDLclyVwieiEOHgkRub/8LsYI=; b=kAUEogKWFP48+aaPQiE4wVRreFGa3XIE83OUramsIDOATS9zixC1IDzQ8rarBoo/1JHOqoIG+kCaJuyhTpVk2DQb5OcJ2iNHb9kkFqFq9Eh3eDoDl1NEe1YeaGbOVOQv27wBwhZdk8vewspJq+5ZMW2lJIKKCU9VIi6RWV2HUTY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB4435.namprd18.prod.outlook.com (2603:10b6:5:355::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct 2021 07:02:13 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 07:02:13 +0000 From: Akhil Goyal To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" Thread-Topic: [PATCH v2 3/5] cryptodev: move inline APIs into separate structure Thread-Index: AQHXvp2g18Jh71NNHk+eEW34wAtxu6vN3/2AgAp+iRA= Date: Mon, 18 Oct 2021 07:02:12 +0000 Message-ID: References: <20210829125139.2173235-1-gakhil@marvell.com> <20211011124309.4066491-1-gakhil@marvell.com> <20211011124309.4066491-4-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2eec077b-54df-4bd5-9902-08d992053620 x-ms-traffictypediagnostic: CO6PR18MB4435: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:660; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rX1sehrLSwM7bAX+4iLIWRH8AZxyXgSN3OQAUIIRXaXZLEwthz9pcu90E8Dldhsuk2LK16bGl+Ogd0CLBeoyxoYEru3k0XW4n3evNEyKXW9/A+500foWdUNPGv60+q8CkQe+fe3yMIIvJ0Zl1OFs6XbINngrm17LgL3RVKtEyHOd6iF0G69XOKNoY14egSKop/pcQjt5WCiYNNcuE3qEyzOBxuQzETmQXh02Dnz93a+KEQwq88hcEsh3LkHZcmaj2r/jBRGwrKAINtrB8vXYKfVf4jT7RqI/BcT0YzWceeAdNHMYDDnPVaUTXW02f+W+XgKACiYqqgvZSkdPh/RtNbxj9Dj/Na9DoDAaqzj64xTMEbq6jYWQqhc6hzy72IcasqLVKaBCLV/j9dVTAP37Cb8Ar3ho4/PnYhBqwOA01i8+6hmDYCH4HHv9MYL+51q6gisj/FCnrCW6K04ynVVaprsB2rK12Kn9IyFRFNaR1S3yyAUrXj8sus6iRJdirbnzMpxunmakM10YEqg0VUSYfv0/UfgB6Z6NZQS88jH07bh/MjMOGcltFD/zOS3aaJLVs3DtvO+ZtzOXbL41kEOK6RSWfNscBcXKVT4WjJnrbW55FqWTWSABjR+59vCrz6Igkmz0m1p3iiA/+ir+ufW5elzJ8oX8PUEEZnu3zAd1IsMoPoP+LWE2dvO3dX5s7DEBVEdNuEpVT8qUyL1ieVsyZg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(7696005)(71200400001)(8676002)(26005)(7416002)(55236004)(76116006)(316002)(5660300002)(8936002)(110136005)(38100700002)(66476007)(66446008)(33656002)(508600001)(122000001)(6506007)(4326008)(55016002)(86362001)(64756008)(54906003)(186003)(83380400001)(38070700005)(66556008)(52536014)(66946007)(9686003)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T2+nT9kYfIWw0eVZcXtLvcc3ia81LmltksjaonCq+nty5GT6YDGU4eABefbp?= =?us-ascii?Q?o75grr3prAd7/3skSegwOWw9LukgdrorXXXgexhaWJcdvRdFGe4O2B15sLXp?= =?us-ascii?Q?b8Nrb/w0GRCVCuHcCpV1FRHcUi2jQl6hCckOSfpnyblDAmo5Ul20i7Vmzfgd?= =?us-ascii?Q?rPTRHPtKmm/Yb/KGVrYFHzQlroCNIhPSgJyYCvCucuhhdEIl9qxCjg1GZ/nw?= =?us-ascii?Q?fHMa03vVN0oE9DO2P1R1ssQwmvgdvSJRPm6vkYek0tj5fMAo1yNnhlV3WDFY?= =?us-ascii?Q?n1FmoE1H5UV6+Nh1MaBukvN7zo4r/JOgf84tFh2Xq9Gs8GAN59ihh67X2qFL?= =?us-ascii?Q?fur1ECMDm1kP5u43qFfNcuTzQw7+gQ7RWXhkqX1Ob/dC9xqLgcru6tKKXjwL?= =?us-ascii?Q?RKQRglUR6BLrommy1+TVETaHM/1KqmdDpPL2LytjC+pvkPREXwrOi01wayDw?= =?us-ascii?Q?wmqf3TSSZCUnFpXUHAcf995lXELA0o2zE6nLDFGsrzh4XHDgq2C2tIF2B79d?= =?us-ascii?Q?EgK46Gw8D6t+FRnVzPtv5uXMl303GHdWSm4YIVwsVhWl9i1XcU5AH1Vbakio?= =?us-ascii?Q?2myV4MR3Bg72hVdDPr3weVvdMmNnxlnl3nBoXT5y7PH+kCJeInZCJD3Yauoq?= =?us-ascii?Q?fiW0boP/rK/3Tv+HAKr3vxtFRvxwQ0GmhJqzLhZzVG5l9/1qp8Ajf0jZreJK?= =?us-ascii?Q?hY6YUH3iv8+u12hHfu3Hjtk0urLJw6Tzjw2oM7B5KMjdFrBVaZC11Aat7M29?= =?us-ascii?Q?xxCGsC8xaxioYIBtVuDCaS7zWbjyblR5ZReZSOJ04HAB7VOEuz5Hi54R1mwC?= =?us-ascii?Q?NDDXQU+yQYl+E6VnOnvn0dNV+F4AM/wo6OSISDEUu8D3eK3w3IcmdzLyFrby?= =?us-ascii?Q?VqgLt8E+tMes2BLbtOl/OO3QoJoRqx9LuJaNPDDds5w/f/DRgBOFmjM6bMKR?= =?us-ascii?Q?HL0yN9UqmcBykbysCyCFxXqcdYW3QAK53iAhPADliFSFkhLNLpME1SzC9ue6?= =?us-ascii?Q?FUez6VnRYbFxKM651kj4IUs68+vt4v2zYdV1xuAYp2SQw7l5NceBeimNVver?= =?us-ascii?Q?UPm4BvtSUmh7SFrCy+qBM1iMVOMtD1cGm7vkFvJC/asmYIYR2hjFImzSOamF?= =?us-ascii?Q?MKjneCk6ZsDLPXJJf6lxVnq15485f6Wx8tikBPMq5PtHmuzqR65rxDI9biaT?= =?us-ascii?Q?nPpacXkSs9SmuEgQj2Un/+l6GvpT7vZlsKnojeKgFwHH+B98itZDtQW13fba?= =?us-ascii?Q?D9dsZCNvpMn5SNe87FBfAznxbd5fXrMzFlR9c0tbIW5aSFRTcfKRSLKTO73U?= =?us-ascii?Q?wC7U8m0Y0rbIdOjXK8BiM1hz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2eec077b-54df-4bd5-9902-08d992053620 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2021 07:02:12.8521 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cxfa42XIdw4ZhDEEE2kuIUjQmbBdujQqwcytlN+Qv25Jd6Sk8PTl6jL+jnfFWOKIsd1uLnW1qBDnK4R+l3MBDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4435 X-Proofpoint-ORIG-GUID: zcdAUug5hT1AaCRsALWQowcdqnWVeriG X-Proofpoint-GUID: zcdAUug5hT1AaCRsALWQowcdqnWVeriG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-18_02,2021-10-14_02,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v2 3/5] cryptodev: move inline APIs into separate structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Hi Akhil, >=20 > > Move fastpath inline function pointers from rte_cryptodev into a > > separate structure accessed via a flat array. > > The intension is to make rte_cryptodev and related structures private > > to avoid future API/ABI breakages. > > > > Signed-off-by: Akhil Goyal > > --- > > lib/cryptodev/cryptodev_pmd.c | 51 > > ++++++++++++++++++++++++++++++ > > lib/cryptodev/cryptodev_pmd.h | 11 +++++++ > > lib/cryptodev/rte_cryptodev.c | 29 +++++++++++++++++ > > lib/cryptodev/rte_cryptodev_core.h | 29 +++++++++++++++++ > > lib/cryptodev/version.map | 5 +++ > > 5 files changed, 125 insertions(+) > > > > diff --git a/lib/cryptodev/cryptodev_pmd.c > > b/lib/cryptodev/cryptodev_pmd.c > > index 44a70ecb35..4646708045 100644 > > --- a/lib/cryptodev/cryptodev_pmd.c > > +++ b/lib/cryptodev/cryptodev_pmd.c > > @@ -4,6 +4,7 @@ > > > > #include > > > > +#include > > #include > > #include > > > > @@ -160,3 +161,53 @@ rte_cryptodev_pmd_destroy(struct rte_cryptodev > > *cryptodev) > > >=20 > When a device is removed - aka when rte_pci_remove() is called > cryptodev_fp_ops_reset() will never be called. This may expose a problem. > Looks like cryptodev_fp_ops_reset() needs to be called here too. >=20 rte_cryptodev_pmd_destroy internally calls rte_cryptodev_pmd_release_device and reset is called in that.