From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C256C43217 for ; Mon, 18 Oct 2021 07:07:51 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id B545F610A3 for ; Mon, 18 Oct 2021 07:07:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B545F610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 200CD410E4; Mon, 18 Oct 2021 09:07:50 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 5323B40141 for ; Mon, 18 Oct 2021 09:07:48 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19I3nTAE024169; Mon, 18 Oct 2021 00:07:42 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2171.outbound.protection.outlook.com [104.47.59.171]) by mx0a-0016f401.pphosted.com with ESMTP id 3bs1bugj93-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Oct 2021 00:07:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J7AGBCdMf/JWQ4kPf7+rSfIBVn1NyKHL/egEGh4RyL5QRilah6/HnHZaS4XlYCCPoaEqUaeOJiCmVcD0qhVIXM3csnO+8GeOgRp6C1VXmRA8TV85G5AJMaFIWMEuZs+jbzsQVOTUCtceD8O/8E3kHn1hdbxEgjE7ipIO/j3Nomk10IwnI23BaTHqp9wEJydjisBR4jKLQUmgRlRSpX32SmyHAOYFCHsuQ8TZhzmtsn8Cu7t08A/tq25YADdKODE368TZY3AS9Zq9Mopex8qUh5dXN65ZZYjLEM25DEPp/M0oWzfe+X8xFsyQSQAlx0uXp00VhIgK1+WucsywVfdukQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UHCG66GILJ7F8hhVdhPQsSKsaeZNxUwM7n9NuNGPeBo=; b=a3qfaIl9m3asfmQG37DZGxX7+0lkN/xrXgr0X8GddMJurQLKjO1W3fSDLn21nuRy5xUWw4gtRAX7j9AL0JGOmKN9KQNLMNBo/Bt6sehGrCilSAXCGYc+SL0O5q21cF2ElEQuG3pDj+Gz3wz0tBqo8b3Us4T+Kxa7GYX+2VPDEuIj5RZ+10qS6Vs6Zm83Iblzxr1R+27xc7IKgSXHLsAbkGtYcehMA+6cM3LcNhJS4f+pBd6ATz5M1tDKYfLu5VaVRVhYriLgJQVNUg22mSCLji24UBZiI4IABNJECsjPFDVdnajyVOoE5OLquKvRE5bH5Kxj0+9nbvPie3nZkPZTww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UHCG66GILJ7F8hhVdhPQsSKsaeZNxUwM7n9NuNGPeBo=; b=S2ktzJgOnzqYpQb6vQKd4ZWm2kltU8WAJWZgnjr5KIONuTZrNalPrd8E2PL8wZZEk67dmb5eqPgWYWPk7MrR5AN6Qb4SfejxIaKN0WJWgS4HTWsoJdf2C4B4sTEI+98GMa36Uc/M+zYUhy9BWdZF0FH5v7iRPBRPgb00cV7wmpI= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB4481.namprd18.prod.outlook.com (2603:10b6:303:13a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct 2021 07:07:40 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 07:07:40 +0000 From: Akhil Goyal To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" Thread-Topic: [PATCH v2 5/5] cryptodev: move device specific structures Thread-Index: AQHXvp2mT8of5LdcwESI4zxAva/5WavN5bOAgAp6HrA= Date: Mon, 18 Oct 2021 07:07:40 +0000 Message-ID: References: <20210829125139.2173235-1-gakhil@marvell.com> <20211011124309.4066491-1-gakhil@marvell.com> <20211011124309.4066491-6-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 06ba508b-2a89-460d-1e27-08d99205f928 x-ms-traffictypediagnostic: CO6PR18MB4481: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nwVS/oAkQ/Ir+F+JJzu+LCcKORIvqTqwiq2h1YloDALKYYSKSt10iQrOTacisuxxG0moduQJesc+Ibp+dx8RPJVqvt3/iAJhqbzDlxeni0/fcex38F/+VlRqxVC6IoTcUiNGD+IkotID6ehaA/a8PR3qphdgahwh0JAl4ATCikVwuXIhQm6w0Xr8dgPo8gfyAVAW708gYInUV2IfRhf+TGUbIO/BQXK4afjAupZ3KHPl2xVvmYZWvmEblaBP53OEwoDC34+KyfifAI4k9o0b4bFqYshKkS/1dIOVf56tsdZYHtyYATn0mMAKebbeLWCTDn4QTiiLmQOBvTsTmIokjMITsd5liqRMxnpZb7aUOVtjPv6ZFgo757Ms5O6jgmPW4ZN9fl/QrArGqDGCT0qhvP0C3ilDcs76ZjaSfIhMdhsggi4N/08AJHiUqfFRuQZMcaVTYqZkH4MjhhmflAUPSnh4NVBQLXRfTkEtzOWWKf1xwpXX5ODq0VajHfBwDHy5vkbeYdmPxVCOZ+66dJLXXNenw4oGGtfaARcThXM+fKe/axaxUM3Ex76L8Lg0oKdUrR1svc9fw/DbvNv5LKN4HobN6IiX6R2pGj9tB5QqwoVf8fbyHYXcg5JH7iL3gPwZ2FoUSFT9osg2zF5+HS7taITQT85Ct7KW/sR+IMnjE43WUucdZOzq1oK8qpfdTi0OBIknYsfAgtXHv+/UjILOrQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66476007)(71200400001)(5660300002)(122000001)(66446008)(508600001)(54906003)(76116006)(7696005)(66946007)(8936002)(64756008)(186003)(8676002)(26005)(38070700005)(38100700002)(4326008)(316002)(33656002)(86362001)(66556008)(110136005)(6506007)(55016002)(52536014)(2906002)(9686003)(55236004)(7416002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YpjN4kYDD2TaUYZ2QAN1w72dRgqSnQQ9A65euF0BbOdSJ9tfLIZY2iiLV4mi?= =?us-ascii?Q?v4okoXW8hit7ucE3oGso/LH+QhWV0yfN1cYPMKDSAFwnzwH38+cgNShvilSb?= =?us-ascii?Q?nVzcBSB5BvsFUO1EfpgdozshqVYGDvYHsQzZlCVUHdsO//7bD6httdBTGLEe?= =?us-ascii?Q?ohC/73ULeUidfVpcku8uDgvyN+obH1JfnjHgiaOMdglsHpRIfjYhfCSemga9?= =?us-ascii?Q?D0RpfExoVbDftacy0ylxphyTBzKhIOMnJm1GdExPYH+3Rpj7TZbum2ytIXM2?= =?us-ascii?Q?Y8FuhAdRcSKJl6r7smFO4ZO6yZynKwOqqWK6BzNFe0bIpAd84XoWkgc/Vdbh?= =?us-ascii?Q?WGdN82ADwHwOGbE7OWVmXX4JPsPCZPktSxH28vRXYOPc8PYpcC2UfFnzt5c2?= =?us-ascii?Q?hwi0i6pA//w5bx/P0ZXYbx638gXiKMG3QfFSQSGFUWoKidsv5ggBIcItnfn5?= =?us-ascii?Q?gfRYr5sI9SrXs18ZHsVnZuajZg6RJPuq2khfMhyIGh6mSt6HoZWu8zn1nnyg?= =?us-ascii?Q?teXQvuzF2ssAKoZmVPRCKZ23Tas1HquD8U7VZgmkswdU692cUgtioPrBZLPw?= =?us-ascii?Q?3XJHXDB23errg2qlSyhS7HHVDC6Cc1e1Df4V3MGdhgGorRMMuW/3cWgaRpXk?= =?us-ascii?Q?w2fJs2nvY27CTatd//vCCHdJOZKAXo1e0HW6uu/7dR1V2sSYYVlb/cL5df9y?= =?us-ascii?Q?y9d/poQHUZKOcQWztlpeAzbFRy5oiL64sqa+5SQdWZ6FphsLNIyQyNc2gQsq?= =?us-ascii?Q?YQdLpDzj02fRoyPwEHQE1aUxwN8F3FVJMWfaJZ5tpZ7cF7kiFQ8esWnuJsU5?= =?us-ascii?Q?AuOg3jsIpx6Ht5dFcwPEqPV3N+J3xRKGIRo+/0ZwZb7S3PWf0Gd+OaM5Z9A/?= =?us-ascii?Q?wDeANZgoRSVPRfKvlytE8CjbRtfDiGb3z8FWre+Ax10/I5iYoX0saV8b9TGP?= =?us-ascii?Q?zJ5XOmL/6t4XKWq1zozsDJ0Zh+txl3lqtXfT1+g4xrGFUgUrQqjaeQkEHUOd?= =?us-ascii?Q?FTLuyM890YEaa/iv1SIuiYeF8ImRkrzy/tWaDhOI82zytJ/ZQEN/uxLbeaIm?= =?us-ascii?Q?iOvd+jqbLhBrr42COH/BWFtQHBsR8lkaSwCLNyk+TBPbFa4bruD8JIQd5vEf?= =?us-ascii?Q?DQZhw13Cm4beWNdft7SehXxLHXOFxDRRUVMXk5GPwjm5PQuAQ8MzMWKZaIKD?= =?us-ascii?Q?eFhceKAST/cKCr+r3hXC1Tvme2rzpONb3+81xM0m+VCKVxBMWAvAQsevES3J?= =?us-ascii?Q?XiFClsN3YNwqd4KvG+w+AY5SCqzI84sBgdTChKYrz/aMY2Bc8v1+9SHMhFJz?= =?us-ascii?Q?GrAfPcLqx3Pi6Q2Vre4mioom?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06ba508b-2a89-460d-1e27-08d99205f928 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2021 07:07:40.0501 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fGZ3keiZWF+jsQuU1OcZ95aNlo7i2GyimaugDCnKptmezJQaS/mG4FGdvGxHzZhUTVwBDn8DNj4THESGErr9ww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4481 X-Proofpoint-GUID: -mwQTxcBRFEl7MkVsvcaIsMuI5ZC9Io_ X-Proofpoint-ORIG-GUID: -mwQTxcBRFEl7MkVsvcaIsMuI5ZC9Io_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-18_02,2021-10-14_02,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v2 5/5] cryptodev: move device specific structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > +struct rte_cryptodev_data { > > + /** Device ID for this instance */ > > + uint8_t dev_id; > > + /** Socket ID where memory is allocated */ > > + uint8_t socket_id; > > + /** Unique identifier name */ > > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > > + > > + __extension__ > > + /** Device state: STARTED(1)/STOPPED(0) */ > > + uint8_t dev_started : 1; > > + > > + /** Session memory pool */ > > + struct rte_mempool *session_pool; >=20 > Looks like we never used this pool ever - shall we take this chance to re= move > it? It is getting used in qp release which checks if all sessions are cleared b= efore releasing the QP. >=20 > > + /** Array of pointers to queue pairs. */ > > + void **queue_pairs; > > + /** Number of device queue pairs. */ > > + uint16_t nb_queue_pairs; >=20 > queue_pairs are likely the only item we use rte_cryptodev_data in the fas= t- > path. > Also take this chance to move it to the beginning of the structure? As per latest design, rte_cryptodev_data will not be used in fast path. In control path, all data path params are set in the fp_array. Hence no need to change. >=20 > > + > > + /** PMD-specific private data */ > > + void *dev_private; > > +} __rte_cache_aligned; > > + >=20 > Not really comments but some suggestions - could be done in the future as > the > structure is moved to internal in this patchset. > Acked-by: Fan Zhang