From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14ADC433F5 for ; Tue, 19 Oct 2021 12:47:33 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 5929B610A2 for ; Tue, 19 Oct 2021 12:47:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5929B610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9807411A9; Tue, 19 Oct 2021 14:47:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 138AA4119B for ; Tue, 19 Oct 2021 14:47:30 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19JAIlXF009139; Tue, 19 Oct 2021 05:47:24 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2107.outbound.protection.outlook.com [104.47.70.107]) by mx0a-0016f401.pphosted.com with ESMTP id 3bsnmq2hva-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Oct 2021 05:47:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TVGKLVQZjWYxrY9zGvtL78+Qm6lMhwcGx0yiEGXDSF54j/dp/bIt1iMfBVkNpJoWAQJqdvctkfOr3jQOLyH8x49orzpHYOqf/J5CUuE1rZ6Ss0cC7G4mdKUmd9WRHA/XFndRAR30D3x4qhMperCqcXbpOSXUDlUqC+/z4ZPrdABX05y8Qs2pUb9fpzEl73hGOOHFLy5vKy0G6IynxAyTtKONNN5Ma+uX6Pz1wx7nBmN4IU8gkvypjrRFZZUqBJA9Tm4CwzqGUuL51niqJVRue0v2FVV5ocLnCKb1W83LUfnOfNtAIS4Zyq/uaAb2R38RJltmB7Ifqu3QxdKCefYZAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=53tJVKE/yhRamN8I6IWVpEgjG6iWz4lAixxACpwsak8=; b=A235hyN11qaRfGRoPIVgPvDlFhV681+J8HqEVD5DkS/trSTATAfzstWIGn5QMr1LH3OfwlnJL+ZVVvQTOvrg8vspjDipgdgtFO654LkDEnjcf0vLR3ySQ8raxGYxT15AQgIK1YGSeiojYxz+MvhmpSIoXCFvmJd5C4pUSup7DknteeL77D2AUR9DNKPScVUilSIX987Sv9rujkg49GNHnBt2DuAEWSY4PwDiRgELD1ETuOODQr12It5EODHD4NhDn8nFxCkwfstTRa8aT0MO/xNez7YINMNol4NXsUtSQRG38l7Xco6nbwPCWqfVDulN8ei9HFeidzQ81Xe4zZl6BQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=53tJVKE/yhRamN8I6IWVpEgjG6iWz4lAixxACpwsak8=; b=es5T3/9OoU5/CRiaLVo7alYTBWaRF8f3i+jPgKOZoIGDUolPxE4dsbPYtftU03+JDkOBYjqC9OESTWhi+Z5FSTDZYDqhvXKID9bNL2rgVzPRZvmcbZu2xDSzrrPur/xPSewLwlHtUt5i7TX4pToWyHTruFx+0Mi9qfH/f+lGvF0= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB4483.namprd18.prod.outlook.com (2603:10b6:303:13d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct 2021 12:47:21 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 12:47:20 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "Zhang, Roy Fan" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" Thread-Topic: [PATCH v3 6/7] cryptodev: update fast path APIs to use new flat array Thread-Index: AQHXxC516fhEdrVKgEixBG0kVzS/AKvaQT6AgAAEgcA= Date: Tue, 19 Oct 2021 12:47:20 +0000 Message-ID: References: <20211011124309.4066491-1-gakhil@marvell.com> <20211018144201.2028022-1-gakhil@marvell.com> <20211018144201.2028022-7-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cda53b77-d475-410b-d938-08d992fe9771 x-ms-traffictypediagnostic: CO6PR18MB4483: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c3mwH7DkG0epz2UI0TsegiPWXgQh1q952aU6GaWx+POvGbA40yfifexHufBxA6K4ou6MvhosgJBEQBtgL1BpptNRMyEv5fTZS55lRUQA7yVaXe0u6t0dvXiBKYG48dtmj0sBweuSBhYWvJeZ99R3XYEzPq8SVHv6QKa6aVhwehR3mmfspUOXI5rVwBoTf6+a3DMz2q3Bn7lnP6TfYYKjyNxnQOtcvH4dk41PA0vvmCJauTu1tCzk+tcjqyoiwOCvxcKXV2Pd8ka5xaC0AAQz19a7B1lVBkcM6guYO2e30WgJjUkBEKgnB6WyBl5tXoyv3BVfUoiajtJ49nBlG6o1p3pO7Qt7d5w9ialvQ5jGy42KCVqvapmaPL+9mA8qREi3o1P1Rlh+8Yyt+HmXy5WVSn8PM2QuKQk2Bqw5sQol0yTuRh2qhQ+YNHTcdd04/tlBHhJc4fSC4MFtKIZ0DNGhNQYb1eM3W+wRaPNvbrrcG1o9qxxqLRJIIz9vrbNwjUAYpCQyzWjDCCSj1x3naVchDLdyIo6Y8jyIBRCrtU4FCGpgAGhPd1tYnCpplEhUDQR8adYVRP/AeZLRbMbPvnTyyvZ3C5hYWDOZCTjAcdrjVEaeMasqVIKa+Itwh7/1Pa7gHzuHeQOD6xUnbzzeJjgtguRyjXwM/Wd9QyJ6gsWk21HZgMzeIFR9PRJICH2yW8OERfXl4SBqkzIODxEdTtWPsQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66556008)(66476007)(64756008)(76116006)(55236004)(66446008)(122000001)(6506007)(66946007)(38100700002)(8676002)(86362001)(186003)(5660300002)(38070700005)(52536014)(316002)(54906003)(7696005)(9686003)(110136005)(7416002)(4326008)(26005)(8936002)(55016002)(33656002)(508600001)(71200400001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N3LRCGKn0M8K9PlHC6Ir/pziOzzwhPq1wvA/yPABtDMiTtSyo3nboe4FAm8T?= =?us-ascii?Q?emZqAnwxhtQOieNDq/nVLg0TCuXZXPtVwq5mUh5zNUDjGX6lCuiuj708SlTs?= =?us-ascii?Q?0ARFyHiMssF5yW0LPYwjzKMt/fXv3R5OBe4uB4OyC3WuQ5lyMAgWcBJjvLVF?= =?us-ascii?Q?oEzbt//scX02fO84Tps9PAVuZoMopIYXHyGjMGQEmMkAfRIDeWKbArCMJ4a8?= =?us-ascii?Q?KDjWvA2e7s97/dRSUFWl60ksgLzeJsYCIce6s/ti6rssXf7w7zXKaKb1nr6I?= =?us-ascii?Q?p2VPSJBwcTHIud0OExO3mDX+42bQNeWSv/gE6v2m4kGol7Iya/CsVqu6+tHS?= =?us-ascii?Q?Wq3GKL6wksUIqchzNmRT1QtEFyk0+vsn0P9sXJWd9GZGAx65RdOwbaAjKsN0?= =?us-ascii?Q?Ssthc6Zsoankqo/KA84KSzC+BLlfpL/EehBd0ZDpSB/mo0qZIDI+Vg9I0Aux?= =?us-ascii?Q?hgTcdh8Zbu/npXWvxsX8j3iSVDEzrK1e0rPyFiaQpo2n0rOctYdvKbAnhrrh?= =?us-ascii?Q?V5a7XGFIVNltGf9l86+h640fX0yMqsUGIZ1qHPTV6hz15k9wS+d8YNhhCkw6?= =?us-ascii?Q?vAOzTIlf3reVFX6jcOWagcMaIYuU2xWW8dL43jJikTYNX3xsjiHlJLkBaXEy?= =?us-ascii?Q?j/Ls9tos2sdvPjwqeHq76ukB5wPbfnlfiOquMDhCl2rxaQPAPf6djmNq+tv8?= =?us-ascii?Q?VVcHLuRtYCrCNRzTg/Z97GoBh4mD2d5dTaH6DJ81VLkJGuApDHKBPvLsivYI?= =?us-ascii?Q?UkQGDDtb8dEmh+IUVKBwNBiW1nEA25481si8V3Uvt/uF2APtqpkRgxCgRbt7?= =?us-ascii?Q?/9ExFFq2H1EJSl91eZT28ugM3iUbZVYjxMqqvV+dAEXnfZXP7CF+3Zu7rnCw?= =?us-ascii?Q?zcZ1/PcEnmb79zj0Q+XueocE5d+A9gaUygZ0mibV+tWZyspp/PQf67oNWTvp?= =?us-ascii?Q?hC+ub4GXP05/tecMkLMqtv8eNi4rDpYdgw0TriIrG9GHOc7I3NJ8yxzvJX+f?= =?us-ascii?Q?lmr+EIe6g1AdrGbOAexLnr3OqFwLb9LcIMzN7SHoBO/eql5dBKX/+cL+tg2A?= =?us-ascii?Q?68UdhLt28a/YP/UJyuhiuUsjdziz1imVy+sFWeeKp7Bjxe86RNqG3EAWt5FS?= =?us-ascii?Q?695pascLtmLe83SHCTQHeEuM7cXo3M7bODgOItYwvtNxeNpHyVMlzkXbnSyp?= =?us-ascii?Q?Ii/z9J+O+4ltK/woCHpqKaBJNJSPKhNf7rZJkHy8vtSOHEqVAPgGTMDAmuZe?= =?us-ascii?Q?sryh6R2LwEpM5uH4mj9T/ra50kgKwAAa1Mc6HXdrMExxfyTScKsUOcFv83hT?= =?us-ascii?Q?rxvwtb8CgDhMduX6NginMKyT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cda53b77-d475-410b-d938-08d992fe9771 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 12:47:20.7395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nzKISEpusBjD0fCZLlbe4np3HasNH0c7QIvJIDb6GeAbCCDdUbOpt6sJBeQyR3zm/XJm3CoM5IByh6TFZsUWAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4483 X-Proofpoint-GUID: p2e9Ww7PObBe3s9CxJy8n4YQOKB96Beb X-Proofpoint-ORIG-GUID: p2e9Ww7PObBe3s9CxJy8n4YQOKB96Beb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-19_01,2021-10-19_01,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v3 6/7] cryptodev: update fast path APIs to use new flat array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > @@ -1832,13 +1832,18 @@ static inline uint16_t > > rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id, > > struct rte_crypto_op **ops, uint16_t nb_ops) > > { > > - struct rte_cryptodev *dev =3D &rte_cryptodevs[dev_id]; > > + const struct rte_crypto_fp_ops *fp_ops; > > + void *qp; > > > > rte_cryptodev_trace_dequeue_burst(dev_id, qp_id, (void **)ops, > nb_ops); > > - nb_ops =3D (*dev->dequeue_burst) > > - (dev->data->queue_pairs[qp_id], ops, nb_ops); > > + > > + fp_ops =3D &rte_crypto_fp_ops[dev_id]; > > + qp =3D fp_ops->qp.data[qp_id]; > > + > > + nb_ops =3D fp_ops->dequeue_burst(qp, ops, nb_ops); > > + > > #ifdef RTE_CRYPTO_CALLBACKS > > - if (unlikely(dev->deq_cbs !=3D NULL)) { > > + if (unlikely(fp_ops->qp.deq_cb !=3D NULL)) { > > struct rte_cryptodev_cb_rcu *list; > > struct rte_cryptodev_cb *cb; >=20 > As I ca see you decided to keep call-back related data-structs as public = API. > I wonder that's to avoid extra changes with CB related code? > Or performance reasons? > Or probably something else? I just wanted to avoid extra changes and it did not look that important at = this point Compared to other patches. I would have done the changes if I had some more time.